What. The bundle that TestTheKnowledgeBaseOverTheBus starts (built in the test's own TestMain) now gets a fixed clock, bundleDay = 2026-10-11 09:00 UTC, the day the fixture's proposal (valid) is dated. Test code only; no production change.
Why. The bundle ran on the real clock, so it dated the reservation of ADR 0300 from today, while the proposal kept the fixture's 2026-10-11. From 2026-10-12 on, the date rule (a new record is dated from the day its number was reserved) refused it, and the test failed on main. The in-process tests already inject the same clock through newWorld; the bus test's subprocess did not.
How it was tested.
On main today (2026-10-12): go test -run TestTheKnowledgeBaseOverTheBus fails with date: a new record is dated from the day its number was reserved, 2026-10-12, not 2026-10-11.
On this branch: it passes; go vet and go test ./... of modules/mesh-knowledge pass.
MESH_CHECK_MODULES=mesh-knowledge sh merge-check.sh passes locally (words, agent-home, paths, module tests; the manifest read was NOT CHECKED locally, no controller built beside it).
Fixes issue 540.
**What.** The bundle that `TestTheKnowledgeBaseOverTheBus` starts (built in the test's own `TestMain`) now gets a fixed clock, `bundleDay` = 2026-10-11 09:00 UTC, the day the fixture's proposal (`valid`) is dated. Test code only; no production change.
**Why.** The bundle ran on the real clock, so it dated the reservation of ADR 0300 from today, while the proposal kept the fixture's 2026-10-11. From 2026-10-12 on, the date rule (a new record is dated from the day its number was reserved) refused it, and the test failed on main. The in-process tests already inject the same clock through `newWorld`; the bus test's subprocess did not.
**How it was tested.**
- On main today (2026-10-12): `go test -run TestTheKnowledgeBaseOverTheBus` fails with `date: a new record is dated from the day its number was reserved, 2026-10-12, not 2026-10-11`.
- On this branch: it passes; `go vet` and `go test ./...` of modules/mesh-knowledge pass.
- `MESH_CHECK_MODULES=mesh-knowledge sh merge-check.sh` passes locally (words, agent-home, paths, module tests; the manifest read was NOT CHECKED locally, no controller built beside it).
Fixes issue 540.
Deliverynovox/mesh-catalog@7628b0e5b9f8 — delivered since 2026-10-12T10:31:22Z
Delivery plan — builds nothing: the change touches no module of the mesh's graph
Transitions
2026-10-12 10:23 (new) → proposed (announced): novox/mesh-catalog#235's head announced
2026-10-12 10:27 proposed → checked (checked): the verdict names this commit
2026-10-12 10:27 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
2026-10-12 10:31 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
2026-10-12 10:31 published → delivered (done): nothing for a walk to move
The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.
<!-- mesh-delivery:view -->
**Delivery** `novox/mesh-catalog@7628b0e5b9f8` — **delivered** since 2026-10-12T10:31:22Z
**Delivery plan** — builds nothing: the change touches no module of the mesh's graph
**Transitions**
- 2026-10-12 10:23 (new) → proposed (announced): novox/mesh-catalog#235's head announced
- 2026-10-12 10:27 proposed → checked (checked): the verdict names this commit
- 2026-10-12 10:27 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
- 2026-10-12 10:31 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
- 2026-10-12 10:31 published → delivered (done): nothing for a walk to move
The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Checked independently in a fresh clone (mesh-catalog-235-review):
The diff touches only modules/mesh-knowledge/cmd/mesh-knowledge/kit_test.go, adding bundleDay and setting k.Now on the bundle TestMain starts for the bus test's subprocess. No production file changes.
Production still uses the real clock: main() builds the KB with newKB(st) (main.go), which does not set Now, so (*KB).now() (kb.go:103-108) falls through to time.Now().UTC(). Only the test's own bundle process gets the fixed Now, matching how newWorld already fixes the clock for the in-process tests.
Reproduced the failure on main at today's date (2026-10-12): TestTheKnowledgeBaseOverTheBus fails with date: a new record is dated from the day its number was reserved, 2026-10-12, not 2026-10-11 — exactly the error the PR body describes. Checking out the head commit's kit_test.go makes it pass.
grep -rn "time.Now()" **/*_test.go in the module finds only the poll-deadline in bus_test.go (time.Now().Add(5*time.Second) / time.Now().Before(deadline)), which is a timeout guard, not date-dependent assertion logic. No other test depends on the real date.
go vet ./... is clean; go test ./... passes (16s) in modules/mesh-knowledge at the head commit.
mesh/merge-gate and mesh/repo-check are both green on 7628b0e (merge-gate: "the change touches no module of the mesh's graph"; repo-check: "its merge-check.sh passed").
Test-only change, cause and fix both confirmed, no sign of a hidden production date bug.
Verdict: approve at 7628b0e
Checked independently in a fresh clone (`mesh-catalog-235-review`):
- The diff touches only `modules/mesh-knowledge/cmd/mesh-knowledge/kit_test.go`, adding `bundleDay` and setting `k.Now` on the bundle `TestMain` starts for the bus test's subprocess. No production file changes.
- Production still uses the real clock: `main()` builds the KB with `newKB(st)` (`main.go`), which does not set `Now`, so `(*KB).now()` (`kb.go:103-108`) falls through to `time.Now().UTC()`. Only the test's own bundle process gets the fixed `Now`, matching how `newWorld` already fixes the clock for the in-process tests.
- Reproduced the failure on main at today's date (2026-10-12): `TestTheKnowledgeBaseOverTheBus` fails with `date: a new record is dated from the day its number was reserved, 2026-10-12, not 2026-10-11` — exactly the error the PR body describes. Checking out the head commit's `kit_test.go` makes it pass.
- `grep -rn "time.Now()" **/*_test.go` in the module finds only the poll-deadline in `bus_test.go` (`time.Now().Add(5*time.Second)` / `time.Now().Before(deadline)`), which is a timeout guard, not date-dependent assertion logic. No other test depends on the real date.
- `go vet ./...` is clean; `go test ./...` passes (16s) in `modules/mesh-knowledge` at the head commit.
- `mesh/merge-gate` and `mesh/repo-check` are both green on 7628b0e (merge-gate: "the change touches no module of the mesh's graph"; repo-check: "its merge-check.sh passed").
Test-only change, cause and fix both confirmed, no sign of a hidden production date bug.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
What. The bundle that
TestTheKnowledgeBaseOverTheBusstarts (built in the test's ownTestMain) now gets a fixed clock,bundleDay= 2026-10-11 09:00 UTC, the day the fixture's proposal (valid) is dated. Test code only; no production change.Why. The bundle ran on the real clock, so it dated the reservation of ADR 0300 from today, while the proposal kept the fixture's 2026-10-11. From 2026-10-12 on, the date rule (a new record is dated from the day its number was reserved) refused it, and the test failed on main. The in-process tests already inject the same clock through
newWorld; the bus test's subprocess did not.How it was tested.
go test -run TestTheKnowledgeBaseOverTheBusfails withdate: a new record is dated from the day its number was reserved, 2026-10-12, not 2026-10-11.go vetandgo test ./...of modules/mesh-knowledge pass.MESH_CHECK_MODULES=mesh-knowledge sh merge-check.shpasses locally (words, agent-home, paths, module tests; the manifest read was NOT CHECKED locally, no controller built beside it).Fixes issue 540.
Delivery
novox/mesh-catalog@7628b0e5b9f8— delivered since 2026-10-12T10:31:22ZDelivery plan — builds nothing: the change touches no module of the mesh's graph
Transitions
The commit's note under
refs/notes/mesh-plankeeps every transition:git log --notes=mesh-plan.Verdict: approve at
7628b0eChecked independently in a fresh clone (
mesh-catalog-235-review):modules/mesh-knowledge/cmd/mesh-knowledge/kit_test.go, addingbundleDayand settingk.Nowon the bundleTestMainstarts for the bus test's subprocess. No production file changes.main()builds the KB withnewKB(st)(main.go), which does not setNow, so(*KB).now()(kb.go:103-108) falls through totime.Now().UTC(). Only the test's own bundle process gets the fixedNow, matching hownewWorldalready fixes the clock for the in-process tests.TestTheKnowledgeBaseOverTheBusfails withdate: a new record is dated from the day its number was reserved, 2026-10-12, not 2026-10-11— exactly the error the PR body describes. Checking out the head commit'skit_test.gomakes it pass.grep -rn "time.Now()" **/*_test.goin the module finds only the poll-deadline inbus_test.go(time.Now().Add(5*time.Second)/time.Now().Before(deadline)), which is a timeout guard, not date-dependent assertion logic. No other test depends on the real date.go vet ./...is clean;go test ./...passes (16s) inmodules/mesh-knowledgeat the head commit.mesh/merge-gateandmesh/repo-checkare both green on7628b0e(merge-gate: "the change touches no module of the mesh's graph"; repo-check: "its merge-check.sh passed").Test-only change, cause and fix both confirmed, no sign of a hidden production date bug.