betterbird: lock the ask to be the default mail client off (hq issue 345) #253

Merged
mesh-admin merged 1 commits from fix/345-no-default-client-check into main 2026-10-12 18:23:50 +00:00
Contributor

What: the module's enterprise policy (/opt/betterbird/distribution/policies.json) gains Preferences mail.shell.checkDefaultClient = false, Status locked. policyProblem requires it, so betterbird_status says a policy without it; betterbird_check gains a finding when Betterbird would ask at its start (no lock, and the profile's user.js/prefs.js does not turn it off). README says why.

Why: the operator saw Betterbird 153.4.0 on shanks ask at start to become the default for mail/news/feeds/calendar files. Evidence from the pinned release (betterbird-153.4.0esr-bb10, sha256 38dd2489...): omni.ja defaults/pref/all-thunderbird.js:105 pref("mail.shell.checkDefaultClient", true); chrome/messenger/content/messenger/messenger.js opens systemIntegrationDialog.xhtml while shellService.shouldCheckDefaultClient is true; libxul.so carries the pref name (the GNOME shell service reads it). modules/policies/policies-schema.json has no dedicated policy for it; modules/policies/Policies.sys.mjs Preferences accepts the mail. prefix and Status locked. Locked rather than a defaults/pref file: the dialog's own "always check" box writes a user value into prefs.js, which beats a default; a lock beats the profile and greys the box out. betterbird_prefs on shanks before: mail.shell.* not set (Betterbird's default, true).

Tests: TestTheDefaultClientAskIsLockedOffAndTheCheckSaysWhenItIsOn (new) plus the existing policy/status tests fail without the policies.json change; go test ./... in the module, and merge-check.sh with MESH_CHECK_MODULES=betterbird and MESH_GATE from mesh-controller main: green locally.

Does not touch the accounts resource, so no overlap with #252 (issue 168, takes-settings on accounts).

Fixes issue 345 (the default-client window).

What: the module's enterprise policy (/opt/betterbird/distribution/policies.json) gains Preferences mail.shell.checkDefaultClient = false, Status locked. policyProblem requires it, so betterbird_status says a policy without it; betterbird_check gains a finding when Betterbird would ask at its start (no lock, and the profile's user.js/prefs.js does not turn it off). README says why. Why: the operator saw Betterbird 153.4.0 on shanks ask at start to become the default for mail/news/feeds/calendar files. Evidence from the pinned release (betterbird-153.4.0esr-bb10, sha256 38dd2489...): omni.ja defaults/pref/all-thunderbird.js:105 pref("mail.shell.checkDefaultClient", true); chrome/messenger/content/messenger/messenger.js opens systemIntegrationDialog.xhtml while shellService.shouldCheckDefaultClient is true; libxul.so carries the pref name (the GNOME shell service reads it). modules/policies/policies-schema.json has no dedicated policy for it; modules/policies/Policies.sys.mjs Preferences accepts the mail. prefix and Status locked. Locked rather than a defaults/pref file: the dialog's own "always check" box writes a user value into prefs.js, which beats a default; a lock beats the profile and greys the box out. betterbird_prefs on shanks before: mail.shell.* not set (Betterbird's default, true). Tests: TestTheDefaultClientAskIsLockedOffAndTheCheckSaysWhenItIsOn (new) plus the existing policy/status tests fail without the policies.json change; go test ./... in the module, and merge-check.sh with MESH_CHECK_MODULES=betterbird and MESH_GATE from mesh-controller main: green locally. Does not touch the accounts resource, so no overlap with #252 (issue 168, takes-settings on accounts). Fixes issue 345 (the default-client window).
mesh-admin added 1 commit 2026-10-12 18:17:48 +00:00
betterbird: lock the ask to be the default mail client off, so it never shows at a start (hq issue 345)
mesh/merge-gate head 481e44cdaa29 merged into trunk 23ea0f431faf — pass: builds betterbird, sent nowhere; no bus step; 1 wait(s) for a person; every machin…
mesh/repo-check head 481e44cdaa29 merged into trunk 23ea0f431faf — pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-…
mesh/delivery delivered
481e44cdaa
Betterbird's own default asks at every start with a window to become the default for mail, news, feeds and
calendar files. The policy locks mail.shell.checkDefaultClient off, which wins over a profile's own value, and
betterbird_check says when a node would still ask.
Author
Contributor

Delivery novox/mesh-catalog@481e44cdaa29 — delivered since 2026-10-12T18:25:28Z

Delivery plan — builds betterbird, sent nowhere; no bus step; 1 wait(s) for a person

  • tier 0: betterbird
  • shanks: waits for a person: betterbird
  • betterbird waits for a person: its policy records (person)

Transitions

  • 2026-10-12 18:18 (new) → proposed (announced): novox/mesh-catalog#253's head announced
  • 2026-10-12 18:20 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-12 18:20 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 18:24 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 18:24 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-12 18:25 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@481e44cdaa29` — **delivered** since 2026-10-12T18:25:28Z **Delivery plan** — builds betterbird, sent nowhere; no bus step; 1 wait(s) for a person - tier 0: betterbird - shanks: waits for a person: betterbird - betterbird waits for a person: its policy records (person) **Transitions** - 2026-10-12 18:18 (new) → proposed (announced): novox/mesh-catalog#253's head announced - 2026-10-12 18:20 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-12 18:20 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 18:24 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 18:24 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-12 18:25 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 481e44cd
Judged: head 481e44cdaa29 merged into trunk 23ea0f431faf; read beside it: mesh-controller d8f36a8fb706, mesh-controller-main d8f36a8fb706, mesh-host 303d4037e84e, mesh-tools 954e1a53eef9

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: betterbird)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds betterbird, sent nowhere; no bus step; 1 wait(s) for a person

  • tier 0: betterbird
  • shanks: waits for a person: betterbird
  • betterbird waits for a person: its policy records (person)
  • read by no module's build: modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/install_test.go

Run by the build seat on shanks as build-1791829081251924804 (builds --log build-1791829081251924804).

--- the gate: betterbird
betterbird: ok, 8 tool(s), invokes seat:mesh-controller.settings
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T18:17:33Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T18:17:33Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): betterbird

notes:
  - modules/betterbird/README.md and modules/betterbird/cmd/betterbird-tools/install_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.003s
words: 12 retired words and 70 daemons' lines, none in the 44433 strings of 701 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.013s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 69, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.240s
testing modules/betterbird
ok  	betterbird/cmd/betterbird-tools	1.610s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `481e44cd` Judged: head `481e44cdaa29` merged into trunk `23ea0f431faf`; read beside it: mesh-controller `d8f36a8fb706`, mesh-controller-main `d8f36a8fb706`, mesh-host `303d4037e84e`, mesh-tools `954e1a53eef9` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: betterbird) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds betterbird, sent nowhere; no bus step; 1 wait(s) for a person - tier 0: betterbird - shanks: waits for a person: betterbird - betterbird waits for a person: its policy records (person) - read by no module's build: modules/betterbird/README.md, modules/betterbird/cmd/betterbird-tools/install_test.go Run by the build seat on shanks as `build-1791829081251924804` (`builds --log build-1791829081251924804`). ``` --- the gate: betterbird betterbird: ok, 8 tool(s), invokes seat:mesh-controller.settings long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T18:17:33Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T18:17:33Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): betterbird notes: - modules/betterbird/README.md and modules/betterbird/cmd/betterbird-tools/install_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.003s words: 12 retired words and 70 daemons' lines, none in the 44433 strings of 701 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.013s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 69, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.240s testing modules/betterbird ok betterbird/cmd/betterbird-tools 1.610s --- its merge-check-typescript.sh (typescript toolchain) ```
mesh-admin left a comment
Author
Contributor

Verdict: approve at 481e44cdaa

Independent review (fresh clone, head checked out by sha).

Preference and policy, verified in the pinned release (betterbird-153.4.0esr-bb10, application.ini Version=153.4.0):

  • omni.ja defaults/pref/all-thunderbird.js:105 is pref("mail.shell.checkDefaultClient", true); libxul carries the name; messenger.js:604-625 opens systemIntegrationDialog.xhtml when shellService.shouldCheckDefaultClient and a default account exist and Betterbird is not the default. The SearchIntegration branch is Windows/macOS only, so on Linux the pref is the whole trigger.
  • modules/policies/Policies.sys.mjs Preferences (line 1015): "mail." is in allowedPrefixes; an object with Status other than user/clear writes the default branch, a boolean Value goes through setBoolPref, and Status "locked" calls Services.prefs.lockPref (line 1137). policies-schema.json Preferences accepts {Value: boolean, Status: enum default|locked|user|clear}. No dedicated policy exists for it. A locked default beats a user value in prefs.js, so the dialog's own checkbox cannot turn it back on.

policies.json: valid JSON (python json.tool); DisableAppUpdate true and the Owl ExtensionSettings entry (force_installed, file:///opt/betterbird/owl/owl.xpi, updates_disabled) unchanged.

Check logic, read and exercised: policy lock present -> no finding; policy without the lock + prefs.js true -> finding; policy without the lock + prefs.js false -> none; unset -> finding (Betterbird's default asks); user.js is read before prefs.js, which matches user.js winning at the start. A Status "default" policy is said by policyProblem as not locked. Value != false on an any decoded from JSON compares correctly.

Tests: go vet and go test -race -count=1 pass in modules/betterbird. With policies.json reverted to main, TestTheDefaultClientAskIsLockedOffAndTheCheckSaysWhenItIsOn fails (the module's policy locks the ask off, yet: ...); with install.go/betterbird.go reverted it does not build. merge-check.sh with MESH_CHECK_MODULES=betterbird and MESH_GATE built from mesh-controller main (a681227): exit 0; the gate's module check passes 127 manifests, health-undeclared count 69 as kept.

Statuses at this head: mesh/merge-gate success (merged into trunk 23ea0f4, builds betterbird, 1 wait for a person), mesh/repo-check success, mesh/delivery success (ready: it delivers once merged).

Non-blocking note: defaultClientAsk treats the policy as locking the ask whenever policyProblem's answer does not name the pref. policyProblem returns its first problem, so a placed policy broken earlier (unparseable, updater on, Owl wrong) and without the lock gives no ask finding; I confirmed it with a throwaway test ({"policies":{"ExtensionSettings":{}}} -> only the policy finding). The policy finding with the same remedy still fires when the mesh installed Betterbird, so nothing passes silently today; checking the Preferences entry on its own in defaultClientAsk would make the finding independent of that order. Small README nit: none.

Verdict: approve at 481e44cdaa29354082dad9b13d07c410a119e9fa Independent review (fresh clone, head checked out by sha). Preference and policy, verified in the pinned release (betterbird-153.4.0esr-bb10, application.ini Version=153.4.0): - omni.ja defaults/pref/all-thunderbird.js:105 is pref("mail.shell.checkDefaultClient", true); libxul carries the name; messenger.js:604-625 opens systemIntegrationDialog.xhtml when shellService.shouldCheckDefaultClient and a default account exist and Betterbird is not the default. The SearchIntegration branch is Windows/macOS only, so on Linux the pref is the whole trigger. - modules/policies/Policies.sys.mjs Preferences (line 1015): "mail." is in allowedPrefixes; an object with Status other than user/clear writes the default branch, a boolean Value goes through setBoolPref, and Status "locked" calls Services.prefs.lockPref (line 1137). policies-schema.json Preferences accepts {Value: boolean, Status: enum default|locked|user|clear}. No dedicated policy exists for it. A locked default beats a user value in prefs.js, so the dialog's own checkbox cannot turn it back on. policies.json: valid JSON (python json.tool); DisableAppUpdate true and the Owl ExtensionSettings entry (force_installed, file:///opt/betterbird/owl/owl.xpi, updates_disabled) unchanged. Check logic, read and exercised: policy lock present -> no finding; policy without the lock + prefs.js true -> finding; policy without the lock + prefs.js false -> none; unset -> finding (Betterbird's default asks); user.js is read before prefs.js, which matches user.js winning at the start. A Status "default" policy is said by policyProblem as not locked. Value != false on an any decoded from JSON compares correctly. Tests: go vet and go test -race -count=1 pass in modules/betterbird. With policies.json reverted to main, TestTheDefaultClientAskIsLockedOffAndTheCheckSaysWhenItIsOn fails (the module's policy locks the ask off, yet: ...); with install.go/betterbird.go reverted it does not build. merge-check.sh with MESH_CHECK_MODULES=betterbird and MESH_GATE built from mesh-controller main (a681227): exit 0; the gate's module check passes 127 manifests, health-undeclared count 69 as kept. Statuses at this head: mesh/merge-gate success (merged into trunk 23ea0f4, builds betterbird, 1 wait for a person), mesh/repo-check success, mesh/delivery success (ready: it delivers once merged). Non-blocking note: defaultClientAsk treats the policy as locking the ask whenever policyProblem's answer does not name the pref. policyProblem returns its first problem, so a placed policy broken earlier (unparseable, updater on, Owl wrong) and without the lock gives no ask finding; I confirmed it with a throwaway test ({"policies":{"ExtensionSettings":{}}} -> only the policy finding). The policy finding with the same remedy still fires when the mesh installed Betterbird, so nothing passes silently today; checking the Preferences entry on its own in defaultClientAsk would make the finding independent of that order. Small README nit: none.
mesh-admin merged commit 22071dabfc into main 2026-10-12 18:23:50 +00:00
mesh-admin deleted branch fix/345-no-default-client-check 2026-10-12 18:23:50 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#253