novox/mesh-catalog
3
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

Correct lavinmq Dockerfile's stale MESH_TOOL_MODULES comment (061 review) #28

Merged
jschoubben merged 1 commits from fix/lavinmq-dockerfile-comment into main 2026-09-20 11:42:03 +00:00
Conversation 0 Commits 1 Files Changed 1
+6 -5
jschoubben commented 2026-09-20 11:41:46 +00:00
Owner
Copy Link
Copy Source

The comment still said the provisioner isn't in MESH_TOOL_MODULES and runs via a container's args — but the 061 fix put it in MESH_TOOL_MODULES (serve mode) and dropped the args. A future editor trusting the comment could strip it and silently reintroduce issue 061. Comment now matches the code; only the run-once bootstrap runs via args. No functional change.

The comment still said the provisioner isn't in `MESH_TOOL_MODULES` and runs via a container's `args` — but the 061 fix put it in `MESH_TOOL_MODULES` (serve mode) and dropped the args. A future editor trusting the comment could strip it and silently reintroduce issue 061. Comment now matches the code; only the run-once bootstrap runs via args. No functional change.
jschoubben added 1 commit 2026-09-20 11:41:47 +00:00
Correct lavinmq Dockerfile's stale MESH_TOOL_MODULES comment (061 review) 17243b72df 
The comment still said the provisioner is not listed and runs via a
container's args — but the 061 fix put it in MESH_TOOL_MODULES (serve
mode) and dropped the args. A future editor trusting the comment could
strip it again and silently reintroduce 061. Comment now matches the
code; only the run-once bootstrap runs via args.
jschoubben merged commit 4ce9de6f3a into main 2026-09-20 11:42:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jschoubben miel.truyen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#28