Put a group's composed check out of date when a member is rechecked (issue 867, ADR 0323 §6) #327

Merged

mesh-tools merged 1 commits from fix/867-recheck-asks-the-group-again into main 2026-10-16 01:20:20 +00:00

Conversation 3 Commits 1 Files Changed 2

+88

mesh-tools commented 2026-10-16 01:18:09 +00:00

Member

Copy Link

Copy Source

Issue 867, found live: after mesh-host#114's recheck passed at 03:12 (judged by the group's controller), group 57-config-and-provisioning kept its failed composed verdict from 02:38 (build-1792111097169130557) for the same heads and was never asked again. ADR 0323 §6 (in force): the composed check runs again when a member is rechecked.

• modules/mesh-delivery Holder.Recheck (verbs.go): marks the member's group's composed check OutOfDate, answered or still running; the existing rule (holder.go about 1809) asks delivery-check again once every member is judged again and ready; a late answer of the old run is dropped by its id. Meanwhile the group reads "checking" with the reason.
• Tests: TestAMembersRecheckAsksTheGroupsComposedCheckAgain, TestARecheckWhileTheComposedCheckRunsAsksTheGroupAgain; both fail before the fix.

modules/mesh-delivery go test ok; merge-check.sh with MESH_CHECK_MODULES="mesh-delivery" exit 0. Review: independent Opus review, 2 rounds, APPROVE at this content (local 02ff8fff, tree bba2c7d5 equal).

Issue 867, found live: after mesh-host#114's recheck passed at 03:12 (judged by the group's controller), group 57-config-and-provisioning kept its failed composed verdict from 02:38 (build-1792111097169130557) for the same heads and was never asked again. ADR 0323 §6 (in force): the composed check runs again when a member is rechecked. - modules/mesh-delivery Holder.Recheck (verbs.go): marks the member's group's composed check OutOfDate, answered or still running; the existing rule (holder.go about 1809) asks delivery-check again once every member is judged again and ready; a late answer of the old run is dropped by its id. Meanwhile the group reads "checking" with the reason. - Tests: TestAMembersRecheckAsksTheGroupsComposedCheckAgain, TestARecheckWhileTheComposedCheckRunsAsksTheGroupAgain; both fail before the fix. modules/mesh-delivery go test ok; merge-check.sh with MESH_CHECK_MODULES="mesh-delivery" exit 0. Review: independent Opus review, 2 rounds, APPROVE at this content (local 02ff8fff, tree bba2c7d5 equal).

mesh-tools added 1 commit 2026-10-16 01:18:09 +00:00

Put a group's composed check out of date when a member is rechecked (issue 867, ADR 0323 §6) ... c7c784161d

After mesh-host#114's recheck passed, group 57-config-and-provisioning kept its failed composed verdict for the same heads and was never asked again. A recheck now marks the member's group's composed check out of date, answered or still running, so it is asked again once every member is judged again and ready; a late answer from the old run is dropped.

Co-Authored-By: Claude <noreply@anthropic.com>

mesh-tools added the mesh/ready label 2026-10-16 01:18:15 +00:00

mesh-tools commented 2026-10-16 01:18:19 +00:00

Author

Member

Copy Link

Copy Source

ready at c7c784161d

ready at c7c784161dcd47f544694be7e9081d50cf22ffaf

mesh-tools commented 2026-10-16 01:18:20 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/mesh-catalog@c7c784161dcd — delivered since 2026-10-16T01:21:22Z

Delivery plan — builds mesh-delivery → novox; no bus step

• tier 0: mesh-delivery
• novox: receives mesh-delivery

Machines

• mesh-delivery on every machine running it: sent

Transitions

• 2026-10-16 01:18 (new) → proposed (announced): novox/mesh-catalog#327's head announced
• 2026-10-16 01:20 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-16 01:20 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
• 2026-10-16 01:20 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
• 2026-10-16 01:20 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
• 2026-10-16 01:21 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@c7c784161dcd` — **delivered** since 2026-10-16T01:21:22Z **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery **Machines** - mesh-delivery on every machine running it: sent **Transitions** - 2026-10-16 01:18 (new) → proposed (announced): novox/mesh-catalog#327's head announced - 2026-10-16 01:20 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-16 01:20 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-16 01:20 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-16 01:20 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-16 01:21 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-tools commented 2026-10-16 01:20:18 +00:00

Author

Member

Copy Link

Copy Source

Merge check at c7c78416
Judged: head c7c784161dcd merged into trunk 0fdacb98399d; read beside it: mesh-controller d70bb1f38867, mesh-controller-main d70bb1f38867, mesh-host 198fd34ec497, mesh-tools 6b3e15042fee

• mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery)
• mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds mesh-delivery → novox; no bus step

• tier 0: mesh-delivery
• novox: receives mesh-delivery
• read by no module's build: modules/mesh-delivery/cmd/mesh-delivery/recheck_test.go

Run by the build seat on ace as build-1792113490895796459 (builds --log build-1792113490895796459).

--- the gate: mesh-delivery
mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, seat:mesh-controller.forget-checks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, gitea.gitea_merge_pull_request, gitea.gitea_add_comment, gitea.gitea_api, keeps state deliveries, groups
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-16T01:14:49Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-16T01:14:49Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery

notes:
  - modules/mesh-delivery/cmd/mesh-delivery/recheck_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.002s
words: 12 retired words and 70 daemons' lines, none in the 48966 strings of 749 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.011s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/mailstore	0.008s
mail-store: claimed only by mesh-mail
ok  	git.novox.be/novox/mesh-catalog/checks/secrets	0.011s
secrets: no setting can replace a vault secret in a mergeable file (1 known, nested)
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.005s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 62, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.198s
testing modules/mesh-delivery
ok  	mesh-delivery/cmd/mesh-delivery	2.699s
--- its merge-check-typescript.sh (typescript toolchain)

**Merge check** at `c7c78416` Judged: head `c7c784161dcd` merged into trunk `0fdacb98399d`; read beside it: mesh-controller `d70bb1f38867`, mesh-controller-main `d70bb1f38867`, mesh-host `198fd34ec497`, mesh-tools `6b3e15042fee` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-delivery) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds mesh-delivery → novox; no bus step - tier 0: mesh-delivery - novox: receives mesh-delivery - read by no module's build: modules/mesh-delivery/cmd/mesh-delivery/recheck_test.go Run by the build seat on ace as `build-1792113490895796459` (`builds --log build-1792113490895796459`). ``` --- the gate: mesh-delivery mesh-delivery: ok, 1 tool(s), invokes seat:mesh-controller.delivery-plan, seat:mesh-controller.delivery-order, seat:mesh-controller.delivery-check, seat:mesh-controller.deliver, seat:mesh-controller.delivery-stop, seat:mesh-controller.delivery-walks, seat:mesh-controller.forget-checks, gitea.gitea_note_append, gitea.gitea_delivery_view, gitea.gitea_commit_status, gitea.gitea_commit_statuses, gitea.gitea_contains, gitea.gitea_open_pulls, gitea.gitea_merge_pull_request, gitea.gitea_add_comment, gitea.gitea_api, keeps state deliveries, groups long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-16T01:14:49Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-16T01:14:49Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-delivery notes: - modules/mesh-delivery/cmd/mesh-delivery/recheck_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.002s words: 12 retired words and 70 daemons' lines, none in the 48966 strings of 749 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.011s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/mailstore 0.008s mail-store: claimed only by mesh-mail ok git.novox.be/novox/mesh-catalog/checks/secrets 0.011s secrets: no setting can replace a vault secret in a mergeable file (1 known, nested) ok git.novox.be/novox/mesh-catalog/checks/paths 0.005s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 62, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.198s testing modules/mesh-delivery ok mesh-delivery/cmd/mesh-delivery 2.699s --- its merge-check-typescript.sh (typescript toolchain) ```

mesh-tools merged commit 173c5d5ef4 into main 2026-10-16 01:20:20 +00:00

mesh-tools deleted branch fix/867-recheck-asks-the-group-again 2026-10-16 01:20:21 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels mesh/ready

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

jschoubben mesh-tools miel.truyen

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#327