Apply a patch in the forge tool itself when the forge's diffpatch answers 500, so a patch whose context holds a non-ASCII character is taken (issue 1604) #407

Merged

mesh-tools merged 3 commits from fix/1604-patch-applied into main 2026-10-21 10:08:49 +00:00

Conversation 2 Commits 3 Files Changed 4

+788 -6

mesh-tools commented 2026-10-21 09:55:11 +00:00

Member

Copy Link

Copy Source

Issue 1604. The forge's diffpatch answers 500 with an empty message when an unchanged context line of a hunk holds a non-ASCII character (seen with '§', met twice on 2026-10-21).

• modules/gitea/cmd/forge/applypatch.go (new): a unified-diff applier with git apply's rules: exact context, the nearest place, a hunk with oldStart <= 1 anchored at the start, one without trailing context (or whose old side lacks the final newline) anchored at the end; create, delete, rename, C-quoted paths, no-newline markers, CRLF. Copies, binary patches, mode changes, executable files and symlinks are refused with the reason.
• commit.go: diffpatch first; on a 5xx the tool reads each touched file at the commit (content, and its mode through git/trees: anything not 100644 is refused) and commits the resulting files through the contents call, each checked against its blob, so a branch that moved is refused, not overwritten. Default-branch and protection refusals run before; size limits hold; the answer says the tool applied it.

Tests: applypatch_test.go (the '§' case, create/delete/rename, moved hunk and no-newline, anchoring, a hunk that does not apply, executable/mode refusals incl. a pure rename of a 100755 file, CRLF bare-CR, 422 not retried, default branch); five failed on main. mesh-controller.try build-1792576340703463263 passed at 324e3311 (48 s).

Hardening from the review: issue 1626.

Reviewed-by: reviewer-1604@shanks at 324e331184

Issue 1604. The forge's diffpatch answers 500 with an empty message when an unchanged context line of a hunk holds a non-ASCII character (seen with '§', met twice on 2026-10-21). - modules/gitea/cmd/forge/applypatch.go (new): a unified-diff applier with git apply's rules: exact context, the nearest place, a hunk with oldStart <= 1 anchored at the start, one without trailing context (or whose old side lacks the final newline) anchored at the end; create, delete, rename, C-quoted paths, no-newline markers, CRLF. Copies, binary patches, mode changes, executable files and symlinks are refused with the reason. - commit.go: diffpatch first; on a 5xx the tool reads each touched file at the commit (content, and its mode through git/trees: anything not 100644 is refused) and commits the resulting files through the contents call, each checked against its blob, so a branch that moved is refused, not overwritten. Default-branch and protection refusals run before; size limits hold; the answer says the tool applied it. Tests: applypatch_test.go (the '§' case, create/delete/rename, moved hunk and no-newline, anchoring, a hunk that does not apply, executable/mode refusals incl. a pure rename of a 100755 file, CRLF bare-CR, 422 not retried, default branch); five failed on main. mesh-controller.try build-1792576340703463263 passed at 324e3311 (48 s). Hardening from the review: issue 1626. Reviewed-by: reviewer-1604@shanks at 324e331184da02b8430a2779264a3fc92038d8b1

mesh-tools added 3 commits 2026-10-21 09:55:11 +00:00

Apply a unified diff in the forge tool itself, for the patches the forge's diffpatch refuses (issue 1604) e6053262e4

Fall back to the tool's own patch applier when the forge answers 500, with tests (issue 1604) e5cfcb316a

Anchor patch hunks as git apply does, refuse patches touching non-100644 files by their real mode, survive bare-CR context lines (issue 1604 review) 324e331184

mesh-tools commented 2026-10-21 09:55:24 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/mesh-catalog@324e331184da — covered since 2026-10-21T10:59:40Z

Delivery plan — builds gitea → novox; no bus step

• tier 0: gitea
• novox: receives gitea
• gitea provides npm-package-registry, git, gitea-read, forge-account: its consumers are sent again after it
• gitea keeps data (ADR 0233): what it holds is backed up before it moves

Machines

• dev-tools on every machine running it: sent
• mesh-build-go on every machine running it: sent
• mesh-build-node on every machine running it: sent
• mesh-sdk on every machine running it: sent
• mesh-tools on every machine running it: sent
• audit-logger on every machine running it: sent
• confluence on every machine running it: sent
• gitea on every machine running it: sent
• gitlab on every machine running it: sent
• jira on every machine running it: sent
• lab on every machine running it: sent
• mesh-catalog on every machine running it: sent
• model-usage on every machine running it: sent
• openai-consumer on every machine running it: sent
• route-adapter on every machine running it: sent
• showcase on every machine running it: sent

Transitions

• 2026-10-21 09:55 (new) → proposed (announced): novox/mesh-catalog#407's head announced
• 2026-10-21 10:08 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-21 10:08 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
• 2026-10-21 10:35 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
• 2026-10-21 10:36 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
• 2026-10-21 10:59 delivering → covered (covered): covered: a later merge that contains it was delivered: novox/mesh-catalog@e023f69989 (merged as b5dbfbb7 into main, walk plan-1792576951664537534)

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@324e331184da` — **covered** since 2026-10-21T10:59:40Z **Delivery plan** — builds gitea → novox; no bus step - tier 0: gitea - novox: receives gitea - gitea provides npm-package-registry, git, gitea-read, forge-account: its consumers are sent again after it - gitea keeps data (ADR 0233): what it holds is backed up before it moves **Machines** - dev-tools on every machine running it: sent - mesh-build-go on every machine running it: sent - mesh-build-node on every machine running it: sent - mesh-sdk on every machine running it: sent - mesh-tools on every machine running it: sent - audit-logger on every machine running it: sent - confluence on every machine running it: sent - gitea on every machine running it: sent - gitlab on every machine running it: sent - jira on every machine running it: sent - lab on every machine running it: sent - mesh-catalog on every machine running it: sent - model-usage on every machine running it: sent - openai-consumer on every machine running it: sent - route-adapter on every machine running it: sent - showcase on every machine running it: sent **Transitions** - 2026-10-21 09:55 (new) → proposed (announced): novox/mesh-catalog#407's head announced - 2026-10-21 10:08 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-21 10:08 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-21 10:35 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-21 10:36 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-21 10:59 delivering → covered (covered): covered: a later merge that contains it was delivered: novox/mesh-catalog@e023f69989ab (merged as b5dbfbb7 into main, walk plan-1792576951664537534) The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-tools commented 2026-10-21 10:08:08 +00:00

Author

Member

Copy Link

Copy Source

Merge check at 324e3311
Judged: head 324e331184da merged into trunk 0f2cee1bea4e; read beside it: mesh-controller 0205b8f7080a, mesh-controller-main 0205b8f7080a, mesh-host c5c4caa2a4ab, mesh-tools e0fadc43d9dd

• mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: gitea)
• mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds gitea → novox; no bus step

• tier 0: gitea
• novox: receives gitea
• gitea provides npm-package-registry, git, gitea-read, forge-account: its consumers are sent again after it
• gitea keeps data (ADR 0233): what it holds is backed up before it moves

Run by the build seat on shanks as build-1792576520981471870 (builds --log build-1792576520981471870).

✔ the verdict heard while a 'building' write still waits its turn: the 'building' is never written (0.583467ms)
✔ a start heard after the verdict writes nothing (0.511676ms)
✔ a start from before the check now pending (a run before a recheck, the stream's history) writes nothing (0.605667ms)
✔ an old run's verdict redelivered after a recheck's pending is not written over it (1.371155ms)
[gitea] novox/hq@a6b08de8: the verdict of build-1791680941000000000 is an older run's than the check the forge holds pending; not written
[gitea] novox/hq@a6b08de8: the verdict of build-1791680941000000000 is an older run's than the check now pending; not written
✔ an old run's verdict in flight when the recheck comes lands before the recheck's pending (3.613421ms)
✔ a rechecked head says where its new run is: building on which machine (0.991621ms)
✔ the recheck's own verdict is written, even asked a little before the pending by another machine's clock (0.680348ms)
✔ after a restart, an old run's verdict is weighed against the check the forge's history holds open (0.583097ms)
✔ a recheck the forge does not take fails its caller, and the head is as it was (0.519576ms)
✔ the status tool writes the merge check's pending through the writer, and the mesh's other statuses as they were (21.80351ms)
✔ when a check was asked is read from its id; the opening of the check now pending from the gate's history (11.024736ms)
✔ a head this process did not announce (it restarted) is said only while the forge holds its gate pending (1.191853ms)
✔ a repository as the mesh clones it is told from another (0.88944ms)
✔ gitea_api refuses the forge's administration, a branch's protection and the merge check's status, and sends nothing (5.518133ms)
✔ gitea_api refuses a file written to the default branch or one a rule guards, and writes one on a branch of its own (58.749212ms)
✔ a protection rule covers a branch as the forge decides it: classes, alternatives, a plain name in any case (issue 539) (32.719674ms)
✔ gitea_api still writes what an author writes (9.892473ms)
✔ gitea_branch_protection_set only strengthens (18.702934ms)
✔ gitea_merge_pull_request merges only a head whose required statuses all succeeded, and only that head (48.651036ms)
✔ gitea_merge_pull_request refuses a verdict judged against an earlier trunk, and asks the check once (167.304034ms)
✔ gitea_merge_pull_request merges only the head it is named, and refuses one that is not the head (20.219031ms)
✔ gitea_merge_pull_request is loud when the forge merged a head other than the one it was handed (17.340758ms)
✔ gitea_merge_pull_request says the merge happened when reading back what landed fails (28.034151ms)
✔ gitea_merge_pull_request reads back a fast-forward, and says it cannot read back a squash or a rebase (62.880739ms)
✔ gitea_delete_repo deletes only the tools' own user's repository, unguarded, untouched for 30 days, named in full (22.474718ms)
✔ gitea_api sends the path it judged, and refuses moving a pull request's base (3.691852ms)
✔ gitea_merge_pull_request merges only into a branch whose protection requires the checks (6.428863ms)
✔ a rule named for a branch is not made weaker than the glob rule that guards it now (14.105381ms)
✔ a repository owner or name is never another path (0.316954ms)
✔ the judges, without a forge (0.376784ms)
✔ main's protection is never weakened in its push or its merge whitelist (issue 948, ADR 0398 §2) (0.317204ms)
✔ gitea_api never acts as another user: sudo, in any case, and any query key it does not send are refused (1.995343ms)
✔ gitea_api never approves a pull request nor requests changes: those are the operator's (2.713631ms)
✔ no tool's caller text becomes another path or another user: `..` and `?sudo=` are refused before the forge (5.481633ms)
✔ gitea_merge_pull_request merges a verdict that read siblings only with its group passed and each head approved (92.896854ms)
✔ gitea_merge_pull_request refuses a head the Approve did not name (23.369587ms)
✔ a group of two merges in one pass: the sibling's merge of the composed head does not stop the member's merge (issue 1049) (20.596316ms)
✔ gitea_create_repo has no owner argument and posts only to the tools' own user's repositories (1124/AC8) (44.335137ms)
✔ the tools' team cannot create in the organisation and its token holds no write:organization (1124/AC8) (0.387085ms)
✔ no ready mark, trusted ready-authors setting or approval-by-mark rule is left in the module (17.653182ms)
✔ every page of a pull request's files is read, though the forge caps a page at fifty (34.334412ms)
✔ a pass asks only the repositories that moved since the last look, every one before the first (0.605407ms)
✔ the directories above a merge's files that hold a module at the commit are said, the root never (14.581557ms)
✔ a lookup the forge refuses is thrown, not read as no module (4.134677ms)
✔ a renamed file is said under its old name too, as gone (novox/hq ADR 0267) (5.764456ms)
✔ a new head beyond the newest 20 open pull requests is announced, exactly once (66.895135ms)
✔ a pass pages until it reaches back past its floor, and no further (31.335038ms)
✔ gitea_branch_protection_get answers every rule, read with the administrator account the tools' token cannot read with (33.085379ms)
✔ gitea_branch_protection_get answers the rule for a branch, null when it has none (11.853665ms)
✔ gitea_branch_protection_set still gets the forge's refusal, as the tools' account (4.39401ms)
✔ the statuses asked for replace the rule's, and an empty list requires none (4.573033ms)
✔ a new rule refuses direct pushes unless asked; an administrator's override only when said (0.343844ms)
✔ main's body always refuses pushes and lets only the tools' account merge, whatever is asked (0.93142ms)
✔ another branch's body carries no merge whitelist (0.247613ms)
✔ the rule main is put right in the forge's own words: the body a setup sends carries no status checks of its own (0.320113ms)
✔ each open pull request's new head is announced once, and nothing closed or merged (29.440947ms)
✔ a verdict is the head commit's status; an error is the forge's error, never a success (1.156544ms)
✔ each layer is its own status: the gate with the modules it judged, the repository's own check beside it (0.778679ms)
✔ no verdict sets warning on a required check; only a person's decision fails (1.557397ms)
✔ a commit status is set on the commit, under the merge check's context (50.398536ms)
✔ a change plan is the gate's result: said on the status and, when it builds something, as a comment (0.595767ms)
✔ a head announced is pending in the build queue, since the local time it was announced (0.335844ms)
✔ a composed verdict sets every member's gate at its own head, naming its trunk and the group (0.557506ms)
✔ a member's own verdict with a composed gate layer leaves the gate to the composed verdict, in either order (0.679548ms)
✔ the vault's token is used, a setting of it is ignored and said once, without its value (3.043075ms)
[gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 at bbbbbbbbbbbb, it is now at dddddddddddd: out of date, nothing run (novox/hq ADR 0382)
[gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 was closed unmerged: out of date, nothing run (novox/hq ADR 0382)
[gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 merged onto cccccccccccc, its main is now eeeeeeeeeeee: out of date, nothing run (novox/hq ADR 0382)
[gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 was merged otherwise than its head bbbbbbbbbbbb onto cccccccccccc: out of date, nothing run (novox/hq ADR 0382)
[gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 was merged otherwise than its head bbbbbbbbbbbb onto cccccccccccc: out of date, nothing run (novox/hq ADR 0382)
[gitea] novox/mesh-host's main moved from 444444444444 to 333333333333: 0 open pull request(s) into it put out of date, nothing run (novox/hq ADR 0323)
[gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 was merged otherwise than its head bbbbbbbbbbbb onto cccccccccccc: out of date, nothing run (novox/hq ADR 0382)
[gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 was merged otherwise than its head dddddddddddd onto cccccccccccc: out of date, nothing run (novox/hq ADR 0382)
✔ both statuses name the siblings the verdict read, keeping the verdict word and the start of its reason within 140 characters (2.57958ms)
✔ a verdict that could not learn its siblings says so on the status and in the comment, and names none (0.449465ms)
✔ a verdict without siblings is said exactly as before (an older controller) (0.890881ms)
✔ the siblings a verdict names are kept per member, replaced by its next verdict, and removed by one that read none (1.095823ms)
✔ a sibling's new head puts both statuses of the member back to pending, with the reason, and runs nothing (2.334867ms)
✔ a sibling closed unmerged puts the member's verdict out of date (0.539517ms)
✔ a move of the sibling's base puts it out of date, naming both commits (0.564197ms)
✔ the sibling's own merge of the head read onto the base read does not, in either order of the two merges (0.678228ms)
✔ a merge of another head, or onto another base, is a move (0.916781ms)
✔ only the members whose verdict names the sibling are touched, and a member that moved on is dropped (0.83436ms)
✔ a trunk that moved tells the siblings' weighing; one first seen does not (0.855399ms)
✔ the group rule names every missing thing: the group status at each head read, and each head the Approve does not cover (1.511877ms)
✔ a merged or closed member's entry is dropped, so a sibling's later push never re-pends its merged head (0.281343ms)
✔ without the composed verdict's siblings, a sibling's own merge of its new head is a move (the pin of issue 1049) (0.302704ms)
✔ a composed verdict names the siblings of each member at the heads and base commits it composed, so a sibling's own merge of its new head is no move (issue 1049) (0.953781ms)
✔ a composed verdict keeps nothing for a member it cannot name, and a group of one is none (issue 1049) (0.366184ms)
✔ a consumer that asks nothing, or write, publishes: the package team (1.605518ms)
✔ a consumer that asks to read joins the readers, who write no package (0.450796ms)
✔ a reader is made, put on the readers team, and taken off the package team (0.556437ms)
✔ a publisher is made and put on the package team, as before (0.230393ms)
✔ first start: mints with the admin account, keeps the token at 0600, asks for the tools' scopes only (34.694197ms)
✔ second start: reuses the kept token, mints nothing (33.096439ms)
✔ the forge rejects the kept token (its data was restored): minted afresh, once, and the call goes through (33.2445ms)
✔ a token kept with write:admin by an earlier build is minted again without it at the next start, and the forge drops the old one (29.436307ms)
✔ a kept token lacking a scope the tools need: the forge refuses the call for the scope, the token is re-minted with the whole list, and the call goes through (27.423034ms)
✔ the kept file is gone but the forge still holds a token by that name: replaced, not refused (24.886155ms)
✔ concurrent first calls share one mint (13.754838ms)
✔ two tokens hold the name (two mints raced): both are deleted by their id, and one fresh token is minted (14.87958ms)
✔ two processes on one kept file, both without a token, mint once: the second waits for the first and reuses it (76.492424ms)
✔ a lock left by a process that died mid-mint is taken over, not waited on for ever (5.673905ms)
✔ the admin account is refused: said plainly, nothing kept, and the next call fails the same way rather than crashing (16.181035ms)
✔ one process shares one source per kept file — the watcher and the tools never renew against each other (0.992851ms)
✔ a second process finds the token the first renewed, and reuses it instead of minting over it (23.243616ms)
✔ a configured token wins, and is reported rather than minted over when the forge rejects it (2.378677ms)
✔ nothing to mint with and no token: the client says what is missing (0.199483ms)
[gitea] no tools — no Gitea token, and nothing to mint one with — set MESH_GITEA_TOKEN, or MESH_GITEA_ADMIN_USER, MESH_GITEA_ADMIN_PASSWORD_FILE, MESH_GITEA_STATE_DIR
[gitea] no token kept — minting one
[gitea] the forge already holds a token named "mesh-tools" — replacing it
[gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-6TnLo5/state/token
✔ the tools register once there is a way to a token, and the first call mints it (28.968731ms)
[gitea] no token kept — minting one
[gitea] the forge already holds a token named "mesh-tools" — replacing it
[gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-RayOgM/state/token
✔ a pull request can be closed, read and cleaned up through the tools (37.825203ms)
[gitea] no token kept — minting one
[gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-k99DYi/state/token
✔ the tools' token is minted for an account of their own, which is no administrator and writes through its team (92.909213ms)
[gitea] no token kept — minting one
[gitea] the forge already holds a token named "mesh-tools" — replacing it
[gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-dSBAMR/state/token
✔ with the tools' token, the forge writes a status and refuses a protection edit — the forge itself, not a guard (53.211049ms)
[gitea] no token kept — minting one
[gitea] the forge already holds a token named "mesh-tools" — replacing it
[gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-i7C8kL/state/token
✔ what a base's protection asks is read from the branch, which the tools' account may read, not from the rules' list it may not (47.347481ms)
[gitea] the kept token was minted with other scopes than the tools take now — minting one with them
[gitea] the forge already holds a token named "mesh-tools" — replacing it
[gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-4RAz73/state/token
[gitea] deleted 1 token(s) named "mesh-tools" the admin account "mesh-admin" held: the tools act as "mesh-tools" now
✔ the administrator's token from before goes: a kept admin token is minted again for the tools' account, and the forge drops the old one (44.869993ms)
[gitea] no token kept — minting one
[gitea] the forge already holds a token named "mesh-tools" — replacing it
[gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-NQ2ArS/state/token
✔ a tools' account someone made an administrator is made a plain account again at the next mint (35.337255ms)
✔ the tools never act as the administrator: MESH_GITEA_TOOLS_USER naming it is refused (2.305897ms)
✔ the manifest hands the tools their account, and the Go forge bundle holds no administrator password (0.780499ms)
[gitea] no token kept — minting one
[gitea] the forge already holds a token named "mesh-tools" — replacing it
[gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-Y9ZdP3/state/token
✔ a repository check said as a warning on a head without merge-check.sh reads the base's protection from the branch (35.968711ms)
[gitea] no token kept — minting one
✔ a mint that fails leaves the administrator's old token in place: the tools are never left without one (29.086033ms)
[gitea] no token kept — minting one
[gitea] the forge already holds a token named "mesh-tools" — replacing it
[gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-9UAeUy/state/token
[gitea] FAILED to delete the token(s) named "mesh-tools" the admin account "mesh-admin" holds — tried again at the next start: Gitea DELETE /users/mesh-admin/tokens/902 (named mesh-tools): 500 {"message":"the forge is not well"}
✔ an old token that cannot be deleted after the mint is said, the new token kept, and deleted at the next start (44.088955ms)
[gitea] no token kept — minting one
[gitea] the forge already holds a token named "mesh-tools" — replacing it
[gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-p4ebxm/state/token
✔ a team another process made between the look and the create is found, not a failure (38.47848ms)
[gitea] no token kept — minting one
[gitea] the forge already holds a token named "mesh-tools" — replacing it
[gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-RraOAf/state/token
✔ setting the tools' account up puts main's rule right in every repository: no push, only the tools' account merges (issue 948) (38.671292ms)
[gitea] no token kept — minting one
[gitea] the forge already holds a token named "mesh-tools" — replacing it
[gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-Pxbvz7/state/token
✔ a glob rule covering main keeps its statuses when main is given a rule of its own name (issue 948, review round 1) (34.295733ms)
✔ a start with the token kept still puts main's rules right: the module's start asks for it each time (issue 948, review round 1) (12.920848ms)
[gitea] novox/mesh-host's main moved from a2c2c35bbbbb to d28ca95ccccc: 25 open pull request(s) into it put out of date, nothing run (novox/hq ADR 0323)
[gitea] novox/mesh-host's main moved from d28ca95ccccc to ffffffffffff: 0 open pull request(s) into it put out of date, nothing run (novox/hq ADR 0323)
[gitea] novox/mesh-host: whether a trunk moved could not be weighed, so it is weighed again on the next pass — the forge is away
[gitea] novox/mesh-host's main moved from a2c2c35bbbbb to d28ca95ccccc: 0 open pull request(s) into it put out of date, nothing run (novox/hq ADR 0323)
[gitea] novox/mesh-controller's feat/57-config-and-provisioning moved from eeeeeeeeeeee to d28ca95ccccc: 1 open pull request(s) into it put out of date, nothing run (novox/hq ADR 0323)
✔ both statuses say the head and the trunk commit the verdict judged, first, whatever the summary's length (2.62182ms)
✔ a trunk's move puts an open head's merge check out of date, naming both commits, unless a check is on its way (1.467147ms)
✔ a push to a trunk puts every open pull request into it out of date — twenty-five of them — and none into another (5.719186ms)
✔ a trunk that cannot be read is weighed again on the next pass, never recorded half (0.455356ms)
✔ the trunk's move takes its turn after a verdict in flight, and weighs what the forge holds then (0.580897ms)
✔ a verdict judged against a trunk newer than the pass's first read is not put out of date (0.308224ms)
✔ a verdict that landed out of date keeps its account on the pull request (0.442275ms)
✔ a release branch's move puts every open pull request into it out of date, as a trunk's does (ADR 0358 §5) (0.520996ms)
✔ a signed event is published on the bus and acted on once (68.712235ms)
✔ an unsigned event, or one whose signature does not verify, is refused and published nowhere (41.90931ms)
✔ an event and the poll seeing the same head announce it once (0.399824ms)
✔ each forge event is named in the module's stream and trimmed (0.578736ms)
✔ the webhook is made a system webhook, which the forge sends every repository's events to (1.215464ms)
✔ default webhooks left at the receiver by an earlier start are replaced by one system webhook (1.092102ms)
✔ a repository's copy of a default webhook at the receiver is deleted, on every page, and said (3.789253ms)
✔ a forge that makes no system webhook is said, never taken as heard (0.711778ms)
✔ the receiver tells what it verified and what it refused (10.990496ms)
✔ a forge that never delivers is said loudly once, and unhealthy, when the poll finds what no event said (1.163493ms)
✔ a forge whose events stop after one delivery is said loudly once per silent spell, and refusals are unhealthy (0.424005ms)
✔ without a receiver by configuration the polls alone watch, healthy; a receiver that failed is unhealthy (0.381334ms)
✔ the polls look every 30 s until events are heard, every five minutes while they are, and 30 s again on a miss (0.203073ms)
✔ a pull request's edit event carries its description, and no other pull request event does (issue 1079) (0.216412ms)
ℹ tests 163
ℹ suites 0
ℹ pass 163
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 934.939906

**Merge check** at `324e3311` Judged: head `324e331184da` merged into trunk `0f2cee1bea4e`; read beside it: mesh-controller `0205b8f7080a`, mesh-controller-main `0205b8f7080a`, mesh-host `c5c4caa2a4ab`, mesh-tools `e0fadc43d9dd` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: gitea) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds gitea → novox; no bus step - tier 0: gitea - novox: receives gitea - gitea provides npm-package-registry, git, gitea-read, forge-account: its consumers are sent again after it - gitea keeps data (ADR 0233): what it holds is backed up before it moves Run by the build seat on shanks as `build-1792576520981471870` (`builds --log build-1792576520981471870`). ``` ✔ the verdict heard while a 'building' write still waits its turn: the 'building' is never written (0.583467ms) ✔ a start heard after the verdict writes nothing (0.511676ms) ✔ a start from before the check now pending (a run before a recheck, the stream's history) writes nothing (0.605667ms) ✔ an old run's verdict redelivered after a recheck's pending is not written over it (1.371155ms) [gitea] novox/hq@a6b08de8: the verdict of build-1791680941000000000 is an older run's than the check the forge holds pending; not written [gitea] novox/hq@a6b08de8: the verdict of build-1791680941000000000 is an older run's than the check now pending; not written ✔ an old run's verdict in flight when the recheck comes lands before the recheck's pending (3.613421ms) ✔ a rechecked head says where its new run is: building on which machine (0.991621ms) ✔ the recheck's own verdict is written, even asked a little before the pending by another machine's clock (0.680348ms) ✔ after a restart, an old run's verdict is weighed against the check the forge's history holds open (0.583097ms) ✔ a recheck the forge does not take fails its caller, and the head is as it was (0.519576ms) ✔ the status tool writes the merge check's pending through the writer, and the mesh's other statuses as they were (21.80351ms) ✔ when a check was asked is read from its id; the opening of the check now pending from the gate's history (11.024736ms) ✔ a head this process did not announce (it restarted) is said only while the forge holds its gate pending (1.191853ms) ✔ a repository as the mesh clones it is told from another (0.88944ms) ✔ gitea_api refuses the forge's administration, a branch's protection and the merge check's status, and sends nothing (5.518133ms) ✔ gitea_api refuses a file written to the default branch or one a rule guards, and writes one on a branch of its own (58.749212ms) ✔ a protection rule covers a branch as the forge decides it: classes, alternatives, a plain name in any case (issue 539) (32.719674ms) ✔ gitea_api still writes what an author writes (9.892473ms) ✔ gitea_branch_protection_set only strengthens (18.702934ms) ✔ gitea_merge_pull_request merges only a head whose required statuses all succeeded, and only that head (48.651036ms) ✔ gitea_merge_pull_request refuses a verdict judged against an earlier trunk, and asks the check once (167.304034ms) ✔ gitea_merge_pull_request merges only the head it is named, and refuses one that is not the head (20.219031ms) ✔ gitea_merge_pull_request is loud when the forge merged a head other than the one it was handed (17.340758ms) ✔ gitea_merge_pull_request says the merge happened when reading back what landed fails (28.034151ms) ✔ gitea_merge_pull_request reads back a fast-forward, and says it cannot read back a squash or a rebase (62.880739ms) ✔ gitea_delete_repo deletes only the tools' own user's repository, unguarded, untouched for 30 days, named in full (22.474718ms) ✔ gitea_api sends the path it judged, and refuses moving a pull request's base (3.691852ms) ✔ gitea_merge_pull_request merges only into a branch whose protection requires the checks (6.428863ms) ✔ a rule named for a branch is not made weaker than the glob rule that guards it now (14.105381ms) ✔ a repository owner or name is never another path (0.316954ms) ✔ the judges, without a forge (0.376784ms) ✔ main's protection is never weakened in its push or its merge whitelist (issue 948, ADR 0398 §2) (0.317204ms) ✔ gitea_api never acts as another user: sudo, in any case, and any query key it does not send are refused (1.995343ms) ✔ gitea_api never approves a pull request nor requests changes: those are the operator's (2.713631ms) ✔ no tool's caller text becomes another path or another user: `..` and `?sudo=` are refused before the forge (5.481633ms) ✔ gitea_merge_pull_request merges a verdict that read siblings only with its group passed and each head approved (92.896854ms) ✔ gitea_merge_pull_request refuses a head the Approve did not name (23.369587ms) ✔ a group of two merges in one pass: the sibling's merge of the composed head does not stop the member's merge (issue 1049) (20.596316ms) ✔ gitea_create_repo has no owner argument and posts only to the tools' own user's repositories (1124/AC8) (44.335137ms) ✔ the tools' team cannot create in the organisation and its token holds no write:organization (1124/AC8) (0.387085ms) ✔ no ready mark, trusted ready-authors setting or approval-by-mark rule is left in the module (17.653182ms) ✔ every page of a pull request's files is read, though the forge caps a page at fifty (34.334412ms) ✔ a pass asks only the repositories that moved since the last look, every one before the first (0.605407ms) ✔ the directories above a merge's files that hold a module at the commit are said, the root never (14.581557ms) ✔ a lookup the forge refuses is thrown, not read as no module (4.134677ms) ✔ a renamed file is said under its old name too, as gone (novox/hq ADR 0267) (5.764456ms) ✔ a new head beyond the newest 20 open pull requests is announced, exactly once (66.895135ms) ✔ a pass pages until it reaches back past its floor, and no further (31.335038ms) ✔ gitea_branch_protection_get answers every rule, read with the administrator account the tools' token cannot read with (33.085379ms) ✔ gitea_branch_protection_get answers the rule for a branch, null when it has none (11.853665ms) ✔ gitea_branch_protection_set still gets the forge's refusal, as the tools' account (4.39401ms) ✔ the statuses asked for replace the rule's, and an empty list requires none (4.573033ms) ✔ a new rule refuses direct pushes unless asked; an administrator's override only when said (0.343844ms) ✔ main's body always refuses pushes and lets only the tools' account merge, whatever is asked (0.93142ms) ✔ another branch's body carries no merge whitelist (0.247613ms) ✔ the rule main is put right in the forge's own words: the body a setup sends carries no status checks of its own (0.320113ms) ✔ each open pull request's new head is announced once, and nothing closed or merged (29.440947ms) ✔ a verdict is the head commit's status; an error is the forge's error, never a success (1.156544ms) ✔ each layer is its own status: the gate with the modules it judged, the repository's own check beside it (0.778679ms) ✔ no verdict sets warning on a required check; only a person's decision fails (1.557397ms) ✔ a commit status is set on the commit, under the merge check's context (50.398536ms) ✔ a change plan is the gate's result: said on the status and, when it builds something, as a comment (0.595767ms) ✔ a head announced is pending in the build queue, since the local time it was announced (0.335844ms) ✔ a composed verdict sets every member's gate at its own head, naming its trunk and the group (0.557506ms) ✔ a member's own verdict with a composed gate layer leaves the gate to the composed verdict, in either order (0.679548ms) ✔ the vault's token is used, a setting of it is ignored and said once, without its value (3.043075ms) [gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 at bbbbbbbbbbbb, it is now at dddddddddddd: out of date, nothing run (novox/hq ADR 0382) [gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 was closed unmerged: out of date, nothing run (novox/hq ADR 0382) [gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 merged onto cccccccccccc, its main is now eeeeeeeeeeee: out of date, nothing run (novox/hq ADR 0382) [gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 was merged otherwise than its head bbbbbbbbbbbb onto cccccccccccc: out of date, nothing run (novox/hq ADR 0382) [gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 was merged otherwise than its head bbbbbbbbbbbb onto cccccccccccc: out of date, nothing run (novox/hq ADR 0382) [gitea] novox/mesh-host's main moved from 444444444444 to 333333333333: 0 open pull request(s) into it put out of date, nothing run (novox/hq ADR 0323) [gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 was merged otherwise than its head bbbbbbbbbbbb onto cccccccccccc: out of date, nothing run (novox/hq ADR 0382) [gitea] novox/mesh-controller#346: its verdict was judged beside mesh-host#114 was merged otherwise than its head dddddddddddd onto cccccccccccc: out of date, nothing run (novox/hq ADR 0382) ✔ both statuses name the siblings the verdict read, keeping the verdict word and the start of its reason within 140 characters (2.57958ms) ✔ a verdict that could not learn its siblings says so on the status and in the comment, and names none (0.449465ms) ✔ a verdict without siblings is said exactly as before (an older controller) (0.890881ms) ✔ the siblings a verdict names are kept per member, replaced by its next verdict, and removed by one that read none (1.095823ms) ✔ a sibling's new head puts both statuses of the member back to pending, with the reason, and runs nothing (2.334867ms) ✔ a sibling closed unmerged puts the member's verdict out of date (0.539517ms) ✔ a move of the sibling's base puts it out of date, naming both commits (0.564197ms) ✔ the sibling's own merge of the head read onto the base read does not, in either order of the two merges (0.678228ms) ✔ a merge of another head, or onto another base, is a move (0.916781ms) ✔ only the members whose verdict names the sibling are touched, and a member that moved on is dropped (0.83436ms) ✔ a trunk that moved tells the siblings' weighing; one first seen does not (0.855399ms) ✔ the group rule names every missing thing: the group status at each head read, and each head the Approve does not cover (1.511877ms) ✔ a merged or closed member's entry is dropped, so a sibling's later push never re-pends its merged head (0.281343ms) ✔ without the composed verdict's siblings, a sibling's own merge of its new head is a move (the pin of issue 1049) (0.302704ms) ✔ a composed verdict names the siblings of each member at the heads and base commits it composed, so a sibling's own merge of its new head is no move (issue 1049) (0.953781ms) ✔ a composed verdict keeps nothing for a member it cannot name, and a group of one is none (issue 1049) (0.366184ms) ✔ a consumer that asks nothing, or write, publishes: the package team (1.605518ms) ✔ a consumer that asks to read joins the readers, who write no package (0.450796ms) ✔ a reader is made, put on the readers team, and taken off the package team (0.556437ms) ✔ a publisher is made and put on the package team, as before (0.230393ms) ✔ first start: mints with the admin account, keeps the token at 0600, asks for the tools' scopes only (34.694197ms) ✔ second start: reuses the kept token, mints nothing (33.096439ms) ✔ the forge rejects the kept token (its data was restored): minted afresh, once, and the call goes through (33.2445ms) ✔ a token kept with write:admin by an earlier build is minted again without it at the next start, and the forge drops the old one (29.436307ms) ✔ a kept token lacking a scope the tools need: the forge refuses the call for the scope, the token is re-minted with the whole list, and the call goes through (27.423034ms) ✔ the kept file is gone but the forge still holds a token by that name: replaced, not refused (24.886155ms) ✔ concurrent first calls share one mint (13.754838ms) ✔ two tokens hold the name (two mints raced): both are deleted by their id, and one fresh token is minted (14.87958ms) ✔ two processes on one kept file, both without a token, mint once: the second waits for the first and reuses it (76.492424ms) ✔ a lock left by a process that died mid-mint is taken over, not waited on for ever (5.673905ms) ✔ the admin account is refused: said plainly, nothing kept, and the next call fails the same way rather than crashing (16.181035ms) ✔ one process shares one source per kept file — the watcher and the tools never renew against each other (0.992851ms) ✔ a second process finds the token the first renewed, and reuses it instead of minting over it (23.243616ms) ✔ a configured token wins, and is reported rather than minted over when the forge rejects it (2.378677ms) ✔ nothing to mint with and no token: the client says what is missing (0.199483ms) [gitea] no tools — no Gitea token, and nothing to mint one with — set MESH_GITEA_TOKEN, or MESH_GITEA_ADMIN_USER, MESH_GITEA_ADMIN_PASSWORD_FILE, MESH_GITEA_STATE_DIR [gitea] no token kept — minting one [gitea] the forge already holds a token named "mesh-tools" — replacing it [gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-6TnLo5/state/token ✔ the tools register once there is a way to a token, and the first call mints it (28.968731ms) [gitea] no token kept — minting one [gitea] the forge already holds a token named "mesh-tools" — replacing it [gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-RayOgM/state/token ✔ a pull request can be closed, read and cleaned up through the tools (37.825203ms) [gitea] no token kept — minting one [gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-k99DYi/state/token ✔ the tools' token is minted for an account of their own, which is no administrator and writes through its team (92.909213ms) [gitea] no token kept — minting one [gitea] the forge already holds a token named "mesh-tools" — replacing it [gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-dSBAMR/state/token ✔ with the tools' token, the forge writes a status and refuses a protection edit — the forge itself, not a guard (53.211049ms) [gitea] no token kept — minting one [gitea] the forge already holds a token named "mesh-tools" — replacing it [gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-i7C8kL/state/token ✔ what a base's protection asks is read from the branch, which the tools' account may read, not from the rules' list it may not (47.347481ms) [gitea] the kept token was minted with other scopes than the tools take now — minting one with them [gitea] the forge already holds a token named "mesh-tools" — replacing it [gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-4RAz73/state/token [gitea] deleted 1 token(s) named "mesh-tools" the admin account "mesh-admin" held: the tools act as "mesh-tools" now ✔ the administrator's token from before goes: a kept admin token is minted again for the tools' account, and the forge drops the old one (44.869993ms) [gitea] no token kept — minting one [gitea] the forge already holds a token named "mesh-tools" — replacing it [gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-NQ2ArS/state/token ✔ a tools' account someone made an administrator is made a plain account again at the next mint (35.337255ms) ✔ the tools never act as the administrator: MESH_GITEA_TOOLS_USER naming it is refused (2.305897ms) ✔ the manifest hands the tools their account, and the Go forge bundle holds no administrator password (0.780499ms) [gitea] no token kept — minting one [gitea] the forge already holds a token named "mesh-tools" — replacing it [gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-Y9ZdP3/state/token ✔ a repository check said as a warning on a head without merge-check.sh reads the base's protection from the branch (35.968711ms) [gitea] no token kept — minting one ✔ a mint that fails leaves the administrator's old token in place: the tools are never left without one (29.086033ms) [gitea] no token kept — minting one [gitea] the forge already holds a token named "mesh-tools" — replacing it [gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-9UAeUy/state/token [gitea] FAILED to delete the token(s) named "mesh-tools" the admin account "mesh-admin" holds — tried again at the next start: Gitea DELETE /users/mesh-admin/tokens/902 (named mesh-tools): 500 {"message":"the forge is not well"} ✔ an old token that cannot be deleted after the mint is said, the new token kept, and deleted at the next start (44.088955ms) [gitea] no token kept — minting one [gitea] the forge already holds a token named "mesh-tools" — replacing it [gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-p4ebxm/state/token ✔ a team another process made between the look and the create is found, not a failure (38.47848ms) [gitea] no token kept — minting one [gitea] the forge already holds a token named "mesh-tools" — replacing it [gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-RraOAf/state/token ✔ setting the tools' account up puts main's rule right in every repository: no push, only the tools' account merges (issue 948) (38.671292ms) [gitea] no token kept — minting one [gitea] the forge already holds a token named "mesh-tools" — replacing it [gitea] minted a token for "mesh-tools" (write:repository, write:issue, read:user), kept at /tmp/gitea-tools-account-Pxbvz7/state/token ✔ a glob rule covering main keeps its statuses when main is given a rule of its own name (issue 948, review round 1) (34.295733ms) ✔ a start with the token kept still puts main's rules right: the module's start asks for it each time (issue 948, review round 1) (12.920848ms) [gitea] novox/mesh-host's main moved from a2c2c35bbbbb to d28ca95ccccc: 25 open pull request(s) into it put out of date, nothing run (novox/hq ADR 0323) [gitea] novox/mesh-host's main moved from d28ca95ccccc to ffffffffffff: 0 open pull request(s) into it put out of date, nothing run (novox/hq ADR 0323) [gitea] novox/mesh-host: whether a trunk moved could not be weighed, so it is weighed again on the next pass — the forge is away [gitea] novox/mesh-host's main moved from a2c2c35bbbbb to d28ca95ccccc: 0 open pull request(s) into it put out of date, nothing run (novox/hq ADR 0323) [gitea] novox/mesh-controller's feat/57-config-and-provisioning moved from eeeeeeeeeeee to d28ca95ccccc: 1 open pull request(s) into it put out of date, nothing run (novox/hq ADR 0323) ✔ both statuses say the head and the trunk commit the verdict judged, first, whatever the summary's length (2.62182ms) ✔ a trunk's move puts an open head's merge check out of date, naming both commits, unless a check is on its way (1.467147ms) ✔ a push to a trunk puts every open pull request into it out of date — twenty-five of them — and none into another (5.719186ms) ✔ a trunk that cannot be read is weighed again on the next pass, never recorded half (0.455356ms) ✔ the trunk's move takes its turn after a verdict in flight, and weighs what the forge holds then (0.580897ms) ✔ a verdict judged against a trunk newer than the pass's first read is not put out of date (0.308224ms) ✔ a verdict that landed out of date keeps its account on the pull request (0.442275ms) ✔ a release branch's move puts every open pull request into it out of date, as a trunk's does (ADR 0358 §5) (0.520996ms) ✔ a signed event is published on the bus and acted on once (68.712235ms) ✔ an unsigned event, or one whose signature does not verify, is refused and published nowhere (41.90931ms) ✔ an event and the poll seeing the same head announce it once (0.399824ms) ✔ each forge event is named in the module's stream and trimmed (0.578736ms) ✔ the webhook is made a system webhook, which the forge sends every repository's events to (1.215464ms) ✔ default webhooks left at the receiver by an earlier start are replaced by one system webhook (1.092102ms) ✔ a repository's copy of a default webhook at the receiver is deleted, on every page, and said (3.789253ms) ✔ a forge that makes no system webhook is said, never taken as heard (0.711778ms) ✔ the receiver tells what it verified and what it refused (10.990496ms) ✔ a forge that never delivers is said loudly once, and unhealthy, when the poll finds what no event said (1.163493ms) ✔ a forge whose events stop after one delivery is said loudly once per silent spell, and refusals are unhealthy (0.424005ms) ✔ without a receiver by configuration the polls alone watch, healthy; a receiver that failed is unhealthy (0.381334ms) ✔ the polls look every 30 s until events are heard, every five minutes while they are, and 30 s again on a miss (0.203073ms) ✔ a pull request's edit event carries its description, and no other pull request event does (issue 1079) (0.216412ms) ℹ tests 163 ℹ suites 0 ℹ pass 163 ℹ fail 0 ℹ cancelled 0 ℹ skipped 0 ℹ todo 0 ℹ duration_ms 934.939906 ```

mesh-tools merged commit f0c8958dd2 into main 2026-10-21 10:08:49 +00:00

mesh-tools deleted branch fix/1604-patch-applied 2026-10-21 10:08:49 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#407