mesh-build-go: a failed test keeps its last lines and its cause, not its first fifteen (issue 1901, with mesh-delivery) #466

Merged
jschoubben merged 3 commits from fix/1901-rebased into main 2026-10-23 22:35:57 +00:00
Member

Fixes issue 1901 with mesh-delivery#fix/1901-rebased (one delivery group): a failed test's verdict kept only its first ~120 characters, usually a log line, so the line saying why it failed was lost (met three times on 2026-10-23).

  • levels.go: clip keeps a failed test's last lines up to 4096 bytes; Failure.Cause is the first go test -json OutputType "error" line (the t.Fatal/t.Error line). When lines are dropped, the Cause (or the first real line) leads, ahead of the '... (N earlier lines)' marker, so an older checker reading only the first line still gets a real one.

Tests: 1901/AC1, 1901/AC3 (failure_words_test.go). try-1792787192125039195 passed (unit 4424, integration 4465, 0 failed).

Moves mesh-build-go (g14, novox, shanks).

Reviewed-by: review-fixes@shanks at dcae699323
Pushed-by: fix-1901@shanks

Fixes issue 1901 with mesh-delivery#fix/1901-rebased (one delivery group): a failed test's verdict kept only its first ~120 characters, usually a log line, so the line saying why it failed was lost (met three times on 2026-10-23). - levels.go: `clip` keeps a failed test's last lines up to 4096 bytes; `Failure.Cause` is the first go test -json OutputType "error" line (the t.Fatal/t.Error line). When lines are dropped, the Cause (or the first real line) leads, ahead of the '... (N earlier lines)' marker, so an older checker reading only the first line still gets a real one. Tests: 1901/AC1, 1901/AC3 (failure_words_test.go). try-1792787192125039195 passed (unit 4424, integration 4465, 0 failed). Moves mesh-build-go (g14, novox, shanks). Reviewed-by: review-fixes@shanks at dcae699323c8bda7d648a2e1303afaa4f6e19913 Pushed-by: fix-1901@shanks
mesh-tools added 3 commits 2026-10-23 21:30:15 +00:00
mesh-build-go: a clipped failure starts with its cause, not the marker, for an older checker (issue 1901/AC3)
mesh/delivery covered: a later merge that contains it was delivered: novox/mesh-catalog@753e8fc202c3 (merged as 4b1bed4b into main, walk plan-17927949853…
mesh/delivery-group group fix/1901-rebased delivered: every member is delivered
mesh/check checking dcae699323c8 on 25d69406b740 | novox/mesh-catalog#466 in group fix/1901-rebased
dcae699323
Author
Member

Delivery novox/mesh-catalog@dcae699323c8 — covered since 2026-10-23T23:09:07Z

Delivery plan — builds mesh-build-go → g14, novox, shanks; no bus step

  • tier 0: mesh-build-go
  • g14: receives mesh-build-go
  • novox: receives mesh-build-go
  • shanks: receives mesh-build-go
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before mesh-build-go is judged on its first machine

Group fix/1901-rebased: novox/mesh-catalog@dcae699323, novox/mesh-delivery@a697ee86d4

Machines

  • mesh-build-go on every machine running it: sent
  • mesh-delivery-checker on every machine running it: sent
  • mesh-mail-reader on every machine running it: sent

Transitions

  • 2026-10-23 21:30 (new) → proposed (announced): novox/mesh-catalog#466's head announced
  • 2026-10-23 22:36 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides that it goes on
  • 2026-10-23 22:36 held → delivering (release): the operator's hand merge at 00:35, which by the operator's word of 2026-10-24 00:24 releases it (build, publish, deliver until the new setup works); reviewed at its head
  • 2026-10-23 23:09 delivering → covered (covered): covered: a later merge that contains it was delivered: novox/mesh-catalog@753e8fc202 (merged as 4b1bed4b into main, walk plan-1792794985391468127)

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@dcae699323c8` — **covered** since 2026-10-23T23:09:07Z **Delivery plan** — builds mesh-build-go → g14, novox, shanks; no bus step - tier 0: mesh-build-go - g14: receives mesh-build-go - novox: receives mesh-build-go - shanks: receives mesh-build-go - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before mesh-build-go is judged on its first machine **Group** `fix/1901-rebased`: novox/mesh-catalog@dcae699323c8, novox/mesh-delivery@a697ee86d4af **Machines** - mesh-build-go on every machine running it: sent - mesh-delivery-checker on every machine running it: sent - mesh-mail-reader on every machine running it: sent **Transitions** - 2026-10-23 21:30 (new) → proposed (announced): novox/mesh-catalog#466's head announced - 2026-10-23 22:36 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides that it goes on - 2026-10-23 22:36 held → delivering (release): the operator's hand merge at 00:35, which by the operator's word of 2026-10-24 00:24 releases it (build, publish, deliver until the new setup works); reviewed at its head - 2026-10-23 23:09 delivering → covered (covered): covered: a later merge that contains it was delivered: novox/mesh-catalog@753e8fc202c3 (merged as 4b1bed4b into main, walk plan-1792794985391468127) The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
jschoubben merged commit 25d69406b7 into main 2026-10-23 22:35:57 +00:00
jschoubben deleted branch fix/1901-rebased 2026-10-23 22:35:58 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#466