mesh-build-node tests: never install a toolchain from the registry in the integration level; skip as NOT RUN when none is installed (issue 890) #491

Merged
mesh-tools merged 1 commits from fix/build-node-tests-offline into main 2026-10-26 11:34:17 +00:00
Member

Issue 890 (note 17): five mesh-catalog checks since 00:07 (among them #489's) failed in five mesh-build-node integration tests: realMachine (build_integration_test.go) found no Node toolchain to copy on ace (no Node build module there, only a leftover 0700 cache) and fell back to npm ci from the registry, which the integration level's shut-off network refuses after ~70 s.

Now realMachine skips with 'NOT RUN: no Node toolchain is installed under ... for this account to read; the integration level has no network to install one' when none is readable, and the tests' Registry func returns an error so a test can never reach a registry. Three tests that shared one fixture are one (TestTheFixturePassesTheUnitLevelAndBuildsTwiceToOneDigest): the module goes from 10 integration tests to 8, keeping each claim. Only the test file changes.

Try try-1793012801696900288 passed (g14, shanks). Reviewed (review-nodetc@shanks). Known gap, in the checker, not here (noted on issue 890, fix started): a check placed on ace skips these and its passing verdict is kept.

Reviewed-by: review-nodetc@shanks at a01715ddf5

Issue 890 (note 17): five mesh-catalog checks since 00:07 (among them #489's) failed in five mesh-build-node integration tests: realMachine (build_integration_test.go) found no Node toolchain to copy on ace (no Node build module there, only a leftover 0700 cache) and fell back to `npm ci` from the registry, which the integration level's shut-off network refuses after ~70 s. Now realMachine skips with 'NOT RUN: no Node toolchain is installed under ... for this account to read; the integration level has no network to install one' when none is readable, and the tests' Registry func returns an error so a test can never reach a registry. Three tests that shared one fixture are one (TestTheFixturePassesTheUnitLevelAndBuildsTwiceToOneDigest): the module goes from 10 integration tests to 8, keeping each claim. Only the test file changes. Try try-1793012801696900288 passed (g14, shanks). Reviewed (review-nodetc@shanks). Known gap, in the checker, not here (noted on issue 890, fix started): a check placed on ace skips these and its passing verdict is kept. Reviewed-by: review-nodetc@shanks at a01715ddf508daa4ae171e4e9816ef3eeb5bb013
mesh-tools added 1 commit 2026-10-26 11:23:05 +00:00
On ace, which holds no Node build module, five integration tests each spent 70 s in npm's network retries and failed every mesh-catalog check run there (five verdicts since 00:07). The tests now copy the node's installed toolchain or are skipped as NOT RUN; the registry is never reached. Three tests sharing the fixture are one, so the toolchain is copied three times instead of five (10 integration tests in the module, now 8).
Author
Member

Delivery novox/mesh-catalog@a01715ddf508 — merged since 2026-10-26T11:34:19Z

Source — source.main moved to novox/mesh-catalog@f96704fa0f. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

  • 2026-10-26 11:23 (new) → proposed (announced): novox/mesh-catalog#491's head announced
  • 2026-10-26 11:23 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-26 11:34 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@a01715ddf508` — **merged** since 2026-10-26T11:34:19Z **Source** — source.main moved to novox/mesh-catalog@f96704fa0ff4. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-26 11:23 (new) → proposed (announced): novox/mesh-catalog#491's head announced - 2026-10-26 11:23 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 11:34 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit f96704fa0f into main 2026-10-26 11:34:17 +00:00
mesh-tools deleted branch fix/build-node-tests-offline 2026-10-26 11:34:17 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#491