mesh-build-go's compose integration test gives its module one slot (issue 1126) #553

2026-10-28T18:45:48Z

mesh-tools commented

2026-10-28 18:45:48 +00:00

The cause: with capacity's new default 0 (ADR 0567 §15) the compose integration test's module had no slot and took no ask, so every catalogue check failed on TestAComposeAskIsBuiltOnceAndAnsweredOnTheBus. The fix gives the test its own slot of 1. A blocking fault for every catalogue change (issue 1126).

Tree identical to daf57cd2 (approved by rev-l2); re-pushed with the operator's yes because the checker lost its check.

Reviewed-by: rev-l2@shanks at 1e377fe862

The cause: with capacity's new default 0 (ADR 0567 §15) the compose integration test's module had no slot and took no ask, so every catalogue check failed on TestAComposeAskIsBuiltOnceAndAnsweredOnTheBus. The fix gives the test its own slot of 1. A blocking fault for every catalogue change (issue 1126). Tree identical to daf57cd2 (approved by rev-l2); re-pushed with the operator's yes because the checker lost its check. Reviewed-by: rev-l2@shanks at 1e377fe8628ca6f0dbd7667d75924c6fe4ffecae

mesh-tools commented

2026-10-28 18:45:51 +00:00

Delivery novox/mesh-catalog@1e377fe8628c — merged since 2026-10-28T20:24:51Z

Source — source.main moved to novox/mesh-catalog@39ce149f74. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-10-28 19:23 (new) → proposed (announced): novox/mesh-catalog#553's head announced
2026-10-28 19:23 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-28 20:24 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-catalog@1e377fe8628c` — **merged** since 2026-10-28T20:24:51Z **Source** — source.main moved to novox/mesh-catalog@39ce149f7435. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-28 19:23 (new) → proposed (announced): novox/mesh-catalog#553's head announced - 2026-10-28 19:23 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-28 20:24 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

jschoubben added 1 commit 2026-10-28 19:23:44 +00:00

Go build module: the compose test gives its module a slot, since a node with no capacity set now pulls nothing (issue 1126, ADR 0567 §15)

mesh/delivery merged: source.main moved to novox/mesh-catalog@39ce149f7435

Details

mesh/check checking 1e377fe8628c on 39ce149f7435

1e377fe862

The test built its module with no settings file and no Capacity; the new
buildstep.NodeCapacity answers 0 for that (no default names a node), so the
puller took no ask and the test timed out after 90 s in check 205f634c30df.
Failed first locally at origin/main af89893d (90.1 s), passes with the slot (2.5 s).

jschoubben force-pushed fix/1126-capacity-transition from daf57cd2a7 to 1e377fe862

2026-10-28 19:23:44 +00:00

Compare

mesh-tools merged commit 39ce149f74 into main

2026-10-28 20:24:49 +00:00

mesh-tools deleted branch fix/1126-capacity-transition

2026-10-28 20:24:49 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#553