The provisioner client accepts credential form none through the mesh-sdk list (issue 774) #564

Merged
jschoubben merged 1 commits from fix/credential-forms-one-list into main 2026-10-30 15:10:29 +00:00
Member

Recovery of design 47's release (issue 774). Group fix/credential-forms-one-list: mesh-sdk, mesh-catalog; merge mesh-sdk first.

Fault (live since 2026-10-30 13:55): the release catalogue declares credential form "none"; mesh-provisioner-client kept its own list of forms without it, so it refused whole plans on g14 and shanks (mesh-build-go, mesh-build-node, mesh-build-image and ssh-client files not placed). Second meeting of this kind: mesh-controller #483 fixed only the controller's own copy.

Quick fix: add "none" to the client's list. Thorough fix (chosen): one list in mesh-sdk (catalogue.CredentialForms / IsCredentialForm; provisions.Form* alias it); the client uses it; a none credential places no file and a secret named against one fails loudly. The other copies (mesh-vault pair.go, mesh-controller provisioning.go) already include none and are queued for after the release. Recovery mode: no check waited on; the operator merges by hand.

Reviewed-by: rev-forms@shanks at 67dcf252ec

Recovery of design 47's release (issue 774). Group fix/credential-forms-one-list: mesh-sdk, mesh-catalog; merge mesh-sdk first. Fault (live since 2026-10-30 13:55): the release catalogue declares credential form "none"; mesh-provisioner-client kept its own list of forms without it, so it refused whole plans on g14 and shanks (mesh-build-go, mesh-build-node, mesh-build-image and ssh-client files not placed). Second meeting of this kind: mesh-controller #483 fixed only the controller's own copy. Quick fix: add "none" to the client's list. Thorough fix (chosen): one list in mesh-sdk (catalogue.CredentialForms / IsCredentialForm; provisions.Form* alias it); the client uses it; a none credential places no file and a secret named against one fails loudly. The other copies (mesh-vault pair.go, mesh-controller provisioning.go) already include none and are queued for after the release. Recovery mode: no check waited on; the operator merges by hand. Reviewed-by: rev-forms@shanks at 67dcf252ecfad43f476d9bcf5195534324e90db8
mesh-tools added 1 commit 2026-10-30 15:09:52 +00:00
Check a plan's credential form against mesh-sdk's one list, so the client takes plans naming none again (issue 774)
mesh/check checking 67dcf252ecfa on 82ac613b4ed0 | novox/mesh-catalog#564 in group fix/credential-forms-one-list
mesh/delivery merged: source.main moved to novox/mesh-catalog@72cee59acc32
mesh/delivery-group group fix/credential-forms-one-list merged: every member is merged
67dcf252ec
Since 13:55 the client refused every plan with credential-form none
(gitea's forge-account, the artifact store), and g14 and shanks placed no
files for mesh-build-go, mesh-build-node, mesh-build-image or ssh-client.
Second meeting of the credential-form list kind: the controller's copy was
fixed alone before. Thorough: one list in mesh-sdk; this client drops its
copy and pins mesh-sdk 9379e9a. A none entry is never a holder's issued
value: its bound values come from the provider's entry, and a secret named
for it fails loudly instead of waiting on a vault that mints nothing.
Author
Member

Delivery novox/mesh-catalog@67dcf252ecfa — merged since 2026-10-30T15:10:31Z

Source — source.main moved to novox/mesh-catalog@72cee59acc. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/credential-forms-one-list: novox/mesh-catalog@67dcf252ec, novox/mesh-sdk@9379e9a96a

Transitions

  • 2026-10-30 15:09 (new) → proposed (announced): novox/mesh-catalog#564's head announced
  • 2026-10-30 15:09 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-30 15:10 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@67dcf252ecfa` — **merged** since 2026-10-30T15:10:31Z **Source** — source.main moved to novox/mesh-catalog@72cee59acc32. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/credential-forms-one-list`: novox/mesh-catalog@67dcf252ecfa, novox/mesh-sdk@9379e9a96ad4 **Transitions** - 2026-10-30 15:09 (new) → proposed (announced): novox/mesh-catalog#564's head announced - 2026-10-30 15:09 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-30 15:10 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
jschoubben merged commit 72cee59acc into main 2026-10-30 15:10:29 +00:00
jschoubben deleted branch fix/credential-forms-one-list 2026-10-30 15:10:29 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#564