Revert power's bar item attributes, which every node-engine refuses, so machines compose again (issue 774) #566

Merged
jschoubben merged 1 commits from fix/power-item-attributes into main 2026-10-30 18:16:16 +00:00
Member

Blocking fault after #565: every node-engine refuses power's bar item ("power's item 2: contribution:node-bar:block is placed by bar, place, and "shows" is none of them"), so no machine composes any module: 32 of 81 modules on shanks show failed (they keep running what they ran; no update lands). This reverts ca8d6f33 alone (the attributes and their test). i3status-rust's power.draw stays unissued as before #565.

Quick fix (this): revert. Thorough fix (follows, issue 774): the catalogue check must judge items against their collection's placement attributes as the node-engine does, and the node-engine must hold one bad module instead of failing the whole node (the kind fixed for the provisioner in mesh-sdk 59311407).

Rule bent: no independent review for a one-commit revert of reviewed code; covered by the module's tests (go vet, go test pass) and the live re-read after delivery.

Blocking fault after #565: every node-engine refuses power's bar item ("power's item 2: contribution:node-bar:block is placed by bar, place, and \"shows\" is none of them"), so no machine composes any module: 32 of 81 modules on shanks show failed (they keep running what they ran; no update lands). This reverts ca8d6f33 alone (the attributes and their test). i3status-rust's power.draw stays unissued as before #565. Quick fix (this): revert. Thorough fix (follows, issue 774): the catalogue check must judge items against their collection's placement attributes as the node-engine does, and the node-engine must hold one bad module instead of failing the whole node (the kind fixed for the provisioner in mesh-sdk 59311407). Rule bent: no independent review for a one-commit revert of reviewed code; covered by the module's tests (go vet, go test pass) and the live re-read after delivery.
mesh-tools added 1 commit 2026-10-30 18:16:05 +00:00
Author
Member

Delivery novox/mesh-catalog@eb1cf1bb44e7 — merged since 2026-10-30T18:16:18Z

Source — source.main moved to novox/mesh-catalog@0695ae25db. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

  • 2026-10-30 18:16 (new) → proposed (announced): novox/mesh-catalog#566's head announced
  • 2026-10-30 18:16 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-30 18:16 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@eb1cf1bb44e7` — **merged** since 2026-10-30T18:16:18Z **Source** — source.main moved to novox/mesh-catalog@0695ae25dbd2. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-30 18:16 (new) → proposed (announced): novox/mesh-catalog#566's head announced - 2026-10-30 18:16 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-30 18:16 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
jschoubben merged commit 0695ae25db into main 2026-10-30 18:16:16 +00:00
jschoubben deleted branch fix/power-item-attributes 2026-10-30 18:16:16 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#566