A catalogue check parses every manifest as the nodes do; mesh-provisioner holds a refused manifest alone (issue 774) #567

Merged
jschoubben merged 2 commits from fix/one-bad-item-holds-one-module into main 2026-10-30 18:31:02 +00:00
Member

New checks/manifests: every modules/*/module.json through ParseManifestWith (predefined.json, templates), then CatalogueProblems, IdentityProblems and DataProblems over the shelf: the functions the nodes run. It refuses ca8d6f33's power item and passes on main. No catalogue check parsed a manifest since the controller's module check left the merge gate. mesh-provisioner pinned to mesh-sdk 754edfa.

Wait for this pull request's mesh/check to pass before merging: today's #565 merged with its check pending and the composition never run, which let the bar item fault reach every machine.
Merge order: mesh-sdk first, then mesh-host and mesh-catalog (they pin mesh-sdk 754edfa).

Reviewed-by: rev-sweep@shanks at b4b22aac20

New checks/manifests: every modules/*/module.json through ParseManifestWith (predefined.json, templates), then CatalogueProblems, IdentityProblems and DataProblems over the shelf: the functions the nodes run. It refuses ca8d6f33's power item and passes on main. No catalogue check parsed a manifest since the controller's module check left the merge gate. mesh-provisioner pinned to mesh-sdk 754edfa. Wait for this pull request's mesh/check to pass before merging: today's #565 merged with its check pending and the composition never run, which let the bar item fault reach every machine. Merge order: mesh-sdk first, then mesh-host and mesh-catalog (they pin mesh-sdk 754edfa). Reviewed-by: rev-sweep@shanks at b4b22aac20609f897813f7cc396cf93c58074a92
mesh-tools added 2 commits 2026-10-30 18:30:26 +00:00
ca8d6f33 gave power's bar item attributes its bar places by none of; ParseManifest refuses that, and at 19:13 on
2026-10-30 every node-engine refused to compose. No check of #565 parsed the manifest: that judgement was
mesh-controller's `module check`, run over every manifest by the old merge gate, and since the checker moved to
mesh-delivery it runs this repository's Go tests and the composition, where no test parsed a manifest whole.

Quick fix: a row refusing node-bar block attributes other than bar, place and order. Thorough fix: checks/manifests
parses every modules/*/module.json with mesh-sdk's ParseManifestWith against predefined.json and its templates beside
it, then CatalogueProblems, IdentityProblems and DataProblems over the shelf, the functions the nodes and registration
use. Chose thorough: it refuses every kind of manifest the nodes refuse, not this attribute alone. It fails at
7e905a66 naming power's item 2 and passes at 0695ae25.
Pin mesh-provisioner to mesh-sdk 754edfae, so a manifest the mesh refuses holds that module alone in its plans (issue 774)
mesh/check checking b4b22aac2060 on 0695ae25dbd2 | novox/mesh-catalog#567 in group fix/one-bad-item-holds-one-module
mesh/delivery merged: source.main moved to novox/mesh-catalog@395a37dddab9
mesh/delivery-group group fix/one-bad-item-holds-one-module merged: every member is merged
b4b22aac20
PlansHeld reads the same frombus input that refused every node on 2026-10-30 at 19:13; at 754edfae it holds the
module whose manifest the mesh refuses, with why, and composes every other module's plan. Quick and thorough fix are
the SDK's (one rule in frombus input); this is the pin.
Author
Member

Delivery novox/mesh-catalog@b4b22aac2060 — merged since 2026-10-30T18:31:07Z

Source — source.main moved to novox/mesh-catalog@395a37ddda. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/one-bad-item-holds-one-module: novox/mesh-catalog@b4b22aac20, novox/mesh-host@4055e0094b, novox/mesh-sdk@754edfae69

Transitions

  • 2026-10-30 18:30 (new) → proposed (announced): novox/mesh-catalog#567's head announced
  • 2026-10-30 18:30 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-30 18:31 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@b4b22aac2060` — **merged** since 2026-10-30T18:31:07Z **Source** — source.main moved to novox/mesh-catalog@395a37dddab9. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/one-bad-item-holds-one-module`: novox/mesh-catalog@b4b22aac2060, novox/mesh-host@4055e0094b48, novox/mesh-sdk@754edfae6924 **Transitions** - 2026-10-30 18:30 (new) → proposed (announced): novox/mesh-catalog#567's head announced - 2026-10-30 18:30 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-30 18:31 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
jschoubben merged commit 395a37ddda into main 2026-10-30 18:31:02 +00:00
jschoubben deleted branch fix/one-bad-item-holds-one-module 2026-10-30 18:31:02 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#567