The provisioner client takes a plan with no templates as nothing to fill (issue 774) #569

Closed
mesh-tools wants to merge 0 commits from fix/client-takes-plans-without-templates into main
Member

The provisioner client takes a plan with no templates archive as nothing to fill, instead of fetching an empty source and failing the module's report. It must reach every node before the one-rule-for-provisions provisioner, which writes route-only plans for modules not yet moved (about 23, grafana among them). Safe alone: no such plan exists before then. TestAPlanOfProvisionsAloneFetchesNoTemplates fails without it. Issue 774, L6 (1954).

Reviewed-by: rev-sweep@shanks at 0736b5c08a2c61745486e37767194603561487aa (the same change, split onto its own branch at 7522961ae3). The lead merges once mesh/check is green.

The provisioner client takes a plan with no templates archive as nothing to fill, instead of fetching an empty source and failing the module's report. It must reach every node before the one-rule-for-provisions provisioner, which writes route-only plans for modules not yet moved (about 23, grafana among them). Safe alone: no such plan exists before then. TestAPlanOfProvisionsAloneFetchesNoTemplates fails without it. Issue 774, L6 (1954). Reviewed-by: rev-sweep@shanks at 0736b5c08a2c61745486e37767194603561487aa (the same change, split onto its own branch at 7522961ae3b0cb4477afb876758d119655ced05d). The lead merges once mesh/check is green.
mesh-tools added 1 commit 2026-10-30 20:42:35 +00:00
Let a plan of provisions alone fill nothing, so a module not handed can have one for its route (issue 774)
mesh/delivery merged: source.main moved to novox/mesh-catalog@cb91a4b9c292
mesh/check being carried to 7522961ae3b0 on cb91a4b9c292 | from 5d9cead336ab
7522961ae3
A plan with no templates archive made the client fetch an empty source and fail the module's report. The next
mesh-provisioner composes such plans (a module not handed gets one for what a provider's helper answers, its route), so
this reaches the nodes first.

Quick fix: none (a failed report per routed module). Thorough fix (chosen): a plan with no archive is read as provisions
alone by the one client every node runs.
Author
Member

Delivery novox/mesh-catalog@7522961ae3b0 — closed since 2026-10-30T20:51:22Z

Transitions

  • 2026-10-30 20:42 (new) → proposed (announced): novox/mesh-catalog#569's head announced
  • 2026-10-30 20:42 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-30 20:51 ready → closed (closed): the pull request closed unmerged

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@7522961ae3b0` — **closed** since 2026-10-30T20:51:22Z **Transitions** - 2026-10-30 20:42 (new) → proposed (announced): novox/mesh-catalog#569's head announced - 2026-10-30 20:42 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-30 20:51 ready → closed (closed): the pull request closed unmerged The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools closed this pull request 2026-10-30 20:51:20 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#569