cpu_top's process view cuts a rewritten title at its first space, so no argument reaches the answer #601

2026-11-03T07:47:18Z

mesh-tools commented

2026-11-03 07:47:18 +00:00

Under issue 741 (note 8). Found in the first live call after mesh-catalog #600's delivery: firefox's content processes rewrite their title, so argv[0] holds the whole command line joined by spaces, and cpu_top's unit view answered their arguments ('-prefsHandle 0:56913 ...'), breaking its rule of never carrying arguments, which may hold a secret. commandLine now cuts argv[0] at the first space or tab after the NUL cut. A row of TestCPUTopRanksAUnitsProcesses ('/usr/bin/tool --password hunter2 -x' without NULs) fails without the cut. Kept for later (reviewer's hardening note): cut at any whitespace (unicode.IsSpace).

Reviewed-by: review-741@shanks at 3112692def

Under issue 741 (note 8). Found in the first live call after mesh-catalog #600's delivery: firefox's content processes rewrite their title, so argv[0] holds the whole command line joined by spaces, and cpu_top's unit view answered their arguments ('-prefsHandle 0:56913 ...'), breaking its rule of never carrying arguments, which may hold a secret. commandLine now cuts argv[0] at the first space or tab after the NUL cut. A row of TestCPUTopRanksAUnitsProcesses ('/usr/bin/tool --password hunter2 -x' without NULs) fails without the cut. Kept for later (reviewer's hardening note): cut at any whitespace (unicode.IsSpace). Reviewed-by: review-741@shanks at 3112692defdf4f9289e9599ac5604d26dd2d93f1

mesh-tools added 1 commit 2026-11-03 07:47:18 +00:00

cpu_top cuts argv[0] at the first space: a rewritten process title held a whole command line (issue 741)

mesh/check being carried to 3112692defdf on 1d1d5ec443d0 | from 4915ff5d293f

mesh/delivery merged: source.main moved to novox/mesh-catalog@1d1d5ec443d0

Details

3112692def

mesh-tools commented

2026-11-03 07:47:20 +00:00

Delivery novox/mesh-catalog@3112692defdf — merged since 2026-11-03T07:59:20Z

Source — source.main moved to novox/mesh-catalog@1d1d5ec443. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-11-03 07:47 (new) → proposed (announced): novox/mesh-catalog#601's head announced
2026-11-03 07:47 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-03 07:59 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-catalog@3112692defdf` — **merged** since 2026-11-03T07:59:20Z **Source** — source.main moved to novox/mesh-catalog@1d1d5ec443d0. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-11-03 07:47 (new) → proposed (announced): novox/mesh-catalog#601's head announced - 2026-11-03 07:47 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-03 07:59 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 1d1d5ec443 into main

2026-11-03 07:59:18 +00:00

mesh-tools deleted branch fix/741-argv0-title

2026-11-03 07:59:18 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#601