knowledge-base get shows the findings of the pending version's reviews (issue 1970) #620

2026-11-06T14:44:16Z

mesh-tools commented

2026-11-06 14:44:16 +00:00

Issue 1970 (a review that asks changes on a pending version could not be read; met twice on 2026-11-06, research 081 v16 and research 085 v17).

knowledge-base.get without version now carries pending-reviews: the reviews of the version waiting over the served one, with their findings. Its pending line says the truth after a changes verdict (the version waits for its author's revision, its findings in pending-reviews), instead of pointing to history, which holds no findings. Under a tight bound, earlier pending reviews are cut and the cut is said. The tool's description and the README name the pending reviews.

Acceptance: 1970/AC1 and AC3 in TestAChangesVerdictLeavesTheServedVersionServedAndGraduatingNeedsABecameLink, AC2 in TestAnAcceptedRecordChangesOnlyByAnInsightReviewedLikeAProposal; AC4 is the live case after delivery. No new test function (112 unit, 1 integration). No manifest change. Unit suite green (21.4 s); gofmt, vet and vet -tags integration clean.

Quick fix (a pointer in pending to get with version) against thorough fix (the answer shows the findings and says the truth): thorough, same file and size, and it removes a false statement.

Goes alone, not in the registry milestone's group: that group waits for research 085, which this fault blocked (said to the operator 2026-11-06 15:3x).

Review notes for later, none a fault of this change: findings counted by newline in get and by len in history; AC1 could assert the pending version's number; AC3's hand-built reviews use version 9; a single review longer than the bound is never shortened (older than this change).

Reviewed-by: mesh-code-reviewer@shanks at ddb2ae9420
Pushed-by: fix-1965@shanks

https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i

Issue 1970 (a review that asks changes on a pending version could not be read; met twice on 2026-11-06, research 081 v16 and research 085 v17). `knowledge-base.get` without `version` now carries `pending-reviews`: the reviews of the version waiting over the served one, with their findings. Its `pending` line says the truth after a changes verdict (the version waits for its author's revision, its findings in `pending-reviews`), instead of pointing to `history`, which holds no findings. Under a tight bound, earlier pending reviews are cut and the cut is said. The tool's description and the README name the pending reviews. Acceptance: 1970/AC1 and AC3 in `TestAChangesVerdictLeavesTheServedVersionServedAndGraduatingNeedsABecameLink`, AC2 in `TestAnAcceptedRecordChangesOnlyByAnInsightReviewedLikeAProposal`; AC4 is the live case after delivery. No new test function (112 unit, 1 integration). No manifest change. Unit suite green (21.4 s); gofmt, vet and vet -tags integration clean. Quick fix (a pointer in `pending` to `get` with `version`) against thorough fix (the answer shows the findings and says the truth): thorough, same file and size, and it removes a false statement. Goes alone, not in the registry milestone's group: that group waits for research 085, which this fault blocked (said to the operator 2026-11-06 15:3x). Review notes for later, none a fault of this change: findings counted by newline in get and by len in history; AC1 could assert the pending version's number; AC3's hand-built reviews use version 9; a single review longer than the bound is never shortened (older than this change). Reviewed-by: mesh-code-reviewer@shanks at ddb2ae942030bbb46e24ec7b83d3ed49438d5ab5 Pushed-by: fix-1965@shanks https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i

mesh-tools added 1 commit 2026-11-06 14:44:16 +00:00

knowledge-base get shows the findings of the pending version's reviews (issue 1970)

mesh/check being carried to ddb2ae942030 on 1d07778c88dc | from 332d37311485

mesh/delivery merged: source.main moved to novox/mesh-catalog@1d07778c88dc

Details

ddb2ae9420

Claude-Session: https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i

mesh-tools commented

2026-11-06 14:44:21 +00:00

Delivery novox/mesh-catalog@ddb2ae942030 — merged since 2026-11-06T15:24:38Z

Source — source.main moved to novox/mesh-catalog@1d07778c88. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-11-06 14:44 (new) → proposed (announced): novox/mesh-catalog#620's head announced
2026-11-06 14:44 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-06 15:24 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-catalog@ddb2ae942030` — **merged** since 2026-11-06T15:24:38Z **Source** — source.main moved to novox/mesh-catalog@1d07778c88dc. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-11-06 14:44 (new) → proposed (announced): novox/mesh-catalog#620's head announced - 2026-11-06 14:44 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-06 15:24 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 1d07778c88 into main

2026-11-06 15:24:38 +00:00

mesh-tools deleted branch fix/1970-pending-review-findings

2026-11-06 15:24:38 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#620