The gate asks the Approve at once while the check gates no merge, never waiting for a verdict (issue 1966) #629

Merged
jschoubben merged 1 commits from fix/1966-no-check-wait into main 2026-11-07 20:47:19 +00:00
Member

The operator, 2026-11-07: "we aren't running any checks anymore, we're delivering"; "disable the check". With check-gates-merge false (mesh-config) the gate still held the Approve for a verdict (verdictWaits). Now the Approve is asked once the delivery is reviewed and ready; a later verdict is shown and asks the pending Approve again in its words.

Checked locally: go vet and the gate's unit suite pass; tests updated to the new rule.

Merged by the session as a recovery fix under the approved instruction recovery-fixes-merge-and-tell; the operator is told on Telegram.

https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i

The operator, 2026-11-07: "we aren't running any checks anymore, we're delivering"; "disable the check". With check-gates-merge false (mesh-config) the gate still held the Approve for a verdict (verdictWaits). Now the Approve is asked once the delivery is reviewed and ready; a later verdict is shown and asks the pending Approve again in its words. Checked locally: go vet and the gate's unit suite pass; tests updated to the new rule. Merged by the session as a recovery fix under the approved instruction recovery-fixes-merge-and-tell; the operator is told on Telegram. https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i
mesh-tools added 1 commit 2026-11-07 20:46:45 +00:00
The gate asks the Approve at once while the check gates no merge, never waiting for a verdict (issue 1966)
mesh/delivery merged: source.main moved to novox/mesh-catalog@21aa11aef1af
mesh/check checking 145cf7e33afa on 21aa11aef1af
145cf7e33a
With check-gates-merge false (the configuration seat's value) the gate still held the Approve until the check had
a verdict (verdictWaits), so a one-line recovery waited half an hour for a whole-suite check it does not gate. The
operator, 2026-11-07: 'we aren't running any checks anymore, we're delivering'; 'disable the check'. The Approve is
now asked once the delivery is reviewed and ready; a later verdict is still shown and asks the pending Approve again
in its words. Tests follow: asked at once with no verdict or a running check, a group too, a re-pushed member too.

Merged by the session as a recovery fix (instruction recovery-fixes-merge-and-tell), the operator told on Telegram.

Claude-Session: https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i
Author
Member

Delivery novox/mesh-catalog@145cf7e33afa — merged since 2026-11-07T20:47:20Z

Source — source.main moved to novox/mesh-catalog@21aa11aef1. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

  • 2026-11-07 20:46 (new) → proposed (announced): novox/mesh-catalog#629's head announced
  • 2026-11-07 20:46 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-11-07 20:47 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@145cf7e33afa` — **merged** since 2026-11-07T20:47:20Z **Source** — source.main moved to novox/mesh-catalog@21aa11aef1af. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-11-07 20:46 (new) → proposed (announced): novox/mesh-catalog#629's head announced - 2026-11-07 20:46 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-07 20:47 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
jschoubben merged commit 21aa11aef1 into main 2026-11-07 20:47:19 +00:00
jschoubben deleted branch fix/1966-no-check-wait 2026-11-07 20:47:19 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#629