The resolver module's tests hold its configuration's guards #643

2026-11-09T20:02:28Z

mesh-tools commented

2026-11-09 20:02:28 +00:00

Issue 1966. The guards mesh-sdk's catalogue test held over this module's dnsmasq.conf move here: TestTheResolverConfigurationKeepsItsGuards (listen addresses, no-hosts, the two conf-files, bind-interfaces, never bind-dynamic, interface=, conf-dir, addn-hosts or 127.0.0.53-55); no-resolv and both server= lines were already held by TestUpstreamsAreConfigValues. Each guard removed fails the test (nine mutations). Pairs with mesh-sdk fix/1966-resolver-test, which deletes the old copy.

Reviewed-by: mesh-code-reviewer@shanks at a7dc4534d7

https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ

Issue 1966. The guards mesh-sdk's catalogue test held over this module's dnsmasq.conf move here: TestTheResolverConfigurationKeepsItsGuards (listen addresses, no-hosts, the two conf-files, bind-interfaces, never bind-dynamic, interface=, conf-dir, addn-hosts or 127.0.0.53-55); no-resolv and both server= lines were already held by TestUpstreamsAreConfigValues. Each guard removed fails the test (nine mutations). Pairs with mesh-sdk fix/1966-resolver-test, which deletes the old copy. Reviewed-by: mesh-code-reviewer@shanks at a7dc4534d73a06af6c7deccde5374dfb1bc240da https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ

mesh-tools added 1 commit 2026-11-09 20:02:28 +00:00

Hold the resolver's configuration guards in the dnsmasq module's tests (issue 1966)

mesh/check checking a7dc4534d73a on 6d2ce96630f0

mesh/delivery merged: source.main moved to novox/mesh-catalog@6d2ce96630f0

Details

mesh/delivery-group group fix/1966-resolver-test merged: every member is merged

Details

a7dc4534d7

Moved from mesh-sdk's catalogue tests, which read a literal the file no longer has.

Claude-Session: https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ

mesh-tools commented

2026-11-09 20:02:31 +00:00

Delivery novox/mesh-catalog@a7dc4534d73a — merged since 2026-11-09T20:09:36Z

Source — source.main moved to novox/mesh-catalog@6d2ce96630. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1966-resolver-test: novox/mesh-catalog@a7dc4534d7, novox/mesh-sdk@a330d7b0da

Transitions

2026-11-09 20:02 (new) → proposed (announced): novox/mesh-catalog#643's head announced
2026-11-09 20:02 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-09 20:09 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-catalog@a7dc4534d73a` — **merged** since 2026-11-09T20:09:36Z **Source** — source.main moved to novox/mesh-catalog@6d2ce96630f0. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1966-resolver-test`: novox/mesh-catalog@a7dc4534d73a, novox/mesh-sdk@a330d7b0da16 **Transitions** - 2026-11-09 20:02 (new) → proposed (announced): novox/mesh-catalog#643's head announced - 2026-11-09 20:02 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-09 20:09 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 6d2ce96630 into main

2026-11-09 20:09:35 +00:00

mesh-tools deleted branch fix/1966-resolver-test

2026-11-09 20:09:35 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#643