Review parts are asked one at a time: the node judges one at a time (issue 1966, quick fix) #651

Merged
mesh-tools merged 1 commits from fix/1966-kb-one-part into main 2026-11-10 07:33:49 +00:00
Member

The knowledge base asked two review parts at once (MostParallelParts = 2, ADR 0592 §22), but a node's agent judges one at a time (ADR 0278 §25), so the second part spent its whole bound (33-45 s) waiting and the review ended 'not reviewed'; met four times on 2026-11-10 (issue 1966 notes 156, 158). This asks one part at a time, within §22's 'at most two'. The test now asserts the literal 1, and fails without the change.

Quick fix, chosen first as recovery because the thorough fix (the bound counts only the run, a wait bound for the slot, tools to read and cancel queued judgements) needs a record of its own that must pass this same review; the thorough fix follows under issue 1966. Prepare: hq .work/1966-kb-judge-time/prepare.md.

Reviewed-by: mesh-code-reviewer (fix-1965@shanks's reviewer) at b7f78d47c5

https://claude.ai/code/session_01JG73KK8HD1gufnqyFxMFdW

The knowledge base asked two review parts at once (MostParallelParts = 2, ADR 0592 §22), but a node's agent judges one at a time (ADR 0278 §25), so the second part spent its whole bound (33-45 s) waiting and the review ended 'not reviewed'; met four times on 2026-11-10 (issue 1966 notes 156, 158). This asks one part at a time, within §22's 'at most two'. The test now asserts the literal 1, and fails without the change. Quick fix, chosen first as recovery because the thorough fix (the bound counts only the run, a `wait` bound for the slot, tools to read and cancel queued judgements) needs a record of its own that must pass this same review; the thorough fix follows under issue 1966. Prepare: hq .work/1966-kb-judge-time/prepare.md. Reviewed-by: mesh-code-reviewer (fix-1965@shanks's reviewer) at b7f78d47c5c4ee3f1eb915f044c544f2de2c58d5 https://claude.ai/code/session_01JG73KK8HD1gufnqyFxMFdW
mesh-tools added 1 commit 2026-11-10 02:04:43 +00:00
Review parts are asked one at a time: the node judges one at a time, a second ask only spent its bound waiting (issue 1966, quick fix)
mesh/check checking b7f78d47c5c4 on bfa4a0851acf
mesh/delivery merged: source.main moved to novox/mesh-catalog@bfa4a0851acf
b7f78d47c5
Claude-Session: https://claude.ai/code/session_01JG73KK8HD1gufnqyFxMFdW
Author
Member

Delivery novox/mesh-catalog@b7f78d47c5c4 — merged since 2026-11-10T07:33:51Z

Source — source.main moved to novox/mesh-catalog@bfa4a0851a. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

  • 2026-11-10 02:04 (new) → proposed (announced): novox/mesh-catalog#651's head announced
  • 2026-11-10 02:04 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-11-10 07:33 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@b7f78d47c5c4` — **merged** since 2026-11-10T07:33:51Z **Source** — source.main moved to novox/mesh-catalog@bfa4a0851acf. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-11-10 02:04 (new) → proposed (announced): novox/mesh-catalog#651's head announced - 2026-11-10 02:04 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-10 07:33 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit bfa4a0851a into main 2026-11-10 07:33:49 +00:00
mesh-tools deleted branch fix/1966-kb-one-part 2026-11-10 07:33:49 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#651