Play the config watch in the package seats' whole test, so the held callers list is proven (issue 1966) #652

2026-11-10T10:06:51Z

mesh-tools commented

2026-11-10 10:06:51 +00:00

Issue 1966 (trunk fault met while rebasing milestone G's branches). Since 24bf5921 (#646: distribution and the forge hold their caller list from its config watch, stdio.HoldVerbCallers), modules/gitea/cmd/package-registry TestThePackageSeatsWhole fails on main with "the config value callers cannot be read: not played here: mesh/provision.watch": the test's player answered only mesh/provision.get, so every check touching gitea fails.

What changes: one test file. The player answers mesh/provision.watch for kind config as the tool runner does (mesh-tools node-tools/internal/launch/launch.go:429-446, internal/runtime/provision.go:76): the value now first, as a mesh/provision request {watch, change: {kind, key}}, then the watch's answer, from one goroutine so the order holds. The value is unset, so design 51's default caller list holds. No test function added, no module.json change.

Quick or thorough: quick chosen. Thorough = one shared stand-in of the tool runner in mesh-sdk that every whole test plays (each whole test hand-writes its own player today; disk-load's is the same shape); first time met, so noted on issue 1966 rather than built. Other whole tests checked: only gitea and distribution hold callers from a watch; distribution's whole test never runs its bundle on stdin/stdout; the build modules' watch is handed in; mesh-self-check reads by get. None has the gap.

Proof: with the test file at bfa4a085 the test fails at whole_integration_test.go:333 and :372 with the message above; with the change it passes in 0.98 s. go vet with and without -tags integration clean in modules/gitea, unit suite passes; integration passes for gitea/cmd/package-registry, distribution/cmd/distribution and mesh-self-check/cmd/mesh-self-check, beside mesh-sdk 3176059, mesh-contracts 7fbfd77, mesh-delivery ee3906bb at origin/main.

Reviewed-by: mesh-code-reviewer@shanks (for lead-47@shanks) at 067b9a47da (round 1: approve)

https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ

Issue 1966 (trunk fault met while rebasing milestone G's branches). Since 24bf5921 (#646: distribution and the forge hold their caller list from its config watch, stdio.HoldVerbCallers), modules/gitea/cmd/package-registry TestThePackageSeatsWhole fails on main with "the config value callers cannot be read: not played here: mesh/provision.watch": the test's player answered only mesh/provision.get, so every check touching gitea fails. What changes: one test file. The player answers mesh/provision.watch for kind config as the tool runner does (mesh-tools node-tools/internal/launch/launch.go:429-446, internal/runtime/provision.go:76): the value now first, as a mesh/provision request {watch, change: {kind, key}}, then the watch's answer, from one goroutine so the order holds. The value is unset, so design 51's default caller list holds. No test function added, no module.json change. Quick or thorough: quick chosen. Thorough = one shared stand-in of the tool runner in mesh-sdk that every whole test plays (each whole test hand-writes its own player today; disk-load's is the same shape); first time met, so noted on issue 1966 rather than built. Other whole tests checked: only gitea and distribution hold callers from a watch; distribution's whole test never runs its bundle on stdin/stdout; the build modules' watch is handed in; mesh-self-check reads by get. None has the gap. Proof: with the test file at bfa4a085 the test fails at whole_integration_test.go:333 and :372 with the message above; with the change it passes in 0.98 s. go vet with and without -tags integration clean in modules/gitea, unit suite passes; integration passes for gitea/cmd/package-registry, distribution/cmd/distribution and mesh-self-check/cmd/mesh-self-check, beside mesh-sdk 3176059, mesh-contracts 7fbfd77, mesh-delivery ee3906bb at origin/main. Reviewed-by: mesh-code-reviewer@shanks (for lead-47@shanks) at 067b9a47dafdc90d8e9adf28597a337e774e0d9c (round 1: approve) https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ

mesh-tools added 1 commit 2026-11-10 10:06:51 +00:00

Play the config watch in the package seats' whole test, so the held callers list is proven (issue 1966)

mesh/delivery merged: source.main moved to novox/mesh-catalog@462db1c25719

Details

mesh/check checking 067b9a47dafd on 462db1c25719

067b9a47da

The holder holds its callers by a config watch since the callers were moved off per-call reads; the test's player answered only provision.get.

Claude-Session: https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ

mesh-tools commented

2026-11-10 10:06:54 +00:00

Delivery novox/mesh-catalog@067b9a47dafd — merged since 2026-11-10T14:40:54Z

Source — source.main moved to novox/mesh-catalog@462db1c257. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-11-10 10:06 (new) → proposed (announced): novox/mesh-catalog#652's head announced
2026-11-10 10:06 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-10 14:40 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-catalog@067b9a47dafd` — **merged** since 2026-11-10T14:40:54Z **Source** — source.main moved to novox/mesh-catalog@462db1c25719. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-11-10 10:06 (new) → proposed (announced): novox/mesh-catalog#652's head announced - 2026-11-10 10:06 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-10 14:40 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools referenced this pull request

2026-11-10 12:27:45 +00:00

The Go fetch takes zero-version requirements from the module graph and proves them with a shut-off load; mesh-build-image and -node name nodebuildgo (issue 1966) #654

mesh-tools merged commit 462db1c257 into main

2026-11-10 14:40:51 +00:00

mesh-tools deleted branch fix/1966-registry-test-watch

2026-11-10 14:40:52 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#652