A check step that errors after its fetch merged still answers its fetch #663

2026-11-12T14:32:56Z

mesh-tools commented

2026-11-12 14:32:56 +00:00

Small fix (hq playbook 08), group fix/checker-preview-after-failed-step with mesh-delivery; builds A-286 (hq 03-DESIGN/01-to-be/47-milestones/G-22-lead-answers-2.md; issue 1921 note 90; principle 3).

A build module's check step whose level errors (does not compile or generate) ended with no answer, so the checker could not preview the member, and the manifest validator and the composition were never judged (G's try 2). The shared step runner's check now returns its answer (the fetch and the levels so far) beside the error.

Quick fix: this, on main, so G's next try is judged whole. Thorough fix: the same rule in G's step runner and checker (join 11).

Test: a row in TestRunAskChecksNodeModulesAndConflicts, failing without the change.

Reviewed-by: mesh-code-reviewer@shanks at fff3b819d3

https://claude.ai/code/session_01NcbgfGKaxw984XyAPfLm4h

Small fix (hq playbook 08), group fix/checker-preview-after-failed-step with mesh-delivery; builds A-286 (hq 03-DESIGN/01-to-be/47-milestones/G-22-lead-answers-2.md; issue 1921 note 90; principle 3). A build module's check step whose level errors (does not compile or generate) ended with no answer, so the checker could not preview the member, and the manifest validator and the composition were never judged (G's try 2). The shared step runner's check now returns its answer (the fetch and the levels so far) beside the error. Quick fix: this, on main, so G's next try is judged whole. Thorough fix: the same rule in G's step runner and checker (join 11). Test: a row in TestRunAskChecksNodeModulesAndConflicts, failing without the change. Reviewed-by: mesh-code-reviewer@shanks at fff3b819d383492fd474bf7ff05e3b00a085fd0c https://claude.ai/code/session_01NcbgfGKaxw984XyAPfLm4h

mesh-tools added 1 commit 2026-11-12 14:32:56 +00:00

A check step that errors after its fetch merged still answers its fetch

mesh/delivery merged: source.main moved to novox/mesh-catalog@f1c04801e477

Details

mesh/delivery-group group fix/checker-preview-after-failed-step merged: every member is merged

Details

mesh/check checking fff3b819d383 on f1c04801e477 | novox/mesh-catalog#663 in group fix/checker-preview-after-failed-step

fff3b819d3

A level that does not compile or generate ended the check step failed with no
result, so the checker could not tell a merged fetch from one that never
answered, and previewed and judged no manifest or composition of the member.
The step now ends failed with its answer all the same: its fetch and the
levels so far beside the error, which the step's end already keeps.

Builds: design 47 G A-286 (G-22-lead-answers-2.md at hq 41dd30fe; issue 1921; principle 3)
Quick: this checker on main; thorough: the same rule in G's checker (join 11, J15).

Claude-Session: https://claude.ai/code/session_01NcbgfGKaxw984XyAPfLm4h

mesh-tools commented

2026-11-12 14:32:59 +00:00

Delivery novox/mesh-catalog@fff3b819d383 — merged since 2026-11-12T14:34:07Z

Source — source.main moved to novox/mesh-catalog@f1c04801e4. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/checker-preview-after-failed-step: novox/mesh-catalog@fff3b819d3, novox/mesh-delivery@24d9c6cdf8

Transitions

2026-11-12 14:32 (new) → proposed (announced): novox/mesh-catalog#663's head announced
2026-11-12 14:32 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-12 14:34 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-catalog@fff3b819d383` — **merged** since 2026-11-12T14:34:07Z **Source** — source.main moved to novox/mesh-catalog@f1c04801e477. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/checker-preview-after-failed-step`: novox/mesh-catalog@fff3b819d383, novox/mesh-delivery@24d9c6cdf8d9 **Transitions** - 2026-11-12 14:32 (new) → proposed (announced): novox/mesh-catalog#663's head announced - 2026-11-12 14:32 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-12 14:34 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools commented

2026-11-12 14:33:03 +00:00

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-tools merged commit f1c04801e4 into main

2026-11-12 14:34:06 +00:00

mesh-tools deleted branch fix/checker-preview-after-failed-step

2026-11-12 14:34:06 +00:00

jschoubben referenced this issue from a commit

2026-11-12 14:59:45 +00:00

Join 11: merge mesh-catalog main (a check step that errors after its fetch merged still answers)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-catalog#663