zfs: the scheduled run names its minutes, so its timer starts (issue 1979) #674

Merged
mesh-tools merged 1 commits from fix/1979-scrub-schedule-list into main 2026-11-12 22:12:31 +00:00
Member

Issue 1979, first small fix (the operator's yes, 2026-11-12). The zfs module's scrub-run schedule was */15 * * * *; the node-engine writes a cron step as OnCalendar=*-*-* *:*/15:00, which systemd refuses, so zfs-mesh-scrub.timer failed on the home server and the pool has had no scrub schedule since the zfs module was placed (the same apply stopped the distribution's weekly timer). The schedule is now 0,15,30,45 * * * *, which the node-engine writes as *-*-* *:0,15,30,45:00 (systemd-analyze calendar passes it on the home server). The node-engine's cron step stays the other session's fix.

Builds: design 42 milestone part zfs-owns-zfs §18. Tests: 1979/AC1 in modules/zfs/cmd/zfs-tools/manifest_test.go (the schedule string, and no step in it; the guard fails on the old value). 1979/AC2 is live after the delivery: the timer is active.

Reviewed-by: fix-1977@ace at bb96fbbb3c (the lead read the 2-file, 10-line diff itself instead of a separate reviewer: one string and its test; said under rules-are-weighed)
Pushed-by: fix-1977@ace

Issue 1979, first small fix (the operator's yes, 2026-11-12). The zfs module's scrub-run schedule was `*/15 * * * *`; the node-engine writes a cron step as `OnCalendar=*-*-* *:*/15:00`, which systemd refuses, so `zfs-mesh-scrub.timer` failed on the home server and the pool has had no scrub schedule since the zfs module was placed (the same apply stopped the distribution's weekly timer). The schedule is now `0,15,30,45 * * * *`, which the node-engine writes as `*-*-* *:0,15,30,45:00` (systemd-analyze calendar passes it on the home server). The node-engine's cron step stays the other session's fix. Builds: design 42 milestone part zfs-owns-zfs §18. Tests: 1979/AC1 in modules/zfs/cmd/zfs-tools/manifest_test.go (the schedule string, and no step in it; the guard fails on the old value). 1979/AC2 is live after the delivery: the timer is active. Reviewed-by: fix-1977@ace at bb96fbbb3c459fa0920208fa61b8fcf616de9084 (the lead read the 2-file, 10-line diff itself instead of a separate reviewer: one string and its test; said under rules-are-weighed) Pushed-by: fix-1977@ace
mesh-tools added 1 commit 2026-11-12 22:08:08 +00:00
zfs: the scheduled run names its minutes, so its timer starts (issue 1979)
mesh/delivery merged: source.main moved to novox/mesh-catalog@117f933dacf0
mesh/check checking bb96fbbb3c45 on 117f933dacf0
bb96fbbb3c
The node-engine writes a cron step (*/15) as a calendar systemd refuses, so
zfs-mesh-scrub.timer never started and the pool had no scrub schedule. A list
of minutes is written as *-*-* *:0,15,30,45:00, which systemd takes.

Builds: design 42 zfs-owns-zfs §18. Tests: 1979/AC1.
Author
Member

Delivery novox/mesh-catalog@bb96fbbb3c45 — merged since 2026-11-12T22:12:33Z

Source — source.main moved to novox/mesh-catalog@117f933dac. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

  • 2026-11-12 22:08 (new) → proposed (announced): novox/mesh-catalog#674's head announced
  • 2026-11-12 22:08 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-11-12 22:12 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@bb96fbbb3c45` — **merged** since 2026-11-12T22:12:33Z **Source** — source.main moved to novox/mesh-catalog@117f933dacf0. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-11-12 22:08 (new) → proposed (announced): novox/mesh-catalog#674's head announced - 2026-11-12 22:08 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-12 22:12 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit 117f933dac into main 2026-11-12 22:12:31 +00:00
mesh-tools deleted branch fix/1979-scrub-schedule-list 2026-11-12 22:12:31 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#674