16 modules' tests read module.json through mesh-sdk's manifest type; the copied helper goes (design 47 H2 H-A-498) #744

Merged
mesh-tools merged 1 commits from fix/manifest-test-lenient into main 2026-11-22 20:54:32 +00:00
Member

Builds design 47 H2 H-A-498 and its addendum (hq design/47-H1-answers-59 c8140b9f): the copied manifest struct and readManifest are deleted from the 15 desktop modules and pacman; their tests read module.json with catalogue.Decode and assert the module's own promises on catalogue.Manifest. Fails first on main (json: unknown field "class", since H2 §810), passes after.

Reviewed-by: mesh-code-reviewer@shanks at a3db292b8d

Merged at once without the check by the operator's word of 2026-11-22 21:05. Opened by lead-47@shanks.

Builds design 47 H2 H-A-498 and its addendum (hq design/47-H1-answers-59 c8140b9f): the copied `manifest` struct and `readManifest` are deleted from the 15 desktop modules and pacman; their tests read module.json with catalogue.Decode and assert the module's own promises on catalogue.Manifest. Fails first on main (json: unknown field "class", since H2 §810), passes after. Reviewed-by: mesh-code-reviewer@shanks at a3db292b8d9fc226113bdbd52a8c4f5816efd7a7 Merged at once without the check by the operator's word of 2026-11-22 21:05. Opened by lead-47@shanks.
mesh-tools added 1 commit 2026-11-22 20:54:21 +00:00
The fifteen desktop modules' tools tests failed on every manifest with
"json: unknown field class": a test helper copied into each module decoded
module.json into its own struct, refusing unknown fields. Manifest
strictness is the catalog check's alone, and the manifest's form is a
contract read through mesh-sdk's catalogue package, so the copied
`manifest` struct and its reader go from the fifteen desktop modules and
pacman; each test reads module.json with catalogue.Decode and asserts only
the module's own promises (claims, files, tools) on catalogue.Manifest.

Builds: design 47 H2 H-A-498, H-A-498 addendum
mesh-tools merged commit c9554e4b91 into main 2026-11-22 20:54:32 +00:00
mesh-tools deleted branch fix/manifest-test-lenient 2026-11-22 20:54:32 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#744