From 17243b72dfa883eb06e78cd76683f77b2a65130d Mon Sep 17 00:00:00 2001 From: jochen Date: Sun, 20 Sep 2026 13:32:47 +0200 Subject: [PATCH] Correct lavinmq Dockerfile's stale MESH_TOOL_MODULES comment (061 review) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The comment still said the provisioner is not listed and runs via a container's args — but the 061 fix put it in MESH_TOOL_MODULES (serve mode) and dropped the args. A future editor trusting the comment could strip it again and silently reintroduce 061. Comment now matches the code; only the run-once bootstrap runs via args. --- modules/lavinmq/Dockerfile | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/modules/lavinmq/Dockerfile b/modules/lavinmq/Dockerfile index dfbd207..a08580e 100644 --- a/modules/lavinmq/Dockerfile +++ b/modules/lavinmq/Dockerfile @@ -33,9 +33,10 @@ RUN node /app/node_modules/typescript/bin/tsc \ FROM ${RUNTIME_BASE} COPY --from=build /app/modules/lavinmq/dist /app/modules/lavinmq/dist -# What a tool host should load from this module: its event consumer and its tools, which are -# separate entrypoints because they are loaded by different things. The bootstrap and the -# provisioner are not listed here — the declaration names each in its container's `args`, because -# they are what this module's own containers run. One image, because they are one module and share -# a client. +# What the runtime loads from this module in serve mode: its event consumer, its tools, and its +# provisioner — all three in one process, so the provisioner's reconcile loop runs with the broker +# connected (novox/hq issues 060/061; the provisioner used to be run as a separate container `args` +# command, which meant it served no tools and, once, ran nowhere at all). The run-once bootstrap is +# NOT listed here — it is named in its own container's `args`, because it runs to completion before +# the broker starts rather than serving. One image, because they are one module and share a client. ENV MESH_TOOL_MODULES=/app/modules/lavinmq/dist/index.js,/app/modules/lavinmq/dist/tools/index.js,/app/modules/lavinmq/dist/provisioner/index.js -- 2.54.0