From cae0d00a7de370ff8a660847363d641d884bb001 Mon Sep 17 00:00:00 2001
From: jochen <jschoubben@gmail.com>
Date: Wed, 23 Sep 2026 20:22:34 +0200
Subject: [PATCH] Convert mssql from the module it replaces, not from a blank
 page
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Read against hal/modules/mssql: the predecessor publishes 4848:1433 and its connections
block hands every consumer localhost:4848; its data has lived in /services/mssql/data
since it was installed — 4.6 GB of it. The nox module had 1433, db-data, and a pin three
builds behind, so taking it would have moved the port every consumer was told about,
started on an empty directory, and downgraded the engine at the same time.

db-data was not a convention: only this module and mongodb used it, and both predecessors
say data. Now nothing moves at the cutover.
---
 modules/mssql/module.json | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/modules/mssql/module.json b/modules/mssql/module.json
index d397c6b..bc64318 100644
--- a/modules/mssql/module.json
+++ b/modules/mssql/module.json
@@ -20,10 +20,10 @@
   ],
   "listens": [
     {
-      "port": 1433,
+      "port": 4848,
       "protocol": "tcp",
       "from": "mesh",
-      "why": "modules on any machine that were granted a database"
+      "why": "modules on any machine that were granted a database. 4848, not 1433: the machine this replaces has served it there since it was installed, and every consumer was handed that number"
     }
   ],
   "serves": {
@@ -68,7 +68,7 @@
     {
       "id": "data",
       "type": "directory",
-      "path": "/services/mssql/db-data",
+      "path": "/services/mssql/data",
       "mode": "0700",
       "owner": "10001:0"
     },
@@ -81,16 +81,16 @@
       "id": "server",
       "type": "container",
       "name": "mssql",
-      "image": "mcr.microsoft.com/mssql/server@sha256:ba4c8329f48fb8f02e1416be6a930ebfd71268caee78aa985f3af4315e457c89",
+      "image": "mcr.microsoft.com/mssql/server@sha256:4402d880dd4c34bfa7d8705e56a86cd6c88da80a1f6bbbe741f999e76264a090",
       "network": "mssql",
       "env-file": [
         "/var/lib/mssql/sa.env"
       ],
       "ports": [
-        "1433"
+        "4848:1433"
       ],
       "volumes": [
-        "/services/mssql/db-data:/var/opt/mssql"
+        "/services/mssql/data:/var/opt/mssql"
       ],
       "secrets-in-environment": "the image documents only MSSQL_SA_PASSWORD, no _FILE and no configuration field; not convertible without a wrapper entrypoint"
     },
-- 
2.54.0