From 12f885ffc55efab0bbb7dac2888b60e65fbca0f9 Mon Sep 17 00:00:00 2001 From: jochen Date: Thu, 24 Sep 2026 15:45:58 +0200 Subject: [PATCH] 11 modules: a container's ports say the software's port, not the machine's hq issue 091, measured 2026-09-22: 14 of 46 modules with containers fix the machine side of a published port in their own manifest -- a fact about one machine (which port HAL happened to publish it on) written into a definition meant for any node. ADR 0038 already says the mesh assigns the machine side and a module says only what it needs; the machinery already does it (internal/inventory/ports.go's PortFor, declaration.go's publishedOn rewrites a bare port automatically). These 14 just never complied. Fixed 11 of them -- stripped to the bare software port, letting assignment take over: de-spiegel, gitea, hello-web (the demo module), mailu, mssql, n8n, novox.be, only-office, photos, photos-eef, photos-filip. Left alone, the two defensible kinds the issue names: postgres/lavinmq/ distribution (foundation, genesis-rewritten per ADR 0100 -- the number in the manifest is a default, not a claim) and unifi (protocol/ device-discovery fixes the number; nothing else can find the controller). gitea was a live one, not just a tidiness fix: its manifest said 2222:22, but the actual adopted, running container is on 222. Harmless while held, but the next 'take' would have recreated it on the wrong port and broken SSH git access. Recorded 222 as novox's own setting for it (settings set gitea -node novox) so that doesn't happen. --- modules/de-spiegel/module.json | 2 +- modules/gitea/module.json | 2 +- modules/hello-web/module.json | 2 +- modules/mailu/module.json | 2 +- modules/mssql/module.json | 2 +- modules/n8n/module.json | 2 +- modules/novox.be/module.json | 2 +- modules/only-office/module.json | 2 +- modules/photos-eef/module.json | 2 +- modules/photos-filip/module.json | 2 +- modules/photos/module.json | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) diff --git a/modules/de-spiegel/module.json b/modules/de-spiegel/module.json index b46b650..18d108c 100644 --- a/modules/de-spiegel/module.json +++ b/modules/de-spiegel/module.json @@ -58,7 +58,7 @@ "/var/lib/de-spiegel/server.env" ], "ports": [ - "35621:35621" + "35621" ], "secrets-in-environment": "the application's own code reads SMTP_AUTH_USER/PASS from the environment (de-spiegel server/index.js); converting is that repository's change" } diff --git a/modules/gitea/module.json b/modules/gitea/module.json index d40084e..a5bb2ce 100644 --- a/modules/gitea/module.json +++ b/modules/gitea/module.json @@ -118,7 +118,7 @@ ], "ports": [ "3000", - "2222:22" + "22" ], "volumes": [ "/services/gitea/gitea:/data" diff --git a/modules/hello-web/module.json b/modules/hello-web/module.json index 177124a..0cf69d7 100644 --- a/modules/hello-web/module.json +++ b/modules/hello-web/module.json @@ -50,7 +50,7 @@ "name": "hello-web", "network": "hello-web", "ports": [ - "8080:8080" + "8080" ], "volumes": [ "/var/lib/hello-web/index.html:/www/index.html:ro" diff --git a/modules/mailu/module.json b/modules/mailu/module.json index 9a7239c..b04ce66 100644 --- a/modules/mailu/module.json +++ b/modules/mailu/module.json @@ -368,7 +368,7 @@ "465", "587", "993", - "7080:80" + "80" ], "volumes": [ "/services/mailu/data/certs:/certs", diff --git a/modules/mssql/module.json b/modules/mssql/module.json index bc64318..5fa2b01 100644 --- a/modules/mssql/module.json +++ b/modules/mssql/module.json @@ -87,7 +87,7 @@ "/var/lib/mssql/sa.env" ], "ports": [ - "4848:1433" + "1433" ], "volumes": [ "/services/mssql/data:/var/opt/mssql" diff --git a/modules/n8n/module.json b/modules/n8n/module.json index 9d9f536..0a2bacf 100644 --- a/modules/n8n/module.json +++ b/modules/n8n/module.json @@ -71,7 +71,7 @@ "/var/lib/n8n/server.env" ], "ports": [ - "5682:5678" + "5678" ], "volumes": [ "/services/n8n/n8n-data:/home/node/.n8n" diff --git a/modules/novox.be/module.json b/modules/novox.be/module.json index 89b0d8b..cbf1d8f 100644 --- a/modules/novox.be/module.json +++ b/modules/novox.be/module.json @@ -43,7 +43,7 @@ "image": "registry-api.novox.be/novox/www@sha256:aa7ed20a293e1d7444c5c5d59b6d8bdb382bad159559a22e006810e379cae69c", "network": "novox-be", "ports": [ - "4000:8080" + "8080" ] } ] diff --git a/modules/only-office/module.json b/modules/only-office/module.json index 5afcf62..12fc97a 100644 --- a/modules/only-office/module.json +++ b/modules/only-office/module.json @@ -99,7 +99,7 @@ "/var/lib/only-office/server.env" ], "ports": [ - "9070:80" + "80" ], "volumes": [ "/services/only-office/logs:/var/log/onlyoffice", diff --git a/modules/photos-eef/module.json b/modules/photos-eef/module.json index 751c3e3..80fdaf5 100644 --- a/modules/photos-eef/module.json +++ b/modules/photos-eef/module.json @@ -44,7 +44,7 @@ "image": "registry-api.novox.be/novox/photos-client@sha256:f87d63ee7bfb44c9f9748b99be6ba6dc0daf955a1d463699e9e7e3009693c0ab", "network": "photos-eef", "ports": [ - "4012:80" + "80" ] } ] diff --git a/modules/photos-filip/module.json b/modules/photos-filip/module.json index a3be7d4..0c44daf 100644 --- a/modules/photos-filip/module.json +++ b/modules/photos-filip/module.json @@ -44,7 +44,7 @@ "image": "registry-api.novox.be/novox/photos-client@sha256:f87d63ee7bfb44c9f9748b99be6ba6dc0daf955a1d463699e9e7e3009693c0ab", "network": "photos-filip", "ports": [ - "4013:80" + "80" ] } ] diff --git a/modules/photos/module.json b/modules/photos/module.json index 99c7c1c..51b07e9 100644 --- a/modules/photos/module.json +++ b/modules/photos/module.json @@ -84,7 +84,7 @@ "image": "registry-api.novox.be/novox/photos-admin-client@sha256:f437fa9ed28b29a012f715fb8d9b809a15cff4a672794c620d5d400f57695580", "network": "photos", "ports": [ - "4001:80" + "80" ] } ] -- 2.54.0