The kinds check and recheck stay in H1 (H-A-117). Builds: design 47 H §764 (the checker (H1)); lead answers H-A-57, H-A-117 Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy
80 lines
2.7 KiB
Go
80 lines
2.7 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
sdkstep "git.novox.be/novox/mesh-delivery/modules/mesh-delivery-sdk/buildstep"
|
|
"git.novox.be/novox/mesh-delivery/modules/mesh-delivery-sdk/steprun"
|
|
)
|
|
|
|
// 1925/AC1: packagesArg takes the list as the bus's JSON shape ([]any) and as the typed list an ask hands in process
|
|
// ([]string), and refuses a bad element in either.
|
|
func TestPackagesArgTakesBothShapes(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
in any
|
|
want []string
|
|
refused bool
|
|
}{
|
|
{"absent", nil, nil, false},
|
|
{"typed", []string{"x/a", "x/b/..."}, []string{"x/a", "x/b/..."}, false},
|
|
{"json", []any{"x/a", "x/b/..."}, []string{"x/a", "x/b/..."}, false},
|
|
{"typed empty", []string{}, []string{}, false},
|
|
{"typed dotdot", []string{"x/../y"}, nil, true},
|
|
{"json dotdot", []any{"x/../y"}, nil, true},
|
|
{"typed bad", []string{"x a"}, nil, true},
|
|
{"json bad", []any{"x a"}, nil, true},
|
|
{"json not a string", []any{3}, nil, true},
|
|
{"a string", "x/a", nil, true},
|
|
}
|
|
for _, c := range cases {
|
|
got, err := packagesArg(c.in)
|
|
if c.refused != (err != nil) {
|
|
t.Errorf("%s: err = %v, refused want %v", c.name, err, c.refused)
|
|
continue
|
|
}
|
|
if !c.refused && !reflect.DeepEqual(got, c.want) {
|
|
t.Errorf("%s: got %#v, want %#v", c.name, got, c.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
// 1925/AC2: a check ask through the module's real build_go_test body gets past the packages argument: the digest names
|
|
// a package, steprun.RunAsk hands it in as a typed list, and the step fails only later, on the workspace nobody fetched.
|
|
func TestACheckAskReachesTheTestStepPastItsPackages(t *testing.T) {
|
|
m := &Module{Node: "ace", Work: t.TempDir()}
|
|
var calls []string
|
|
steps := fakeSteps(&calls)
|
|
for i := range steps {
|
|
switch steps[i].Name {
|
|
case "build_go_digest":
|
|
steps[i].Run = func(ctx context.Context, args map[string]any) (any, error) {
|
|
return map[string]any{"level": "unit", "packages": map[string]string{"x/a": "d1"}}, nil
|
|
}
|
|
case "build_go_test":
|
|
for _, real := range m.StepTools() {
|
|
if real.Name == "build_go_test" {
|
|
steps[i].Run = real.Run
|
|
}
|
|
}
|
|
}
|
|
}
|
|
a := sdkstep.StepAsk{ID: sdkstep.NewID(), Kind: sdkstep.AskCheck, Language: sdkstep.AskGo, Asker: "mesh-delivery-runner",
|
|
At: time.Now(), Check: &sdkstep.CheckJob{Fetch: sdkstep.Fetch{Repository: "novox/x", Commit: askCommit}, Levels: []string{sdkstep.LevelUnit}}}
|
|
out, err := steprun.RunAsk(context.Background(), m.askSteps(steps), a)
|
|
got := ""
|
|
if err != nil {
|
|
got = err.Error()
|
|
}
|
|
if strings.Contains(got, "packages is a list") {
|
|
t.Fatalf("the test step refused the ask's packages: %s", got)
|
|
}
|
|
if !strings.Contains(got, "no workspace") {
|
|
t.Fatalf("want the step to fail on the unfetched workspace, past its packages; err=%v out=%+v", err, out)
|
|
}
|
|
}
|