jschoubben
7b06a7a408
Every module named its events the way the old bus spelled a routing key — `module.<module>.<verb>`. Design 29 says a module names an event locally and the mesh works out where it lands, so all 37 were stale against a rule already decided. On the new bus that derives into a namespace belonging to a module called "module", so no cross-module subscription in the mesh matched anything: nothing failed, nothing reacted (novox/hq 04-ISSUES/127). 36 manifests converted, and 43 files of module code with them. The code mattered as much as the manifests: the runtime builds the subject from what `emit()` is handed, so a converted manifest with unconverted code would have had the permission and the subject disagree. Three things the new check found on the way: - `photos` emitted an event its manifest never declared, which the new bus refuses outright. Declared. - `showcase` waited for an event nothing emits, so its demo could never be triggered — only `showcase` may publish under its own name. It emits both halves now. - `distribution` declared an event named after a different module. It emits `image.pushed` under its own name. An event about a *role* belongs on the seat, where the name outlives whoever holds it, but the sdk has no way to publish on a seat yet, so that stays recorded rather than declared. The audit logger's "everything" pattern is `**` rather than the old bus's `#`.
59 lines
2.3 KiB
TypeScript
59 lines
2.3 KiB
TypeScript
// ombi's events. The tool runtime imports this once the broker is bound. Ombi's timeline is the
|
|
// request lifecycle: a viewer files a request, and later an operator approves it. Both transitions
|
|
// are worth announcing — the mesh can notify on a new request, and act on an approval (that is when
|
|
// a downloader should start looking).
|
|
//
|
|
// Emits (novox/hq ADR 0041/0042):
|
|
// module.ombi.request.created — a viewer filed a new request
|
|
// module.ombi.request.approved — a request was approved
|
|
//
|
|
// Ombi is the origin of these decisions, not a reactor to the mesh, so it consumes nothing.
|
|
//
|
|
// Both events are observation-based: poll the request list and diff. Creation is diffed on the set
|
|
// of request ids; approval on each request's approved flag flipping true. Primed silently on the
|
|
// first look, or a restart would re-announce every existing request and approval.
|
|
|
|
import { emit } from "@novox/mesh-sdk/events";
|
|
import { OmbiClient, type OmbiRequest } from "./client.js";
|
|
|
|
const ombi = OmbiClient.fromEnv();
|
|
|
|
// Remember each seen request and whether it was approved last time, keyed by kind+id (ids are only
|
|
// unique within a kind).
|
|
const approvedState = new Map<string, boolean>();
|
|
let primed = false;
|
|
|
|
const keyOf = (r: OmbiRequest): string => `${r.kind}:${r.id}`;
|
|
|
|
async function pollRequests(): Promise<void> {
|
|
const requests = await ombi.getRequests();
|
|
for (const r of requests) {
|
|
const key = keyOf(r);
|
|
const known = approvedState.has(key);
|
|
if (primed && !known) {
|
|
await emit("request.created", {
|
|
kind: r.kind,
|
|
id: r.id,
|
|
title: r.title,
|
|
requestedBy: r.requestedBy,
|
|
tmdbId: r.tmdbId,
|
|
});
|
|
}
|
|
// Approval: the flag went from false to true for a request we already knew about.
|
|
if (primed && known && r.approved && approvedState.get(key) === false) {
|
|
await emit("request.approved", { kind: r.kind, id: r.id, title: r.title, tmdbId: r.tmdbId });
|
|
}
|
|
approvedState.set(key, r.approved);
|
|
}
|
|
primed = true;
|
|
}
|
|
|
|
const tick = (fn: () => Promise<void>, everyMs: number): void => {
|
|
const run = (): void => void fn().catch((err) => console.error(`[ombi] ${err}`));
|
|
setInterval(run, everyMs);
|
|
run();
|
|
};
|
|
tick(pollRequests, 30_000);
|
|
|
|
console.log("[ombi] watching requests for new filings and approvals");
|