jochen
645961a87b
mesh/merge-gate pass: builds mesh-cli, mesh-delivery → novox; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
mesh/delivery delivered
- mesh-cli pins the SDK at its tag now that go/v0.1.9 exists, instead of a pseudo-version of the branch it was cut from. - mesh-delivery's stalled line for a head the forge never announced carries the pull request's number, which the controller's condition names in its headline.
81 lines
3.2 KiB
Go
81 lines
3.2 KiB
Go
package main
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// **A pull request the mesh was never asked to check is a delivery held, and said** (novox/hq issue 347): one open
|
|
// on a base that requires the merge check — mesh/merge-gate or mesh/repo-check, as hq requires only the second —
|
|
// whose head has had neither for ten minutes since this owner first saw it so, is a stalled line: the controller
|
|
// raises it as `delivery.<id>.stalled` (D14), the delivery domain's own word for a delivery held past its bound.
|
|
func TestAPullRequestNobodyCheckedIsAStalledDelivery(t *testing.T) {
|
|
w := newWorld(t)
|
|
head := "bfe82315f42c8f4509d0598c32569a202d5eada6"
|
|
w.forge.open = []OpenPull{
|
|
{Owner: "novox", Repo: "hq", Number: 243, Base: "main", HeadSHA: head, Required: []string{"mesh/repo-check"}},
|
|
{Owner: "novox", Repo: "sdk", Number: 14, Base: "main", HeadSHA: "aaaa", Required: []string{"mesh/merge-gate", "mesh/repo-check"},
|
|
Statuses: []string{"mesh/merge-gate"}},
|
|
{Owner: "novox", Repo: "free", Number: 1, Base: "main", HeadSHA: "bbbb", Required: nil},
|
|
}
|
|
w.h.SeeOpenPulls()
|
|
if lines := w.h.Stalled(); len(lines) != 0 {
|
|
t.Fatalf("a head just seen is stalled already: %+v", lines)
|
|
}
|
|
w.later(6 * time.Minute)
|
|
w.h.SeeOpenPulls() // seen again: its own first-seen time stands, whatever the forge's update time says
|
|
w.later(5 * time.Minute)
|
|
lines := w.h.Stalled()
|
|
if len(lines) != 1 || lines[0].ID != IDOf("novox/hq", head) || lines[0].State != Unannounced ||
|
|
!strings.Contains(lines[0].Says, "no merge check") || !strings.HasPrefix(lines[0].H2, "none") {
|
|
t.Fatalf("an unchecked pull request on a base requiring only mesh/repo-check reads %+v", lines)
|
|
}
|
|
if lines[0].Number != 243 {
|
|
t.Fatalf("the line does not name the pull request's number: %+v", lines[0])
|
|
}
|
|
if lines[0].For != "11m0s" {
|
|
t.Fatalf("its time is not counted from when this owner first saw it: %s", lines[0].For)
|
|
}
|
|
|
|
// Announced at last: a delivery of its own, with its own bound — no longer this line.
|
|
w.h.PullUpdated(pr("novox/hq", 243, head, "decision/x"))
|
|
w.h.SeeOpenPulls()
|
|
for _, l := range w.h.Stalled() {
|
|
if l.State == Unannounced {
|
|
t.Fatalf("an announced pull request is still said unannounced: %+v", l)
|
|
}
|
|
}
|
|
}
|
|
|
|
// One that gets a check, or closes, is dropped; one the forge cannot be asked about is not guessed.
|
|
func TestAnUncheckedPullRequestThatGetsACheckOrClosesIsDropped(t *testing.T) {
|
|
w := newWorld(t)
|
|
w.forge.open = []OpenPull{{Owner: "novox", Repo: "hq", Number: 1, Base: "main", HeadSHA: "cccc",
|
|
Required: []string{"mesh/merge-gate"}}}
|
|
w.h.SeeOpenPulls()
|
|
w.later(11 * time.Minute)
|
|
if len(w.h.Stalled()) != 1 {
|
|
t.Fatal("not said")
|
|
}
|
|
w.forge.open[0].Statuses = []string{"mesh/merge-gate"}
|
|
w.h.SeeOpenPulls()
|
|
if len(w.h.Stalled()) != 0 {
|
|
t.Fatal("a pull request with a check is still said")
|
|
}
|
|
w.forge.open[0].Statuses = nil
|
|
w.h.SeeOpenPulls()
|
|
w.later(11 * time.Minute)
|
|
w.forge.openDown = true
|
|
w.h.SeeOpenPulls() // the forge away: what was seen stands, nothing new is guessed
|
|
if len(w.h.Stalled()) != 1 {
|
|
t.Fatal("a forge that could not be asked dropped or invented a line")
|
|
}
|
|
w.forge.openDown = false
|
|
w.forge.open = nil
|
|
w.h.SeeOpenPulls()
|
|
if len(w.h.Stalled()) != 0 {
|
|
t.Fatal("a closed pull request is still said")
|
|
}
|
|
}
|