jschoubben
89c30c44be
mesh-delivery-gate: while the check gates no merge, ask the Approve only once the check has a verdict (issue 1733)
...
The operator, 2026-10-27 23:54: "if you don't want me to approve it, don't send
the approval request". The gate asked the Approve the moment a pull request
opened, before its check answered, and five changes were approved unchecked.
Now the ask waits for the checker's verdict at the heads it covers (a group's
verdict of all its heads together; a placement change's verdict ends only once
its nodes answered, ADR 0559 §5). A pass or a failure is asked, the failure in
its words, since check-gates-merge false lets the operator merge it anyway. A
check with no verdict 60 minutes after the heads became ready is asked anyway,
saying so, and asked again in new words when its verdict comes.
Quick fix (only the ask's wording) against thorough (the one place that decides
when to ask, ungatedWaits): thorough, which is one place here.
2026-10-27 23:59:09 +01:00
..
2026-10-26 22:02:58 +01:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-04 12:50:20 +02:00
2026-10-17 16:23:03 +00:00
2026-10-26 22:02:58 +01:00
2026-10-05 11:47:38 +02:00
2026-10-26 22:02:58 +01:00
2026-10-22 10:27:01 +02:00
2026-10-17 16:23:03 +00:00
2026-10-23 15:34:11 +02:00
2026-10-17 16:23:03 +00:00
2026-10-22 19:03:03 +02:00
2026-10-17 16:23:03 +00:00
2026-10-05 15:10:30 +02:00
2026-10-05 11:50:52 +02:00
2026-10-26 11:46:21 +01:00
2026-10-23 15:34:11 +02:00
2026-10-22 01:13:35 +02:00
2026-10-17 16:23:03 +00:00
2026-10-04 13:02:23 +02:00
2026-10-17 16:23:03 +00:00
2026-10-22 00:23:21 +02:00
2026-10-04 13:02:23 +02:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-04 13:02:23 +02:00
2026-10-16 09:42:45 +00:00
2026-10-26 22:02:58 +01:00
2026-10-27 21:54:51 +01:00
2026-10-17 16:23:03 +00:00
2026-10-16 09:42:45 +00:00
2026-10-21 09:51:22 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-16 09:42:45 +00:00
2026-10-26 22:02:58 +01:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-22 17:49:21 +02:00
2026-10-21 14:07:01 +02:00
2026-10-23 15:34:11 +02:00
2026-10-26 22:02:58 +01:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-16 09:42:45 +00:00
2026-10-23 09:10:09 +02:00
2026-10-22 11:44:45 +02:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-27 21:36:28 +01:00
2026-10-27 01:30:31 +01:00
2026-10-27 21:36:28 +01:00
2026-10-23 15:37:17 +02:00
2026-10-17 16:23:03 +00:00
2026-10-26 19:49:39 +01:00
2026-10-27 23:59:09 +01:00
2026-10-21 15:21:56 +02:00
2026-10-27 21:17:53 +01:00
2026-10-26 22:02:58 +01:00
2026-10-26 22:02:58 +01:00
2026-10-26 22:02:58 +01:00
2026-10-26 22:02:58 +01:00
Review round 1: an unset mail-reading verb answers unavailable not unknown, cache the index instead of leaking a pool per call, a gone mail leaves the queue without going unhealthy, sort the judge's own cause by its words, drive RunBatches itself for its pacing test, and prove no tell while unhealthy against a genuinely untold mail (issues 1430, 1523, 1517, 1518, 1520, 1519, 1524)
2026-10-21 01:48:23 +02:00
2026-10-21 13:14:57 +02:00
2026-10-26 22:02:58 +01:00
2026-10-17 16:23:03 +00:00
2026-10-26 20:12:21 +01:00
2026-10-17 16:23:03 +00:00
2026-10-24 18:25:38 +02:00
2026-10-26 22:02:58 +01:00
2026-10-22 18:12:32 +02:00
2026-10-22 18:12:32 +02:00
2026-10-23 10:18:57 +02:00
2026-10-17 16:23:03 +00:00
2026-10-22 18:12:32 +02:00
2026-10-22 11:47:44 +02:00
2026-10-23 16:27:06 +02:00
2026-10-21 13:07:08 +02:00
2026-10-26 22:02:58 +01:00
2026-10-25 16:57:46 +01:00
2026-10-26 22:02:58 +01:00
2026-10-17 16:23:03 +00:00
2026-10-16 09:42:45 +00:00
2026-10-26 22:02:58 +01:00
2026-10-17 16:23:03 +00:00
2026-10-21 09:51:22 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-22 17:49:08 +02:00
2026-10-17 16:23:03 +00:00
2026-10-26 22:02:58 +01:00
2026-10-26 22:02:58 +01:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-26 22:02:58 +01:00
2026-10-26 22:02:58 +01:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-24 16:58:33 +02:00
2026-10-21 13:14:57 +02:00
2026-10-21 14:07:01 +02:00
2026-10-16 09:42:45 +00:00
2026-10-17 16:23:03 +00:00
2026-10-08 15:04:02 +02:00
2026-10-17 16:23:03 +00:00
2026-10-26 22:02:58 +01:00
2026-10-04 13:02:23 +02:00
2026-10-23 09:38:40 +02:00
2026-10-16 09:42:45 +00:00
2026-10-17 16:23:03 +00:00
2026-10-16 09:42:45 +00:00
2026-10-17 16:23:03 +00:00
2026-10-22 21:31:58 +02:00
2026-10-26 22:02:58 +01:00
2026-10-07 21:35:49 +02:00
2026-10-17 16:23:03 +00:00
2026-10-16 09:42:45 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-04 13:02:23 +02:00
2026-10-16 09:42:45 +00:00
2026-10-26 22:02:58 +01:00
2026-10-26 22:02:58 +01:00
2026-10-17 16:23:03 +00:00
2026-10-17 16:23:03 +00:00
2026-10-16 09:42:45 +00:00
2026-10-16 09:42:45 +00:00