jschoubben
5ab8bb7e62
The manifest declares zfs-utils and zfs-dkms, renames scrub-pool to pool, and declares every new value not managed until set; its config file is ${config-json}, the options file, ZED's folder, rc, functions, handlers and drop-in each under their condition, the three ZFS units, the apply (run-once, restarted by its config file) and the run before the distribution's scrub and trim timers. One commit: the three subtasks change the one file module.json.
Builds: design 42 zfs-owns-zfs §6, §7, §8, §9, §11, §12, §13, §14, §15, §18, §20, A-1, A-2, A-3, A-7, A-14, A-15, A-16, A-23
97 lines
3.4 KiB
Go
97 lines
3.4 KiB
Go
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// The module's directory, where its manifest and its files/ are.
|
|
const moduleDir = "../.."
|
|
|
|
// templateText is the text a file resource places on the machine: its template's, in the module's files/
|
|
// (novox/hq ADR 0349 §2). A resource that names no template, or a template that is not there, fails the test.
|
|
func templateText(t *testing.T, r map[string]any) string {
|
|
t.Helper()
|
|
name, _ := r["template"].(string)
|
|
if name == "" {
|
|
t.Fatalf("resource %v names no template", r["id"])
|
|
}
|
|
raw, err := os.ReadFile(filepath.Join(moduleDir, filepath.FromSlash(name)))
|
|
if err != nil {
|
|
t.Fatalf("resource %v names %s: %v", r["id"], name, err)
|
|
}
|
|
return string(raw)
|
|
}
|
|
|
|
// No file resource carries its text inline: each names its template in files/, and the build packs files/
|
|
// into the one archive the controller reads the templates back from (novox/hq ADR 0349 §2).
|
|
func TestEveryFileTakesItsTextFromATemplate(t *testing.T) {
|
|
raw, err := os.ReadFile(filepath.Join(moduleDir, "module.json"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var m struct {
|
|
Resources []map[string]any `json:"resources"`
|
|
Build struct {
|
|
Artifacts []map[string]any `json:"artifacts"`
|
|
} `json:"build"`
|
|
}
|
|
if err := json.Unmarshal(raw, &m); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
for _, r := range m.Resources {
|
|
if _, inline := r["content"]; inline {
|
|
t.Errorf("resource %v keeps its text inline: keep it in files/ and name it as the template", r["id"])
|
|
}
|
|
if r["type"] == "file" {
|
|
templateText(t, r)
|
|
}
|
|
}
|
|
packs := 0
|
|
for _, a := range m.Build.Artifacts {
|
|
if a["kind"] == "archive" && a["from"] == "files" {
|
|
packs++
|
|
if a["name"] != "files" {
|
|
t.Errorf("the templates archive is named %v, not files", a["name"])
|
|
}
|
|
}
|
|
}
|
|
if packs != 1 {
|
|
t.Errorf("the build packs files/ into %d archives, not one", packs)
|
|
}
|
|
}
|
|
|
|
// §9, §12, §14 (A-15), §31: the three templates. The config file is the module's values as one JSON object; the options file holds
|
|
// config-lines for the ARC (in bytes) and the options; ZED's rc holds none of the package's notification or mail lines, and the
|
|
// scrub-after-resilver variable only its handler reads.
|
|
func TestTheConfigOptionsAndZedTemplates(t *testing.T) {
|
|
_, byID, _ := manifestOf(t)
|
|
if got := strings.TrimSpace(templateText(t, byID["config"])); got != "${config-json}" {
|
|
t.Errorf("the config file: %q", got)
|
|
}
|
|
opts := templateText(t, byID["options"])
|
|
for _, want := range []string{"${config-lines:arc-max:options zfs zfs_arc_max=:mib-bytes}", "${config-lines:arc-min:options zfs zfs_arc_min=:mib-bytes}",
|
|
"${config-lines:module-options:options zfs }"} {
|
|
if !strings.Contains(opts, want) {
|
|
t.Errorf("the options file lacks %s", want)
|
|
}
|
|
}
|
|
rc := templateText(t, byID["zed-rc"])
|
|
for _, bad := range []string{"ZED_NOTIFY", "ZED_EMAIL", "PUSHBULLET", "SLACK", "PUSHOVER", "NTFY", "GOTIFY"} {
|
|
for _, l := range strings.Split(rc, "\n") {
|
|
if strings.Contains(l, bad) && !strings.HasPrefix(l, "#") {
|
|
t.Errorf("zed.rc holds %s: %s", bad, l)
|
|
}
|
|
}
|
|
}
|
|
if !strings.Contains(rc, "\nZED_SCRUB_AFTER_RESILVER=1\n") {
|
|
t.Errorf("zed.rc does not enable the scrub after a resilver for its handler")
|
|
}
|
|
if drop := templateText(t, byID["zed-drop-in"]); !strings.Contains(drop, "ExecStart=/usr/bin/zed -F -d /etc/zfs/mesh-zed.d") {
|
|
t.Errorf("the drop-in does not run ZED from the module's folder: %s", drop)
|
|
}
|
|
}
|