Review round 1: versionsAnswer's choice of digest per seat had no test. TestTheVerbsSpeakTheSeatsContract now holds it, with a store whose blob and manifest digests differ. OCI.Blob refuses a manifest that keeps no single blob, naming its layers, and versions says that in the journal: the contract's answer has no field for why. Notes for H2: OCI.Held (oci.go) compares the tag's manifest digest with a bundle's or an archive's blob digest, the same kind as this fault; versions answers kind "" since the tool reads a kind its input does not take. Builds: design 47 G A-430a (G-22-lead-answers-2), design 51 *One contract*
80 lines
3.6 KiB
Go
80 lines
3.6 KiB
Go
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
reg "git.novox.be/novox/mesh-delivery/modules/mesh-delivery-contracts/go/seats/containerimageregistry"
|
|
|
|
"distribution/internal/holder"
|
|
)
|
|
|
|
// twoDigests is a store whose every version's manifest digest and blob differ.
|
|
type twoDigests struct{ holder.Catalog }
|
|
|
|
func (twoDigests) Digest(string, string) (string, error) { return "sha256:manifest", nil }
|
|
func (twoDigests) Blob(string, string) (string, error) { return "sha256:blob", nil }
|
|
|
|
func jsonFields(v any) map[string]bool {
|
|
out := map[string]bool{}
|
|
t := reflect.TypeOf(v)
|
|
for i := 0; i < t.NumField(); i++ {
|
|
name, _, _ := strings.Cut(t.Field(i).Tag.Get("json"), ",")
|
|
out[name] = true
|
|
}
|
|
return out
|
|
}
|
|
|
|
// TestTheVerbsSpeakTheSeatsContract holds distribution's seat verbs to the contracts mesh-contracts generates from the
|
|
// two seats' definitions (ADR 0620 *How it is checked*): every argument a verb's tool takes is a field of the
|
|
// contract's input, and every event body decodes into the contract's type with no field left over.
|
|
func TestTheVerbsSpeakTheSeatsContract(t *testing.T) {
|
|
inputs := map[string]any{reg.VerbPublish: reg.PublishInput{}, reg.VerbPublishPart: reg.PublishPartInput{},
|
|
reg.VerbVersions: reg.VersionsInput{}, reg.VerbRemove: reg.RemoveInput{}, reg.VerbHold: reg.HoldInput{},
|
|
reg.VerbRelease: reg.ReleaseInput{}, reg.VerbMirror: reg.MirrorInput{}, reg.VerbTags: reg.TagsInput{}}
|
|
seen := 0
|
|
for _, tool := range tools(&holder.Verbs{}, kept[holder.Window]{}) {
|
|
seat, verb, ok := strings.Cut(tool.Name, ".")
|
|
in, isVerb := inputs[verb]
|
|
if !ok || !isVerb || (seat != holder.ImageSeat && seat != holder.ArtifactSeat) {
|
|
continue
|
|
}
|
|
seen++
|
|
fields := jsonFields(in)
|
|
props, _ := tool.Input["properties"].(map[string]any)
|
|
for p := range props {
|
|
if !fields[p] {
|
|
t.Errorf("%s takes %q, which the contract's input does not name", tool.Name, p)
|
|
}
|
|
}
|
|
}
|
|
if seen != 14 {
|
|
t.Errorf("%d seat verbs served, want 14 (8 on the image seat, 6 on the artifact seat)", seen)
|
|
}
|
|
for event, want := range map[string]any{holder.EventPublished: ®.Outcome{}, holder.EventKept: ®.KeptEvent{}, holder.EventHeld: ®.Hold{}, holder.EventReleased: ®.Hold{}} {
|
|
b, _ := json.Marshal(eventBody(event, holder.Event{Name: "m/a", Kind: holder.KindArchive, Digest: "sha256:aa", Holder: holder.Self, By: "x.artifact-store-tools"}))
|
|
dec := json.NewDecoder(bytes.NewReader(b))
|
|
dec.DisallowUnknownFields()
|
|
if err := dec.Decode(want); err != nil {
|
|
t.Errorf("%s's body %s is not the contract's: %v", event, b, err)
|
|
}
|
|
}
|
|
if a := publishAnswer(holder.PublishAnswer{Transfer: "t", Missing: []string{"sha256:bb"}}); !reflect.DeepEqual(a.Lacks, []string{"sha256:bb"}) || a.Held {
|
|
t.Errorf("publish answers %+v", a)
|
|
}
|
|
// versions answers the digest a reference names (design 47 G A-430a): the blob on the artifact seat, the manifest on the image seat.
|
|
cat := twoDigests{}
|
|
for _, c := range []struct{ seat, want string }{{holder.ArtifactSeat, "sha256:blob"}, {holder.ImageSeat, "sha256:manifest"}} {
|
|
got := versionsAnswer(&holder.Verbs{Catalog: cat}, "", holder.VersionsAnswer{Seat: c.seat, Name: "m/files", Versions: []string{"0.1.7"}})
|
|
if len(got.Versions) != 1 || got.Versions[0].Digest != c.want || got.Versions[0].Version != "0.1.7" {
|
|
t.Errorf("versions on %s answers %+v, want digest %s", c.seat, got.Versions, c.want)
|
|
}
|
|
}
|
|
if r, err := partOf(reg.PublishPartInput{Transfer: "t", Part: "sha256:bb", Data: "aGk=", Last: true}); err != nil || string(r.Data) != "hi" || r.Digest != "sha256:bb" {
|
|
t.Errorf("publish-part read %+v, %v", r, err)
|
|
}
|
|
}
|