Read the backup holders of every machine, and the notes fixture's data at a resource (issues 1065, 1066)

cmd/mesh-controller/plan_backups_test.go

@@ -222,3 +222,18 @@ func TestAPlanThatMovesNoBackedUpItemAsksNothing(t *testing.T) {
 		t.Fatalf("proceed=%v err=%v record=%+v asked=%v", proceed, err, p.Backups, seat.asked)
 	}
 }
+
+// The holders of a node seat are every machine's, and a source that fails is no machine without a holder.
+func TestTheBackupHoldersAreEveryMachinesAndAFailedReadIsNotNoHolder(t *testing.T) {
+	entries := func(context.Context) ([]inventory.Entry, error) {
+		return []inventory.Entry{aModuleWith(t, "mail", []string{"ace", "g14"}, anItem("a", ""))}, nil
+	}
+	f, err := loadBackupFactsFrom(entries, func() ([]catalogue.Held, error) { return holders("ace", "g14"), nil }, t.Context())
+	if err != nil || !f.holder["ace"] || !f.holder["g14"] {
+		t.Fatalf("%+v %v", f, err)
+	}
+	if _, err := loadBackupFactsFrom(entries, func() ([]catalogue.Held, error) { return nil, fmt.Errorf("store down") },
+		t.Context()); err == nil || !strings.Contains(err.Error(), "store down") {
+		t.Fatalf("a failed read of the holders must fail the step: %v", err)
+	}
+}