Keep the store address's query in every test database's address, so store tests reach a socket-addressed store (issue 1889)

The checker's integration store answers on a unix socket named in the query of MESH_TEST_POSTGRES
(?host=<socket dir>&sslmode=disable). The identity, inventory and licences fixtures cut the address at
its last slash and appended ?sslmode=disable, dropping host=, so pgx dialled its default socket where no
server is: every store test waited out its 20 s readiness bound, each package ran into go test's
10-minute timeout, and the verdict named only the first failure,
identity.TestACertificateChainsToTheMeshsOwnAuthority.

store.DatabaseForTest now builds that address for every fixture, keeping the query as the template raise
already did; identity's fresh is ForTest rather than a second copy. The readiness bound and its error,
which wraps the driver's cause, are unchanged.

internal/identity/fortest.go

@@ -37,8 +37,7 @@ func ForTest(t *testing.T) *Identity {
 	}
 	store.CreateMigratedForTest(t, admin, name, migrations)
 
-	cut := strings.LastIndex(admin, "/")
-	t.Setenv(store.Variable(Name), admin[:cut]+"/"+name+"?sslmode=disable")
+	t.Setenv(store.Variable(Name), store.DatabaseForTest(admin, name))
 
 	ident, err := Open(t.Context())
 	if err != nil {

internal/identity/identity_test.go

@@ -7,61 +7,19 @@ import (
 	"context"
 	"crypto/ed25519"
 	"errors"
-	"fmt"
 	"os"
-	"strings"
 	"sync"
 	"testing"
-	"time"
 
 	"github.com/jackc/pgx/v5"
-	"github.com/novox/mesh-controller/internal/store"
 )
 
+// fresh is the package's own name for ForTest: one fixture for every store test of identity, so the way
+// a test's database is made and addressed is kept true in one place (novox/hq issue 1889: this copy
+// dropped the store address's query and reached no server on the checker's socket-addressed store).
 func fresh(t *testing.T) *Identity {
 	t.Helper()
-	admin := os.Getenv("MESH_TEST_POSTGRES")
-	if admin == "" {
-		t.Skip("no MESH_TEST_POSTGRES; run `make check` to raise one")
-	}
-	name := fmt.Sprintf("ident_%d", time.Now().UnixNano()%10_000_000)
-
-	conn, err := pgx.Connect(t.Context(), admin)
-	if err != nil {
-		t.Fatalf("cannot reach the test PostgreSQL: %v", err)
-	}
-	if _, err := conn.Exec(t.Context(), "create database "+name); err != nil {
-		t.Fatalf("cannot create %s: %v", name, err)
-	}
-	conn.Close(t.Context())
-
-	cut := strings.LastIndex(admin, "/")
-	t.Setenv(store.Variable(Name), admin[:cut]+"/"+name+"?sslmode=disable")
-
-	ident, err := Open(t.Context())
-	if err != nil {
-		t.Fatal(err)
-	}
-	t.Cleanup(func() {
-		ident.Close()
-		c, err := pgx.Connect(context.Background(), admin)
-		if err != nil {
-			return
-		}
-		defer c.Close(context.Background())
-		_, _ = c.Exec(context.Background(), "drop database if exists "+name+" with (force)")
-	})
-	if err := ident.Ready(t.Context(), 20*time.Second); err != nil {
-		t.Fatal(err)
-	}
-	migrations, err := Migrations()
-	if err != nil {
-		t.Fatal(err)
-	}
-	if _, err := ident.store.Migrate(t.Context(), migrations); err != nil {
-		t.Fatal(err)
-	}
-	return ident
+	return ForTest(t)
 }
 
 func TestNoKeyIsAnErrorRatherThanAnEmptyKey(t *testing.T) {