The controller no longer subscribes to the alive message: HostBeats, its handler, the heartbeat-gap duration and a fixed silent bound (issue 1183, AC3, AC4, AC5)

internal/inventory/durations.go

@@ -9,10 +9,9 @@ import (
 
 // The kinds of duration recorded.
 const (
-	DurationApply        = "apply"
-	DurationHeartbeatGap = "heartbeat-gap"
-	DurationPlanTier     = "plan-tier"
-	DurationBuild        = "build"
+	DurationApply    = "apply"
+	DurationPlanTier = "plan-tier"
+	DurationBuild    = "build"
 	// DurationWalkPhase is one phase of an ended walk, per class (novox/hq ADR 0282 decision 6): subject
 	// "<class>/<phase>", and "<class>/total" for its merge to every machine running it.
 	DurationWalkPhase = "walk-phase"
@@ -27,7 +26,7 @@ const (
 const ApplyBusy = "busy"
 
 // DurationKinds are every kind, in the order `durations` shows them.
-var DurationKinds = []string{DurationApply, DurationHeartbeatGap, DurationPlanTier, DurationBuild, DurationWalkPhase,
+var DurationKinds = []string{DurationApply, DurationPlanTier, DurationBuild, DurationWalkPhase,
 	DurationBusy}
 
 // DurationsKeptFor is how long a duration is kept: long enough to set a bound from, and to correct it
@@ -94,17 +93,6 @@ func (i *Inventory) RecordBusyDuration(ctx context.Context, node, declared strin
 	return err
 }
 
-// RecordHeartbeatGap measures the silence before a machine's word: from the last word heard before
-// it, which the caller read before recording this one.
-func (i *Inventory) RecordHeartbeatGap(ctx context.Context, node string, before time.Time) error {
-	if before.IsZero() {
-		return nil
-	}
-	now := time.Now()
-	return i.RecordDuration(ctx, Duration{Kind: DurationHeartbeatGap, Subject: node, Node: node,
-		Ref: before.UTC().Format(time.RFC3339Nano), Started: before, Took: now.Sub(before)})
-}
-
 // Durations is every measurement of a kind since a moment, oldest first; every kind when kind is empty.
 func (i *Inventory) Durations(ctx context.Context, kind string, since time.Time) ([]Duration, error) {
 	rows, err := i.store.Pool().Query(ctx,

internal/inventory/durations_test.go

@@ -44,25 +44,6 @@ func TestAnApplyIsMeasuredOncePerSend(t *testing.T) {
 	}
 }
 
-// A machine's silence is the time since its last word, once per word.
-func TestASilenceIsMeasuredFromTheLastWord(t *testing.T) {
-	inv := ForTest(t)
-	ctx := t.Context()
-	before := time.Now().Add(-90 * time.Second)
-	for range 2 {
-		if err := inv.RecordHeartbeatGap(ctx, "anchor", before); err != nil {
-			t.Fatal(err)
-		}
-	}
-	if err := inv.RecordHeartbeatGap(ctx, "anchor", time.Time{}); err != nil {
-		t.Fatal(err)
-	}
-	ds, err := inv.Durations(ctx, DurationHeartbeatGap, time.Now().Add(-time.Hour))
-	if err != nil || len(ds) != 1 || ds[0].Took < 90*time.Second || ds[0].Took > 2*time.Minute {
-		t.Fatalf("%v %+v", err, ds)
-	}
-}
-
 // A plan's tier is measured when the plan leaves it — moving on, or ending — and only then.
 func TestAPlansTierIsMeasuredWhenItIsLeft(t *testing.T) {
 	inv := ForTest(t)

internal/inventory/heartbeat_gap_gone_test.go

@@ -0,0 +1,12 @@
+package inventory
+
+import "testing"
+
+// 1183/AC3: the heartbeat-gap duration is no kind the mesh measures.
+func TestNoHeartbeatGapIsMeasured(t *testing.T) { // 1183/AC3
+	for _, k := range DurationKinds {
+		if k == "heartbeat-gap" {
+			t.Fatalf("%s is still a kind of duration: %v", k, DurationKinds)
+		}
+	}
+}