The controller no longer subscribes to the alive message: HostBeats, its handler, the heartbeat-gap duration and a fixed silent bound (issue 1183, AC3, AC4, AC5)

2026-10-19 02:16:21 +02:00
parent 863db82737
commit 19e3eac746
26 changed files with 174 additions and 160 deletions
@@ -9,10 +9,9 @@ import (

 // The kinds of duration recorded.
 const (
-	DurationApply        = "apply"
-	DurationHeartbeatGap = "heartbeat-gap"
-	DurationPlanTier     = "plan-tier"
-	DurationBuild        = "build"
+	DurationApply    = "apply"
+	DurationPlanTier = "plan-tier"
+	DurationBuild    = "build"
 	// DurationWalkPhase is one phase of an ended walk, per class (novox/hq ADR 0282 decision 6): subject
 	// "<class>/<phase>", and "<class>/total" for its merge to every machine running it.
 	DurationWalkPhase = "walk-phase"
@@ -27,7 +26,7 @@ const (
 const ApplyBusy = "busy"

 // DurationKinds are every kind, in the order `durations` shows them.
-var DurationKinds = []string{DurationApply, DurationHeartbeatGap, DurationPlanTier, DurationBuild, DurationWalkPhase,
+var DurationKinds = []string{DurationApply, DurationPlanTier, DurationBuild, DurationWalkPhase,
 	DurationBusy}

 // DurationsKeptFor is how long a duration is kept: long enough to set a bound from, and to correct it
@@ -94,17 +93,6 @@ func (i *Inventory) RecordBusyDuration(ctx context.Context, node, declared strin
 	return err
 }

-// RecordHeartbeatGap measures the silence before a machine's word: from the last word heard before
-// it, which the caller read before recording this one.
-func (i *Inventory) RecordHeartbeatGap(ctx context.Context, node string, before time.Time) error {
-	if before.IsZero() {
-		return nil
-	}
-	now := time.Now()
-	return i.RecordDuration(ctx, Duration{Kind: DurationHeartbeatGap, Subject: node, Node: node,
-		Ref: before.UTC().Format(time.RFC3339Nano), Started: before, Took: now.Sub(before)})
-}
-
 // Durations is every measurement of a kind since a moment, oldest first; every kind when kind is empty.
 func (i *Inventory) Durations(ctx context.Context, kind string, since time.Time) ([]Duration, error) {
 	rows, err := i.store.Pool().Query(ctx,