A merge on the operator's Approve into a repository the mesh builds nothing from asks the first build of the modules it holds (issue 1146, AC6, AC7)

2026-10-19 00:11:52 +02:00
parent b1cfb85f86
commit 19f15d8ea0
7 changed files with 280 additions and 3 deletions
@@ -0,0 +1,81 @@
+//go:build integration
+
+package main
+
+import (
+	"context"
+	"testing"
+	"time"
+
+	"git.novox.be/novox/mesh-sdk/go/asks"
+	"github.com/novox/mesh-controller/internal/inventory"
+	"github.com/novox/mesh-controller/internal/link"
+)
+
+// 1146/AC7: mesh-delivery #1 merged on the operator's Approve into a repository the mesh builds nothing from. The forge's
+// announcement, heard as the controller hears it (SourceMoved, hearMerge), asks the first build of the module the merge
+// commit holds; the build's outcome registers it; and the module is in the catalogue. Without the Approve nothing is
+// asked. Store-backed: skips without one.
+func TestAMergeOnTheApproveIntoANewRepositoryAsksTheFirstBuildAndItsOutcomeRegistersTheModule(t *testing.T) {
+	const head, commit = "a1a1a1a1a1a1a1a1a1a1a1a1a1a1a1a1a1a1a1a1", "0177ea7a00000000"
+	for _, approved := range []bool{true, false} {
+		open := aMesh(t)
+		ctx := t.Context()
+		inv := open.inventory
+		asked := asksWithPaths(t)
+
+		a := aDeliveryMergeOf(t, head, map[string]string{"novox/mesh-delivery@a1a1a1a1a1a1": head})
+		a.merge.Number = 1
+		wasKept, wasAsk := keptDeliveryMerge, routerAskOf
+		keptDeliveryMerge = func(context.Context, string, string, int, string) (deliveryMerge, bool, error) {
+			return a.merge, approved, nil
+		}
+		routerAskOf = func(context.Context, catalogueReader, string) (*asks.Ask, *asks.Warrant, error) {
+			return &a.ask, &a.warrant, nil
+		}
+		t.Cleanup(func() { keptDeliveryMerge, routerAskOf = wasKept, wasAsk })
+
+		m := link.SourceMoved{Owner: "novox", Repo: "mesh-delivery", Base: "main", HeadSHA: head, Commit: commit, Number: 1,
+			MergedAt: time.Now().Add(-time.Hour).UTC().Format(time.RFC3339Nano), Paths: []string{"module.json", "main.go"},
+			ModuleDirs: []string{"."}, ModuleDirsSaid: true}
+		if err := (following{open: open}).SourceMoved(ctx, m); err != nil {
+			t.Fatalf("approved %v: %v", approved, err)
+		}
+		if !approved {
+			if len(*asked) != 0 {
+				t.Fatalf("1146/AC7: a merge with no Approve asked %v", *asked)
+			}
+			continue
+		}
+		want := [3]string{"novox/mesh-delivery", "", "main"}
+		if len(*asked) != 1 || (*asked)[0] != want {
+			t.Fatalf("1146/AC7: the merge asked %v, want %v", *asked, want)
+		}
+		build := onTrunk("b-", "novox/mesh-delivery", "git", "", map[string]any{"module": "mesh-delivery-view", "version": "1"})
+		build.Commit = commit
+		if _, _, err := takeIn(ctx, inv, build); err != nil {
+			t.Fatalf("1146/AC7: the outcome of the first build was refused: %v", err)
+		}
+		src, err := inv.SourceOf(ctx, "mesh-delivery-view")
+		if err != nil || src.Repository != "novox/mesh-delivery" {
+			t.Fatalf("1146/AC7: the module is built from %q (%v)", src.Repository, err)
+		}
+		if _, known := inventoryHolds(t, inv, "mesh-delivery-view"); !known {
+			t.Fatal("1146/AC7: the module is not in the catalogue")
+		}
+	}
+}
+
+func inventoryHolds(t *testing.T, inv *inventory.Inventory, module string) (inventory.Entry, bool) {
+	t.Helper()
+	entries, err := inv.Catalogued(t.Context())
+	if err != nil {
+		t.Fatal(err)
+	}
+	for _, e := range entries {
+		if e.Manifest.Module == module {
+			return e, true
+		}
+	}
+	return inventory.Entry{}, false
+}