Give every module of a failed send a verdict, and excuse only the wait a build's own send brought (hq issue 318 review)
This commit is contained in:
@@ -255,8 +255,13 @@ func TestACoreBehindWhileTheNodeToolsSettleFailsNoOtherModule(t *testing.T) {
|
||||
t.Fatalf("%s's build was marked failed for the node tools' condition", m)
|
||||
}
|
||||
}
|
||||
if !strings.Contains(p.Note, "app1 was not found wanting") {
|
||||
t.Fatalf("the plan blames the module its gate was kept on: %s", p.Note)
|
||||
// Healthy for the passes asked, the module the gate is kept on keeps its own pass (novox/hq issue 318
|
||||
// review): it is not blamed, and not left without a verdict.
|
||||
if !strings.Contains(p.Note, "app1 passed on its own and is kept") {
|
||||
t.Fatalf("the plan blames the module its gate was kept on, or leaves it unjudged: %s", p.Note)
|
||||
}
|
||||
if v, found, _ := inv.GateOf(ctx, "build-app1-2"); !found || v.Verdict != inventory.GatePassed {
|
||||
t.Fatalf("app1's own pass was not kept: %+v", v)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user