novox/mesh-controller
18
0
Fork 0
Code Issues Pull Requests 3 Releases Wiki Activity

Put the served test's registrations on the bus's chain, and keep the seat-row test on a verb release 6 keeps (issue 1945)

Browse Source 
Assignments and builds live on the bus (ADR 0408), so a fixture written before the chain was attached was not what
the serving controller read; and push, which the row test used, went with the plans.
This commit is contained in:
jschoubben
2026-10-24 19:04:55 +02:00
parent 3ad12f8ec7
commit 370673195c
2 changed files with 51 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/inventory/seats_test.go
+5 -4
View File
@@ -126,7 +126,7 @@ func TestTheControllersVerbsInTheRowAreTheBinarys(t *testing.T) {
if _, err := inv.SeedSeats(ctx, catalogue.DefaultSeats()); err != nil {
t.Fatal(err)
}
old := `[{"name":"push","description":"an older push","input":{"type":"object","properties":{"node":{"type":"string"}}}},
old := `[{"name":"assign","description":"an older assign","input":{"type":"object","properties":{"node":{"type":"string"}}}},
{"name":"newer","description":"a verb of a newer build"}]`
if _, err := inv.store.Pool().Exec(ctx, `update seat set serves = $1 where name = $2`,
[]byte(old), catalogue.ControllerSeatName); err != nil {
@@ -147,9 +147,10 @@ func TestTheControllersVerbsInTheRowAreTheBinarys(t *testing.T) {
}
}
}
props, _ := verbs["push"].Input["properties"].(map[string]any)
if _, takesWhy := props["why"]; !takesWhy || verbs["push"].Description == "an older push" {
t.Fatalf("push in the row is still the older build's: %+v", verbs["push"])
// assign, a verb release 6 keeps (push went with the plans, ADR 0539): the row takes the binary's arguments.
props, _ := verbs["assign"].Input["properties"].(map[string]any)
if _, takesModule := props["module"]; !takesModule || verbs["assign"].Description == "an older assign" {
t.Fatalf("assign in the row is still the older build's: %+v", verbs["assign"])
}
if _, kept := verbs["newer"]; !kept {
t.Fatal("a verb only the row has was dropped")