Ask build-agent no composed check of a delivery group, and answer that the checker judges it (issue 1299, C2, ADR 0503 §3)

cmd/mesh-controller/pull_declares.go

@@ -2,7 +2,6 @@ package main
 
 import (
 	"context"
-	"encoding/json"
 	"fmt"
 	"io"
 	"path"
@@ -138,71 +137,6 @@ func tellPullDeclares(ctx context.Context, w io.Writer, pulls []pullAt) {
 	}
 }
 
-// heldFor asks mesh-config for the approved held values of these pull requests at their heads (ADR 0502 clause 4). Only
-// those of the pull requests asked about are carried. A failure is said to w and answers none.
-func heldFor(ctx context.Context, w io.Writer, pulls []pullAt) []link.HeldConfig {
-	if len(pulls) == 0 {
-		return nil
-	}
-	type pullHead struct {
-		Pull string `json:"pull"`
-		Head string `json:"head"`
-	}
-	asked := make([]pullHead, 0, len(pulls))
-	for _, p := range pulls {
-		asked = append(asked, pullHead{p.key(), p.New})
-	}
-	raw, err := meshConfigAsk(ctx, map[string]any{"action": "held", "pulls": asked})
-	if err != nil {
-		fmt.Fprintf(w, "mesh-config cannot say what it holds for these pull requests (%v); the check goes on without held values\n", err)
-		return nil // empty-on-error: said above; a check without held values fails for want of the value and says so, it never passes on a guess
-	}
-	var answer struct {
-		Held    []link.HeldConfig `json:"held"`
-		Skipped []struct {
-			Pull string `json:"pull"`
-			Why  string `json:"why"`
-		} `json:"skipped"`
-	}
-	if len(raw) == 0 {
-		return nil
-	}
-	if err := json.Unmarshal(raw, &answer); err != nil {
-		fmt.Fprintf(w, "mesh-config's held values cannot be read (%v); the check goes on without them\n", err)
-		return nil // empty-on-error: said above; a check without held values fails for want of the value and says so, it never passes on a guess
-	}
-	for _, s := range answer.Skipped {
-		fmt.Fprintf(w, "%s: mesh-config holds a value it does not carry: %s\n", s.Pull, s.Why)
-	}
-	var out []link.HeldConfig
-	for _, h := range answer.Held {
-		for _, p := range pulls {
-			if h.Pull == p.key() {
-				out = append(out, h)
-				break
-			}
-		}
-	}
-	return out
-}
-
-// withHeldConfig tells mesh-config what these pull requests declare and puts the approved held values of them on the
-// check request (ADR 0502 clause 4). With carry false, a member of a group whose composed check composes, only the
-// declarations are told.
-func withHeldConfig(ctx context.Context, w io.Writer, request *link.BuildRequest, pulls []pullAt, carry bool) {
-	tellPullDeclares(ctx, w, pulls)
-	if carry {
-		carryHeld(ctx, w, request, pulls)
-	}
-}
-
-// carryHeld puts the approved held values of these pull requests on the check request.
-func carryHeld(ctx context.Context, w io.Writer, request *link.BuildRequest, pulls []pullAt) {
-	if request.Check != nil {
-		request.Check.HeldConfig = heldFor(ctx, w, pulls)
-	}
-}
-
 // holdsModules is whether a module of the mesh is built from this repository.
 func holdsModules(entries []inventory.Entry, owner, repo string) bool {
 	return slices.ContainsFunc(entries, func(e inventory.Entry) bool {