The mesh builds: a machine takes the work, and the catalogue shows it
A build is work, not state. Everything else the control plane sends a node is a declaration — this is what you should be — reconciled forever. A build happens once and is finished. Putting it in a declaration would mean rebuilding on every reconcile, or a declaration carrying "and I already did this", which is state about an event rather than about a machine. So it travels on its own queue and the answer comes back correlated. One queue, so several build machines share the work and each request is done exactly once — which a per-machine routing key would not give. mesh-builder is the program a build machine runs. Not the control plane, which must not run commands on a machine; not the host, which would then need a container runtime and git everywhere to do something almost no machine will ever do. It holds its own broker credential and nothing else. Three properties that are decisions: - a request is acknowledged only once the answer is away, so a builder that dies mid-build leaves the work for another machine rather than losing it with nobody ever hearing why - one build at a time. Five at once against one runtime finishes all five slower than it would have finished the first, and the queue is what shares work between machines - a failure is a RESULT. A build that fails silently is indistinguishable from a builder that is not running, and those want different responses And `module list` is a catalogue: what exists, at which version, built from which commit or handed over by hand or shipped with the control plane, whether it is behind its source, and which machines run it. All of that was recorded from the first build and none of it was shown, so "is this current?" could only be answered by reading the database. Proven against a real broker, registry and store: the mesh asked, a builder consumed, built, published, answered; the manifest was recorded with its commit; the source moved and the catalogue said "behind"; rebuilding caught it up with a new digest because the content changed.
This commit is contained in:
@@ -3,6 +3,7 @@ package inventory
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/novox/mesh-control/internal/catalogue"
|
||||
@@ -428,3 +429,91 @@ func TestAPinGoesWhenTheProviderLeavesTheMesh(t *testing.T) {
|
||||
t.Fatalf("a choice outlived the machine it named: %d row(s) left", rows)
|
||||
}
|
||||
}
|
||||
|
||||
func TestTheCatalogueSaysWhereEachModuleCameFromAndWhoRunsIt(t *testing.T) {
|
||||
// The provenance was recorded from the first build and nothing showed it, which made "is this
|
||||
// current?" a question you could only answer by reading the database.
|
||||
inv := fresh(t)
|
||||
ctx := context.Background()
|
||||
for _, n := range []string{"workstation", "laptop"} {
|
||||
if _, err := inv.AddNode(ctx, n); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
if err := inv.RegisterModule(ctx, manifest("shell", []string{"login-shell"}, nil),
|
||||
Source{Repository: "https://forge.invalid/shell.git", BuiltFrom: "aaa", Head: "aaa"}); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := inv.RegisterModule(ctx, manifest("byhand", nil, nil), Source{}); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := inv.Provide(ctx, manifest("networking", nil, []string{"login-shell"})); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
for _, n := range []string{"workstation", "laptop"} {
|
||||
if err := inv.Assign(ctx, n, "shell"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
entries, err := inv.Catalogued(ctx)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
by := map[string]Entry{}
|
||||
for _, e := range entries {
|
||||
by[e.Manifest.Module] = e
|
||||
}
|
||||
if len(by) != 3 {
|
||||
t.Fatalf("the catalogue has %d modules", len(by))
|
||||
}
|
||||
|
||||
// Sorted, and both nodes, so a person reading it twice sees the same thing.
|
||||
if got := strings.Join(by["shell"].On, ","); got != "laptop,workstation" {
|
||||
t.Fatalf("shell runs on %q", got)
|
||||
}
|
||||
if by["shell"].Source.Repository != "https://forge.invalid/shell.git" {
|
||||
t.Fatalf("shell came from %q", by["shell"].Source.Repository)
|
||||
}
|
||||
if by["shell"].Provided {
|
||||
t.Fatal("a module built from a repository was reported as shipped with the control plane")
|
||||
}
|
||||
|
||||
// A module nobody runs is in the catalogue: the catalogue is what EXISTS, and what runs is a
|
||||
// different question the same row answers.
|
||||
if len(by["byhand"].On) != 0 {
|
||||
t.Fatalf("byhand runs on %v", by["byhand"].On)
|
||||
}
|
||||
// Handed over by hand is its own state. Nothing can rebuild it, and showing it as a
|
||||
// repository would send somebody looking for one.
|
||||
if by["byhand"].Source.Repository != "" || by["byhand"].Provided {
|
||||
t.Fatalf("byhand: %+v", by["byhand"])
|
||||
}
|
||||
|
||||
if !by["networking"].Provided {
|
||||
t.Fatal("a module the control plane ships was not marked as such")
|
||||
}
|
||||
if by["networking"].Source.Repository != "" {
|
||||
// It is not a repository, and showing it as one would have somebody go looking for it.
|
||||
t.Fatalf("networking claims to come from %q", by["networking"].Source.Repository)
|
||||
}
|
||||
}
|
||||
|
||||
func TestACatalogueEntryKnowsWhetherItIsBehind(t *testing.T) {
|
||||
inv := fresh(t)
|
||||
ctx := context.Background()
|
||||
if err := inv.RegisterModule(ctx, manifest("shell", nil, nil),
|
||||
Source{Repository: "https://forge.invalid/shell.git", BuiltFrom: "aaa", Head: "aaa"}); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := inv.SourceMoved(ctx, "shell", "bbb"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
entries, err := inv.Catalogued(ctx)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if entries[0].Source.Current() {
|
||||
t.Fatal("a module whose source moved reported itself current")
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user