Say a build handed out again restarted, in its log, the queue and the check's verdict

A build agent replaced mid-build leaves its ask to be handed out again, and the second run looked like a first: the queue and the pull request showed nothing of the 5-8 minutes lost (novox/hq issue 594).
2026-10-13 00:26:08 +02:00
parent 21ac8fd858
commit 43cab56452
8 changed files with 214 additions and 5 deletions
@@ -0,0 +1,52 @@
+package main
+
+import (
+	"strings"
+	"testing"
+	"time"
+
+	"github.com/novox/mesh-controller/internal/link"
+)
+
+// **A check that ran again says so on the pull request** (novox/hq issue 594): a build agent replaced
+// mid-check leaves the ask to be handed out again, and the verdict that finally comes is from a second
+// run. Each layer's summary — what the forge shows as the check's line — names the restart.
+func TestARestartedCheckSaysSoOnEveryLayer(t *testing.T) {
+	asked := &link.CheckRequest{Owner: "novox", Repo: "mesh-controller", Number: 279}
+	gate := &link.CheckLayer{Verdict: "pass", Summary: "every node composes"}
+	repo := &link.CheckLayer{Verdict: "pass", Summary: "merge-check.sh passed"}
+	c := checkedOf(link.BuildResult{ID: "b", Ref: "abc", On: "shanks", Checked: asked, Delivery: 2,
+		Check: &link.CheckOutcome{Verdict: "pass", Summary: "every node composes", Gate: gate, RepoCheck: repo}})
+	for name, said := range map[string]string{"summary": c.Summary, "gate": c.Gate.Summary,
+		"repository check": c.RepoCheck.Summary} {
+		if !strings.Contains(said, "restarted") {
+			t.Errorf("the %s says %q: a check run twice reads as run once", name, said)
+		}
+	}
+	if gate.Summary != "every node composes" {
+		t.Errorf("the build's own outcome was changed under it: %q", gate.Summary)
+	}
+
+	// Taken once, nothing is added.
+	once := checkedOf(link.BuildResult{ID: "b", Ref: "abc", Checked: asked, Delivery: 1,
+		Check: &link.CheckOutcome{Verdict: "pass", Summary: "every node composes"}})
+	if strings.Contains(once.Summary, "restarted") {
+		t.Errorf("a check run once says %q", once.Summary)
+	}
+}
+
+// And the queue says it of the ask in flight.
+func TestTheQueueSaysAnAskInFlightRestarted(t *testing.T) {
+	now := time.Date(2026, 10, 13, 0, 16, 0, 0, time.UTC)
+	q := link.Queue{Seat: link.TheBuildMachine, Delivered: 1, AckPending: 1, MaxDeliver: 5, Asks: []link.QueuedAsk{
+		{Seq: 1, ID: "build-279", Repository: "ssh://forge/novox/mesh-controller", AskedAt: now.Add(-7 * time.Minute),
+			State: link.AskInFlight, On: "shanks", Started: now.Add(-time.Minute), Delivery: 2},
+	}}
+	text := queueText(q, now)
+	if !strings.Contains(text, "restarted") {
+		t.Fatalf("the queue does not say the ask restarted:\n%s", text)
+	}
+	if a := queueAnswerOf(q, now).Asks[0]; a.Delivery != 2 {
+		t.Errorf("the queue's data says delivery %d, want 2", a.Delivery)
+	}
+}