From 491cbe254864204abf79e745c037b8e35645d9d9 Mon Sep 17 00:00:00 2001 From: jochen Date: Sat, 24 Oct 2026 05:42:39 +0200 Subject: [PATCH] Hold the expiry of a pending assignment to the words it has said since R4g: its last build, when, and that it failed (issue 1938) The test was kept from older runs and ran again only once the inventory changed beneath it; e419d018 changed the words. --- cmd/mesh-controller/pending_integration_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmd/mesh-controller/pending_integration_test.go b/cmd/mesh-controller/pending_integration_test.go index 2e7b833c..306ae903 100644 --- a/cmd/mesh-controller/pending_integration_test.go +++ b/cmd/mesh-controller/pending_integration_test.go @@ -151,7 +151,9 @@ func TestAPendingAssignmentExpiresWhenItsBuildFails(t *testing.T) { if len(pending) != 1 || pending[0].State != inventory.PendingExpired { t.Fatalf("pending after a failed build: %+v", pending) } - for _, want := range []string{"expired", "build b-modules/sensors of modules/sensors failed", + // Its words since R4g (whyNotBuilt): the build, when it was heard, and that it failed (issue 1938: kept from an older + // run until the inventory changed beneath it). + for _, want := range []string{"expired", "modules/sensors in novox/mesh-catalog; its last build, b-modules/sensors at", ", failed: go build", "undefined: sensorsRead", "nothing was assigned", "build \"true\""} { if !strings.Contains(pending[0].Note, want) { t.Fatalf("the expiry does not say %q: %s", want, pending[0].Note)