novox/mesh-controller
6
0
Fork 0
Code Issues Pull Requests 4 Releases Wiki Activity

Test the bus users as issue 195 made them: an account-reading module is one, another is not

Browse Source 
The postgres-backed test still expected a module that declares no broker
secret to be a bus user, and failed on main since #270; it skips without a
database, so the change's own run did not see it.
This commit is contained in:
jochen
2026-10-05 18:01:28 +02:00
parent e8478e208b
commit 625d02862c
1 changed files with 23 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/inventory/busrecords_test.go
+23 -7
View File
@@ -42,26 +42,37 @@ func theSeatDeclarer() catalogue.Manifest {
// A module assigned to a machine becomes a user with the authority its manifest declared — and the // A module assigned to a machine becomes a user with the authority its manifest declared — and the
// protocol of a seat declared by a *different* module, which is the whole reason a seat exists. // protocol of a seat declared by a *different* module, which is the whole reason a seat exists.
func TestAnAssignedModuleBecomesAUserWithWhatItDeclared(t *testing.T) { func TestAnAssignedModuleBecomesAUserWithWhatItDeclared(t *testing.T) {
// It declares where its account is delivered: a module with no own secret named broker can never
// be issued one, and is no user at all (novox/hq issue 195) — the case asserted below.
shop := catalogue.Manifest{ shop := catalogue.Manifest{
Module: "shop", Version: "1", Module: "shop", Version: "1",
Emits: []string{"order.placed"}, Tools: []string{"price"}, Emits: []string{"order.placed"}, Tools: []string{"price"},
Uses: []string{"telegram-sender"}, Uses: []string{"telegram-sender"},
OwnSecrets: catalogue.OwnSecrets{"broker": {Path: "/run/broker"}},
} }
inv, ctx := aMeshWith(t, theSeatDeclarer(), shop) quiet := catalogue.Manifest{Module: "quiet", Version: "1", Emits: []string{"thing.happened"}}
inv, ctx := aMeshWith(t, theSeatDeclarer(), shop, quiet)
if _, err := inv.AddNode(ctx, "one"); err != nil { if _, err := inv.AddNode(ctx, "one"); err != nil {
t.Fatal(err) t.Fatal(err)
} }
if _, err := inv.Assign(ctx, "one", "shop"); err != nil { for _, module := range []string{"shop", "quiet"} {
t.Fatal(err) if _, err := inv.Assign(ctx, "one", module); err != nil {
t.Fatal(err)
}
} }
records, err := inv.BusRecords(ctx) records, err := inv.BusRecords(ctx)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
on := records.Assigned["one"] var on []broker.Declared
if len(on) != 1 || on[0].Module != "shop" { for _, d := range records.Assigned["one"] {
t.Fatalf("the machine's modules read as %+v", on) if d.Module == "shop" {
on = append(on, d)
}
}
if len(on) != 1 || on[0].NoAccount {
t.Fatalf("the machine's modules read as %+v", records.Assigned["one"])
} }
if len(on[0].Uses) != 1 || on[0].Uses[0].Accepts[0] != "send" { if len(on[0].Uses) != 1 || on[0].Uses[0].Accepts[0] != "send" {
t.Fatalf("the seat it uses carries no protocol: %+v — so it would be granted nothing on a "+ t.Fatalf("the seat it uses carries no protocol: %+v — so it would be granted nothing on a "+
@@ -98,6 +109,11 @@ func TestAnAssignedModuleBecomesAUserWithWhatItDeclared(t *testing.T) {
if !found { if !found {
t.Fatal("no user was derived for the assigned module") t.Fatal("no user was derived for the assigned module")
} }
for _, u := range users {
if u.Username() == "one.quiet" {
t.Fatal("a module with nowhere to read an account was made a user (novox/hq issue 195)")
}
}
} }
// A machine holding a live token gets an enrolment user; one whose token is spent or expired does // A machine holding a live token gets an enrolment user; one whose token is spent or expired does