novox/mesh-controller
6
0
Fork 0
Code Issues Pull Requests 3 Releases Wiki Activity

Hold the resolver to bind-interfaces, as mesh-catalog PR 161 makes it (hq issue 348)

Browse Source
This commit is contained in:
jschoubben
2026-10-09 15:00:56 +02:00
committed by jochen
parent 997a4925b0
commit 63b87b6f7b
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/catalogue/resolver_manifests_test.go
+7 -1
View File
@@ -51,7 +51,10 @@ func TestTheResolverForwardsToFixedUpstreamsAndNeverReadsResolvConf(t *testing.T
"\nno-resolv\n", "\nserver=1.1.1.1\n", "\nserver=8.8.8.8\n", "\nno-resolv\n", "\nserver=1.1.1.1\n", "\nserver=8.8.8.8\n",
// The private address and loopback, never a LAN's (novox/hq ADR 0194): a device that is not a // The private address and loopback, never a LAN's (novox/hq ADR 0194): a device that is not a
// member cannot reach what the mesh's names point at. // member cannot reach what the mesh's names point at.
"\nlisten-address=127.0.0.1\n", "\nlisten-address=${machine:address}\n", "\nbind-dynamic\n", "\nlisten-address=127.0.0.1\n", "\nlisten-address=${machine:address}\n",
// Each address bound once, at start, never closed (novox/hq issue 348, with mesh-catalog PR 161):
// bind-dynamic closed the private address's listener when a bridge teardown failed its re-read.
"\nbind-interfaces\n",
// No hosts file and no operator's files: the mesh's resolver answers every node (ADR 0199). // No hosts file and no operator's files: the mesh's resolver answers every node (ADR 0199).
"\nno-hosts\n", "\nno-hosts\n",
"\nconf-file=" + m.Facts["zones"].Path + "\n", "\nconf-file=" + m.Facts["zones"].Path + "\n",
@@ -62,6 +65,9 @@ func TestTheResolverForwardsToFixedUpstreamsAndNeverReadsResolvConf(t *testing.T
t.Errorf("the resolver's configuration lacks %q:\n%s", strings.TrimSpace(want), config) t.Errorf("the resolver's configuration lacks %q:\n%s", strings.TrimSpace(want), config)
} }
} }
if strings.Contains(config, "\nbind-dynamic\n") {
t.Error("the resolver binds dynamically, and closes a listener whenever a re-read of the addresses fails (issue 348)")
}
// By address and never by interface: dnsmasq admits a query by the interface it arrives on // By address and never by interface: dnsmasq admits a query by the interface it arrives on
// when told one, and a container's query to the private address arrives on the runtime's // when told one, and a container's query to the private address arrives on the runtime's
// bridge — `interface=mesh0` dropped every such query, silently (novox/hq issue 110). // bridge — `interface=mesh0` dropped every such query, silently (novox/hq issue 110).