Walk phases: a report past the silent bound never moves a walk's end; keep phases outside the hold on the plans; first-node gate in words (review of #206)

cmd/mesh-controller/release_plan.go

@@ -508,7 +508,11 @@ func advancePlans(ctx context.Context, open *stores) {
 		fmt.Printf("plans: what waits for a gate could not be looked at: %v\n", err)
 	}
 	advanceHeld(ctx, open)
-	// Where the walks that ended lately spent their time (novox/hq ADR 0282): measured, never acted on.
+}
+
+// keepWalkPhases keeps where the walks that ended lately spent their time (novox/hq ADR 0282), outside the hold
+// on the plans so it never lengthens it: measured, never acted on, and an error only said.
+func keepWalkPhases(ctx context.Context, open *stores) {
 	if err := recordWalkPhases(ctx, open.inventory, time.Now()); err != nil {
 		fmt.Printf("plans: the phases of the walks ended lately could not be kept: %v\n", err)
 	}
@@ -1215,6 +1219,7 @@ func sayUnsent(p *inventory.Plan, rollsOut func(string) bool) {
 // planTicker advances open plans on a timer, for the steps outcomes alone cannot take.
 func planTicker(ctx context.Context, open *stores) {
 	advancePlans(ctx, open)
+	keepWalkPhases(ctx, open)
 	tick := time.NewTicker(30 * time.Second)
 	defer tick.Stop()
 	for {
@@ -1223,6 +1228,7 @@ func planTicker(ctx context.Context, open *stores) {
 			return
 		case <-tick.C:
 			advancePlans(ctx, open)
+			keepWalkPhases(ctx, open)
 		}
 	}
 }