Issue a bus process's account when its module is assigned or gains it (issue 1226)

2026-10-21 19:21:11 +02:00
parent deac3e232c
commit 6bcfbeb5b2
3 changed files with 88 additions and 2 deletions
@@ -0,0 +1,64 @@
+//go:build integration
+
+package main
+
+import (
+	"path/filepath"
+	"strings"
+	"testing"
+
+	"git.novox.be/novox/mesh-sdk/go/catalogue"
+
+	"github.com/novox/mesh-controller/internal/broker"
+)
+
+// 1226/AC2: given an assigned module whose new definition adds a bus process, when the delivery records it,
+// that process's account is issued and the next compose carries a real account; and (AC1) before it, the
+// composition refuses the module naming issue; (AC3) a later record does not replace the account.
+func TestAGainedProcessIsIssuedWhenTheDeliveryRecordsIt(t *testing.T) {
+	open := aMesh(t)
+	ctx := t.Context()
+	inv := open.inventory
+
+	dir := t.TempDir()
+	if err := busCertificate([]string{"--into", dir}); err != nil {
+		t.Fatal(err)
+	}
+	t.Setenv(broker.AddressVar, "127.0.0.1:4222")
+	t.Setenv(broker.CertificateVar, filepath.Join(dir, "tls.crt"))
+
+	// Assigned without the process, then a definition that gains it.
+	plain, err := catalogue.ParseManifest([]byte(`{"module":"mesh-mail","version":"1",
+		"own-secrets":{"broker-send":{"path":"/var/lib/mesh-mail/broker-send","owner":"mesh-mail-send"}},
+		"resources":[{"id":"account","type":"user","name":"mesh-mail-send"}]}`))
+	if err != nil {
+		t.Fatal(err)
+	}
+	register(t, open, plain)
+	if _, err := assign(ctx, open, "laptop", "mesh-mail"); err != nil {
+		t.Fatal(err)
+	}
+	gained := mailSenderWithProcess()
+	register(t, open, gained)
+
+	// 1226/AC1 on the store: nothing issued, so the compose refuses, naming issue.
+	if _, err := prepareSend(ctx, open, "laptop"); err == nil || !strings.Contains(err.Error(), "mesh-controller.issue laptop mesh-mail") {
+		t.Fatalf("1226/AC1: the composition did not refuse the unissued account naming issue: %v", err)
+	}
+
+	issueGainedProcessAccounts(ctx, inv, gained)
+	hash, held, err := inv.BusUserHash(ctx, "laptop.mesh-mail.send")
+	if err != nil || !held {
+		t.Fatalf("1226/AC2: the gained process's account was not issued: held %v, %v", held, err)
+	}
+	if _, err := prepareSend(ctx, open, "laptop"); err != nil {
+		t.Fatalf("1226/AC2: the next compose does not carry the account: %v", err)
+	}
+
+	// 1226/AC3: recording the definition again, and composing, replaces nothing.
+	issueGainedProcessAccounts(ctx, inv, gained)
+	again, _, err := inv.BusUserHash(ctx, "laptop.mesh-mail.send")
+	if err != nil || again != hash {
+		t.Fatalf("1226/AC3: the issued account was replaced (%v)", err)
+	}
+}