The controller raises what the watchman says stopped moving, and takes a machine's silence from its presence (issue 1156)
This commit is contained in:
@@ -335,7 +335,7 @@ func watchHeartbeats(f *signalFacts) []conditions.Observation {
|
||||
}
|
||||
bound := heartbeatBound(m.every)
|
||||
silent := f.now.Sub(m.lastHeard)
|
||||
if silent <= bound {
|
||||
if !m.silent(f.now) {
|
||||
continue
|
||||
}
|
||||
severity := conditions.Warning
|
||||
@@ -357,7 +357,7 @@ func watchReports(f *signalFacts) []conditions.Observation {
|
||||
if m.sentAt.IsZero() || m.reportedCurrent || m.asleep() {
|
||||
continue
|
||||
}
|
||||
if !m.lastHeard.IsZero() && f.now.Sub(m.lastHeard) > heartbeatBound(m.every) {
|
||||
if m.silent(f.now) {
|
||||
continue // silent: S1 says it, and a silent machine reports nothing
|
||||
}
|
||||
bound := max(reportAtLeast, 3*m.lastApply)
|
||||
|
||||
Reference in New Issue
Block a user