Pin the node-engine at its ADR 0328 merge (#95), and speak its contract: a library's verdict is said for the modules that use it

internal/catalogue/libraries_test.go

@@ -6,6 +6,8 @@ import (
 	"reflect"
 	"strings"
 	"testing"
+
+	"github.com/novox/mesh-host/validate"
 )
 
 // Defends novox/hq ADR 0328 on the controller's side, row by row of its "How it is checked" table where the row is the
@@ -90,7 +92,7 @@ func TestAJoiningModuleIsComposedWithItsIdentityAndLibraries(t *testing.T) {
 		t.Errorf("its directory is owned by %v; want its user and primary group", owner)
 	}
 	if len(composed.Identities) != 1 || !reflect.DeepEqual(composed.Identities[0], IdentityEntry{Module: "radarr",
-		Name: "mesh-radarr", UID: 50020, GID: 50020, Groups: []string{"mesh-media", "mesh-books"}}) {
+		Name: "mesh-radarr", UID: 50020, GID: 50010, Groups: []int{50011}}) {
 		t.Errorf("the identities are %+v", composed.Identities)
 	}
 	if w := LibraryWarnings(aRadarr(t)); len(w) != 1 || !strings.Contains(w[0], "reaches only media") {
@@ -317,3 +319,22 @@ func TestTheLibrariesAreTheOperatorsSetting(t *testing.T) {
 		t.Fatal("a library in the machine's own tree was accepted")
 	}
 }
+
+// What the node-engine this controller pins (mesh-host #95, ADR 0328's half) makes of a composed declaration with
+// libraries and a joining module: nothing refused.
+func TestTheEngineTakesWhatIsComposedForLibraries(t *testing.T) {
+	for _, node := range []string{"ace", "novox"} {
+		r := Resolution{Node: node, Account: "jochen", Modules: []Manifest{aRadarr(t), theRuntime(t)}}
+		with := librariesRendering()
+		with.Libraries["books"] = Library{Name: "books", Home: "ace", Root: "/storage/books", Reach: []string{"novox"}}
+		composed := composeLibraries(t, r, with)
+		body, err := json.Marshal(map[string]any{"declaration": validate.Version, "resources": composed.Resources,
+			"groups": composed.Groups, "identities": composed.Identities, "libraries": composed.Libraries})
+		if err != nil {
+			t.Fatal(err)
+		}
+		if problems := validate.Declaration(body); len(problems) > 0 {
+			t.Fatalf("%s: the pinned node-engine refuses it: %v", node, problems)
+		}
+	}
+}