From 822e52123cb6a5ad851f3be9ccd797fbbcdb672e Mon Sep 17 00:00:00 2001 From: jochen Date: Fri, 9 Oct 2026 03:23:47 +0200 Subject: [PATCH] Say S17 clears once the new bus is sent, as it does The comment and the signals table's bound said it cleared once the bus's machine runs the new build; it clears once that machine has been sent it, when no send is refused for the bus any more. --- cmd/mesh-controller/bus_waits.go | 5 +++-- cmd/mesh-controller/signals.go | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/cmd/mesh-controller/bus_waits.go b/cmd/mesh-controller/bus_waits.go index 38f9f214..0c02e870 100644 --- a/cmd/mesh-controller/bus_waits.go +++ b/cmd/mesh-controller/bus_waits.go @@ -19,8 +19,9 @@ import ( // as the walk's note; nothing was raised, and the operator found the hold by asking why a walk did not move. // Row S17 raises it on the first tick after the first refusal, in the bus's scope, for the operator: what // waits, behind which bus build, since when, and the verb. A walk held only by it is not late, so S3 leaves it -// out, as it leaves out a walk under a paused build seat. It clears once the bus's machine runs the build the -// mesh holds — the step was taken — whatever the walks' notes still say. +// out, as it leaves out a walk under a paused build seat. It clears once the bus's machine has been sent the +// build the mesh holds — the step was taken, and no send is refused for the bus any more — whatever the walks' +// notes still say. Whether the new bus came up healthy is the step's own condition (probe DB). // kindBusStepWaiting is S17's kind: bus..step-waiting. const kindBusStepWaiting = "bus-step-waiting" diff --git a/cmd/mesh-controller/signals.go b/cmd/mesh-controller/signals.go index 80aca734..1dcc3f20 100644 --- a/cmd/mesh-controller/signals.go +++ b/cmd/mesh-controller/signals.go @@ -213,7 +213,7 @@ var signalsTable = []signalRow{ {Row: "S17", Signal: "a send held for the bus's planned step is told to a person", Emitter: "controller's plan", Trigger: "each send refused because it would replace the bus outside its step (novox/hq issue 336)", Bound: "none: raised at the first refusal, for the operator, naming what waits, the bus build from and to, " + - "since when and `bus upgrade`; cleared once the bus's machine runs the build the mesh holds", + "since when and the mesh-controller.bus call; cleared once the bus's machine has been sent the build the mesh holds", Kind: kindBusStepWaiting, Severity: conditions.Warning, Phase: 3, needs: func(f *signalFacts) error { if f.plansErr != nil {