Cite the hq issues by the numbers they were given: 285, 286, 287
This commit is contained in:
@@ -519,7 +519,7 @@ func gateLayer(ctx context.Context, spec CheckSpec, tree, root, gate, verdictFil
|
||||
case "fail":
|
||||
return "fail", said.Summary
|
||||
case "error":
|
||||
// The gate could not raise the mesh as it is (novox/hq issue 282): said in its own words.
|
||||
// The gate could not raise the mesh as it is (novox/hq issue 285): said in its own words.
|
||||
return "error", said.Summary
|
||||
}
|
||||
}
|
||||
@@ -835,7 +835,7 @@ func (t *tail) String() string {
|
||||
|
||||
// whatFailed is the line of a failed script's output that says what failed, for the status a pull request
|
||||
// shows: the first failing test, the first failing package, the files not formatted — a bare "FAIL" or a
|
||||
// file's name said nothing a reader could act on (novox/hq issue 283) — and the last line otherwise.
|
||||
// file's name said nothing a reader could act on (novox/hq issue 286) — and the last line otherwise.
|
||||
func whatFailed(s string) string {
|
||||
lines := strings.Split(strings.TrimSpace(s), "\n")
|
||||
for i, line := range lines {
|
||||
|
||||
@@ -415,7 +415,7 @@ func TestABuildSaysWhetherItsCommitIsOnTheTrunk(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// **Issue 283**: a failed merge-check.sh was said by its last line — a bare "FAIL", or the name of a file
|
||||
// **Issue 286**: a failed merge-check.sh was said by its last line — a bare "FAIL", or the name of a file
|
||||
// gofmt listed — which named nothing a reader could act on. The status says what failed.
|
||||
func TestAFailedScriptIsSaidByWhatFailed(t *testing.T) {
|
||||
for out, want := range map[string]string{
|
||||
|
||||
Reference in New Issue
Block a user