Keep a plan's backups in the store: a migration and the plan's read and write (issues 1065, 1066)

internal/inventory/plans_test.go

@@ -198,3 +198,28 @@ func TestASchemaReachIsKeptByBuild(t *testing.T) {
 		t.Fatalf("reach %d %v %v", reach, known, err)
 	}
 }
+
+// A plan keeps its backups through the store, timestamps to the nanosecond (novox/hq ADR 0404, issue 1065).
+func TestAPlanKeepsItsBackupsInTheStore(t *testing.T) {
+	inv := ForTest(t)
+	ctx := t.Context()
+	at := time.Now().UTC()
+	p := Plan{ID: "plan-backups", Repository: "novox/mesh-catalog", Commit: "abc", Created: at, State: PlanBuilding,
+		Tiers: [][]string{{"mail"}}, Modules: map[string]*PlanModule{"mail": {}},
+		Backups: &PlanBackups{State: BackupPending, NoHolder: []string{"bare"},
+			Asked: []PlanBackup{{Machine: "ace", Module: "mail", State: BackupPending, AskedAt: &at}}}}
+	if err := inv.SavePlan(ctx, &p); err != nil {
+		t.Fatal(err)
+	}
+	got, err := inv.PlanByID(ctx, p.ID)
+	if err != nil || got.Backups == nil || !reflect.DeepEqual(got.Backups, p.Backups) {
+		t.Fatalf("kept %+v (%v), wrote %+v", got.Backups, err, p.Backups)
+	}
+	got.Backups.State = BackupDone
+	if err := inv.SavePlan(ctx, &got); err != nil {
+		t.Fatal(err)
+	}
+	if again, _ := inv.PlanByID(ctx, p.ID); again.Backups == nil || again.Backups.State != BackupDone {
+		t.Fatalf("the change was not kept: %+v", again.Backups)
+	}
+}